From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A104C77B7D for ; Sat, 6 May 2023 01:37:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232458AbjEFBhD (ORCPT ); Fri, 5 May 2023 21:37:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbjEFBhB (ORCPT ); Fri, 5 May 2023 21:37:01 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 201C1468F; Fri, 5 May 2023 18:37:00 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id D9C7924E1BE; Sat, 6 May 2023 09:36:58 +0800 (CST) Received: from EXMBX171.cuchost.com (172.16.6.91) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Sat, 6 May 2023 09:36:58 +0800 Received: from [192.168.125.108] (183.27.98.219) by EXMBX171.cuchost.com (172.16.6.91) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Sat, 6 May 2023 09:36:58 +0800 Message-ID: Date: Sat, 6 May 2023 09:36:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v1 1/2] dt-binding: cdns,usb3: Add clock and reset Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Pawel Laszczak , Greg Kroah-Hartman , Peter Chen , Roger Quadros , Philipp Zabel CC: , , References: <20230502081805.112149-1-minda.chen@starfivetech.com> <20230502081805.112149-2-minda.chen@starfivetech.com> <154c67fc-3c4c-f65d-cf23-9c127175472f@linaro.org> From: Minda Chen In-Reply-To: <154c67fc-3c4c-f65d-cf23-9c127175472f@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.98.219] X-ClientProxiedBy: EXCAS065.cuchost.com (172.16.6.25) To EXMBX171.cuchost.com (172.16.6.91) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/3 4:08, Krzysztof Kozlowski wrote: > On 02/05/2023 10:18, Minda Chen wrote: >> To support generic clock and reset init in Cadence USBSS >> controller. Add clock and reset dts configuration. >> >> Signed-off-by: Minda Chen > > Subject prefix: dt-bindings > ok >> --- >> Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> index cae46c4982ad..7bffd8fb1e38 100644 >> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> @@ -42,6 +42,18 @@ properties: >> - const: otg >> - const: wakeup >> >> + clocks: >> + minItems: 1 > > no, this must maxItems. > ok >> + >> + clock-names: >> + minItems: 1 > > Drop entire property, not useful without descriptive name. > So I will delete clock-names and reset-names in my starfive codes. >> + >> + resets: >> + minItems: 1 > > instead maxItems. > >> + >> + reset-names: >> + minItems: 1 > > Drop entire property, not useful without descriptive name. > >> + >> dr_mode: >> enum: [host, otg, peripheral] >> > > Best regards, > Krzysztof >