From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76816224B15 for ; Tue, 6 Jan 2026 02:55:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767668127; cv=none; b=Cot8l5HEJqJRBe4UqevtLfdiaRH8pRr0Oxbn8z5iul29iIdW3SEabvmzoQmJKK24kGFc17c5BxqCqY4+4tqIgL7KGcjhcr9XviAcjNf6vA1EgcXeddZYxzxTxfDjRlMBZGQw+sNQ01bISzZ/xPDGubx2nthxhFN0YbfXHiLxzts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767668127; c=relaxed/simple; bh=e+bHD5TKtbpywM0stm8uonBloPKJPmN4SpJbj/PrQJI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OzW8agpjV/PAbdDC/hqrXPDc8gNMF27wxRaMyvULtTDwsN106hDwjZ0+KKWsDcVJSvcel2DvXrhwNsNSC52UUMpOzp7dwqxo14GRe5EN4iGnK3JOSh4anIgh8lGDuAPuw/1ey8Z5PJHpJCqOkCco0VW+aF6tUst9npZ8Asge878= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KEUOHeOW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jEx29UmG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KEUOHeOW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jEx29UmG" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6060nKmf2886390 for ; Tue, 6 Jan 2026 02:55:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jeK2FlfxI96cOkTAnGRDcPuRUDyzWVMyyzk3ooH1how=; b=KEUOHeOW7w22wUh6 /835hD5eNA5LZRwFgs0e5XSrclQoade/N+Om6uliJAR6A4Zd9BiGWZBomu3Si3w6 EdUrLW31fMr/3d8J8h24J1qyvre1BVMZd3u88fLZ8pyMIE6aHwKVWQhGoRL13Lzz gNCDlr+Z7j+xZCnGTapVL0wjKmswuJI1CqJNqdlDVg1hQXgYkz9Z0Rf2ziZk0DJx dwVX07lJJF7W3Ec23w5mW17QSACvLRLtYX4yq8ZuntTZ55FWj66KY2Tn8S5xkObP +r37+5T2eWzuX/qwP39Zft5LW+trL1uehUMwXFE0CrggPp89FDpj4W+7oVoIwH5V ABgDnw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bgpnd8fww-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 02:55:25 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2a0a8c465c1so15216365ad.1 for ; Mon, 05 Jan 2026 18:55:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767668124; x=1768272924; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jeK2FlfxI96cOkTAnGRDcPuRUDyzWVMyyzk3ooH1how=; b=jEx29UmGS1YeZ+/IWMM5Vx0YoVG3uK3ivXsFVF8rFrsTny/Sc1oefqEUTn9gWuao16 NVubKoeKBpZQaKeureyZi2TdjjHLpwI6HpKcTtm9gF/jXOshwwl0gSLB3zPNIssbeSV/ UhRmn/5GK/z0XDOUiLyI5pSLgx7g1h1KmbXhuiW2WM5CyNXc15eFR1rfsk01dl1Q8FlA ui8Yt2IsH6oKdwzgrIzzh0UajSBeN65+B+skOmFBdKuzqzhEDVCjJHsvQWBb2oHs23vu Bz1K0RfpUF9mYOSrqoLEVZg/vQnme2J304A+bNt9bAPnf3hWl6QxY5t0Ap/vXXt2pAyk IUow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767668124; x=1768272924; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jeK2FlfxI96cOkTAnGRDcPuRUDyzWVMyyzk3ooH1how=; b=R3PiZiwOjSQYu4v58M8ySNFhBjbQ5Sc93oNtRvl7v9vWZNZfq/0jqW3ph+jv28t0h6 M1m9ro8wzRu57oQc6js4EHNHikG2AHfWRN+7X8WrhYoWfi+EDm3Wani5oOltEmbHzJcC KIs4rEFYwj3dZyO2nmd3MCZWf+mg9rICQgOjcvb6p0PyV0MVVaHr6aL+fk9rK6F3j1U3 8TWT0AGjHbNMLz09c+S+5kLGrSynqBXbnKAujwm52o6Vx28zg8ev3ErGbiCpQ5axvYJa 1l386hHFnLGWyF2wKJ5GcZN9gW1nn/9tVdXRO2v/zTqddoou4669H+gjdWc3eexpAYVc qzCA== X-Forwarded-Encrypted: i=1; AJvYcCXVc2c83V+5EMR4X9Sm05RE4ufA1OAhviufOn6Nv0I/Qlq6b0b2t84kjXttRlt7O8kTj3icGojOCvYHeCE=@vger.kernel.org X-Gm-Message-State: AOJu0YzjQDsV1DBLfngrLRPEsnkug85hTNzXk5WqVtGT0hertiCrB4V/ cQH+JQ6D9TKhsnkXx2p0X+4FgxmphvoxvB76GmAUIK82jZ0rGsAMa7tU/tgoSqH/JDFdCDC6rED Rw2N5s3BHTDhr7vMvSJ3CqCUo0NgEhL66+3tsSrzU2p8OFs7mXE2k2wSzZZ97VEQdRVE= X-Gm-Gg: AY/fxX6oJA7BbR9AdCQNxjwRjy8XEMhvPxzOnsaNK2jGWwhT5xVl7aeH2Vokp8tp7mA HBI1/m4kq5xbn51CcoSm1PxnYMFyj32aJxoBlkU90SNJ0G7b26j2BQ6Qhoa1WClmwS/dyuQbVQ4 xc3oQ9OaJiuVg0LMjCCA9nZlRtPTP+p6zwv5gMNXgbi/cp3/hDoUivvTf3nmB0u3B4u6PLcxF59 4gCWLk3iCydibH94Cp6fehpJuuQuzOxI9xwNBRrrBPfx4TqTwvpgbJxRs2tP7wkasobuAcvYM9W 3pf75s+iTYzyFQVkz05lqBA8yKL4hCYWMPtUtNLbXG1+f38nGVUErrymDtLxVxTFLjSaZv4Ascl 58UqKAxuKs3KYyO/b1upyxB+tEkfI44brPbVaREgWmsuO4VGjjaJ/RAhpyAHG91NOxP62zm4aHG pu7gsmaA== X-Received: by 2002:a17:902:c40c:b0:29e:e5e6:247c with SMTP id d9443c01a7336-2a3e39d82bdmr10652455ad.14.1767668124326; Mon, 05 Jan 2026 18:55:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEm+epUO5voVQquz6sVBvYJuUN550AnDeQ2R3i6J+Q6+wFvDH9JwAks/rShsvT3f0wEY+uGtg== X-Received: by 2002:a17:902:c40c:b0:29e:e5e6:247c with SMTP id d9443c01a7336-2a3e39d82bdmr10652225ad.14.1767668123882; Mon, 05 Jan 2026 18:55:23 -0800 (PST) Received: from [10.133.33.54] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd4be5sm5391245ad.99.2026.01.05.18.55.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jan 2026 18:55:23 -0800 (PST) Message-ID: Date: Tue, 6 Jan 2026 10:55:20 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] wifi: ath10k: fix dma_free_coherent() pointer To: Thomas Fourier Cc: stable@vger.kernel.org, Jeff Johnson , Kalle Valo , Govind Singh , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260105210439.20131-2-fourier.thomas@gmail.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260105210439.20131-2-fourier.thomas@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: -SnMsLNUpBGLedWIioylkPkQ2QZOkljA X-Proofpoint-GUID: -SnMsLNUpBGLedWIioylkPkQ2QZOkljA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDAyMyBTYWx0ZWRfXyaDQ6BRWzSqT CBv1v7rJ6E8Q32SVEPgnUkg8KELWS4B8bOKKmQyio+j9bubepKMC/KnACC3bHGj/H1TCT8eFSc9 zMse0kSe3WqMnX3n0Kxtz5UpwoApZabOQjmHmvhdgbGfGHm5UvZxUfg/uWIjbH1TAgvVzDM7Kd+ sqUDqQlFYxqs8yb3YTwy36AbAsi9XkzoUDKC/KpiTCGjCDLpVjvtZmABexIYrc/8vJh9qdYZX3x IkuN+F5ekXWB25e+VR/2raRQezIu8jB33Xxv/XmIV42vqjPrkxYAB2yMGbEYsNCGOBg16okrzsG +c/XEERTY6RdOhDRHvKcq6cVZ2zN9CFYSEe617UhFF12yFSRjnNdmMK2AufVDVQzXClSHJhLuWI ca34dc4ikaccD7GZIheki9+KYUtQBzcS7Sz2AKjkYP2Nwn7EBVqGIqIhh0rosOKFEBTgAK7HILl 7U7KYk9O+jxGlR7viwA== X-Authority-Analysis: v=2.4 cv=Jpz8bc4C c=1 sm=1 tr=0 ts=695c799d cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=sJ90gTr51a4L_-UUfAIA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_02,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 clxscore=1015 adultscore=0 phishscore=0 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060023 On 1/6/2026 5:04 AM, Thomas Fourier wrote: > dma_alloc_coherent() allocates a DMA mapped buffer and stores the > addresses in XXX_unaligned fields. Those should be reused when freeing > the buffer rather than the aligned addresses. > > Fixes: 2a1e1ad3fd37 ("ath10k: Add support for 64 bit ce descriptor") > Cc: > Signed-off-by: Thomas Fourier Reviewed-by: Baochen Qiang > --- > drivers/net/wireless/ath/ath10k/ce.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/ath10k/ce.c > index 7bbda46cfd93..82f120ee1c66 100644 > --- a/drivers/net/wireless/ath/ath10k/ce.c > +++ b/drivers/net/wireless/ath/ath10k/ce.c > @@ -1727,8 +1727,8 @@ static void _ath10k_ce_free_pipe(struct ath10k *ar, int ce_id) > (ce_state->src_ring->nentries * > sizeof(struct ce_desc) + > CE_DESC_RING_ALIGN), > - ce_state->src_ring->base_addr_owner_space, > - ce_state->src_ring->base_addr_ce_space); > + ce_state->src_ring->base_addr_owner_space_unaligned, > + ce_state->src_ring->base_addr_ce_space_unaligned); > kfree(ce_state->src_ring); > } > > @@ -1737,8 +1737,8 @@ static void _ath10k_ce_free_pipe(struct ath10k *ar, int ce_id) > (ce_state->dest_ring->nentries * > sizeof(struct ce_desc) + > CE_DESC_RING_ALIGN), > - ce_state->dest_ring->base_addr_owner_space, > - ce_state->dest_ring->base_addr_ce_space); > + ce_state->dest_ring->base_addr_owner_space_unaligned, > + ce_state->dest_ring->base_addr_ce_space_unaligned); > kfree(ce_state->dest_ring); > } > > @@ -1758,8 +1758,8 @@ static void _ath10k_ce_free_pipe_64(struct ath10k *ar, int ce_id) > (ce_state->src_ring->nentries * > sizeof(struct ce_desc_64) + > CE_DESC_RING_ALIGN), > - ce_state->src_ring->base_addr_owner_space, > - ce_state->src_ring->base_addr_ce_space); > + ce_state->src_ring->base_addr_owner_space_unaligned, > + ce_state->src_ring->base_addr_ce_space_unaligned); > kfree(ce_state->src_ring); > } > > @@ -1768,8 +1768,8 @@ static void _ath10k_ce_free_pipe_64(struct ath10k *ar, int ce_id) > (ce_state->dest_ring->nentries * > sizeof(struct ce_desc_64) + > CE_DESC_RING_ALIGN), > - ce_state->dest_ring->base_addr_owner_space, > - ce_state->dest_ring->base_addr_ce_space); > + ce_state->dest_ring->base_addr_owner_space_unaligned, > + ce_state->dest_ring->base_addr_ce_space_unaligned); > kfree(ce_state->dest_ring); > } > seems ath12k has the same issue, would you like to fix it as well?