From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Nancy.Lin" <nancy.lin@mediatek.com>, CK Hu <ck.hu@mediatek.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"jason-jh . lin" <jason-jh.lin@mediatek.com>,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, singo.chang@mediatek.com,
srv_heupstream@mediatek.com
Subject: Re: [PATCH v6 10/16] soc: mediatek: add mtk-mutex support for mt8195 vdosys1
Date: Thu, 14 Oct 2021 17:01:38 +0200 [thread overview]
Message-ID: <ccbaff29-808a-4c7b-51d4-764cf283fbbc@collabora.com> (raw)
In-Reply-To: <20211004062140.29803-11-nancy.lin@mediatek.com>
> Add mtk-mutex support for mt8195 vdosys1.
> The vdosys1 path component contains ovl_adaptor, merge5,
> and dp_intf1. Ovl_adaptor is composed of several sub-elements,
> so change it to support multi-bit control.
>
> Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-mutex.c | 296 ++++++++++++++++++-------------
> 1 file changed, 175 insertions(+), 121 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
> index 36502b27fe20..7767fedbd14f 100644
> --- a/drivers/soc/mediatek/mtk-mutex.c
> +++ b/drivers/soc/mediatek/mtk-mutex.c
> @@ -29,113 +29,142 @@
>
> #define INT_MUTEX BIT(1)
>
> -#define MT8167_MUTEX_MOD_DISP_PWM 1
This patch doesn't only add support for MT8195 vdosys1, but also changes
all definitions to a different "format", and also changes the type for
"mutex_mod" from int to long.
In reality, the actual functional change is minimal, compared to the size of
this entire patch.
Please, split this patch in two parts: one patch changing the defines and
the mutex_mod type (specifying that it's a preparation for adding support for
mt8195 vdosys1 mutex) and one patch adding such support.
Thanks!
Regards,
- Angelo
next prev parent reply other threads:[~2021-10-14 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211004062140.29803-1-nancy.lin@mediatek.com>
[not found] ` <20211004062140.29803-7-nancy.lin@mediatek.com>
2021-10-14 14:52 ` [PATCH v6 06/16] soc: mediatek: add mtk-mmsys " AngeloGioacchino Del Regno
[not found] ` <20211004062140.29803-10-nancy.lin@mediatek.com>
2021-10-14 14:56 ` [PATCH v6 09/16] soc: mediatek: mmsys: modify reset controller for MT8195 vdosys1 AngeloGioacchino Del Regno
[not found] ` <20211004062140.29803-11-nancy.lin@mediatek.com>
2021-10-14 15:01 ` AngeloGioacchino Del Regno [this message]
[not found] ` <20211004062140.29803-3-nancy.lin@mediatek.com>
2021-10-15 8:08 ` [PATCH v6 02/16] dt-bindings: mediatek: add vdosys1 MERGE property for mt8195 AngeloGioacchino Del Regno
2021-10-15 16:21 ` Chun-Kuang Hu
[not found] ` <20211004062140.29803-5-nancy.lin@mediatek.com>
2021-10-15 23:41 ` [PATCH v6 04/16] dt-bindings: reset: mt8195: add vdosys1 reset control bit Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccbaff29-808a-4c7b-51d4-764cf283fbbc@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-jh.lin@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nancy.lin@mediatek.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=singo.chang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome