From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Anup Sharma <anupnewsmail@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Meerwald <pmeerw@pmeerw.net>,
broonie@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: temperature: Add DT bindings for TMP006
Date: Sat, 13 May 2023 20:35:02 +0200 [thread overview]
Message-ID: <ccbf7ae3-5d52-070a-ba19-3ff54e6161e8@linaro.org> (raw)
In-Reply-To: <20230513195030.57b7939e@jic23-huawei>
On 13/05/2023 20:50, Jonathan Cameron wrote:
> On Fri, 12 May 2023 08:28:29 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
>> On 11/05/2023 21:06, Anup Sharma wrote:
>>> On Thu, May 11, 2023 at 11:28:50AM +0200, Krzysztof Kozlowski wrote:
>>>> On 10/05/2023 20:56, Anup Sharma wrote:
>>>>> Add devicetree binding document for TMP006, IR thermopile sensor.
>>>>
>>>> Why? Where is any user of this? DTS? Driver?
>>>>
>>>
>>> The support for TMP006 is available at driver/iio/temperature
>>
>> There is no such compatible in the kernel. If you add OF support, you
>> should change the driver.
>
> (Very) old driver, so it uses the fallback method that i2c provides to bind to
> the compatible with the vendor id dropped via i2c_device_id entry.
Yeah, I know it works... but is very confusing :)
>
> Having said that, I'd also prefer the addition of an explicit of_device_id table.
> As there is only one supported device in this driver should be trivial.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-05-13 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 18:56 Anup Sharma
2023-05-11 9:28 ` Krzysztof Kozlowski
2023-05-11 19:06 ` Anup Sharma
2023-05-12 6:28 ` Krzysztof Kozlowski
2023-05-13 18:50 ` Jonathan Cameron
2023-05-13 18:35 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccbf7ae3-5d52-070a-ba19-3ff54e6161e8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=anupnewsmail@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®