From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 853BA265623 for ; Thu, 13 Aug 2026 19:48:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786650484; cv=none; b=uN4JVAxrYpbsmfoOz0ezERo0eWDlIA0YfwcCmkaNndpgzOKwXOWVcI3BwOJFn+TgVxIhd7IJEQP66oQfFGtTbyfyueFRVfAyA++/EJ4PbklYoCNZOEssXxlq66OO4Uyfb9vVwpZN9nKYvpCIfaItsTNP34Eu6xQCzn0CnDODdyg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786650484; c=relaxed/simple; bh=jdff9RjTJ6FX5CYneqmJRs3kJJfu3JM/pEar10ZoML0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rPYgTBbbCje7vFXOPtqLKNqEeNw3xQIgFW3RVnDYmHlfEMNdXn8U+uyqRTOqEdr3BIf+Te4AQEy8r+SIwEF5PM/QnAy0kGL4miUG/zEx4A59KD+jt6blqWZnPQFSALRHd5kKKMDrNVCp2blxkSdXst6O2MHuG0iDqIefKnW7VvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tHwEfD9t; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tHwEfD9t" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso2707395e9.3 for ; Thu, 13 Aug 2026 12:48:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786650481; x=1787255281; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DPXs8j8erucli+FArrA6gPvW9i2D52YxZx0U6KvKwvs=; b=tHwEfD9t2z4dGX2O31aooggmxQZDtYZ+CutHDnny21u3TlvtSgT5Aj9zz8i3fhF8FI xLFVXp3zkS2crcqwXkD0itRu2nOpAbQ4tUL22LWvXP9dWJ28Oymf/GR5D9CdxBcgiZNL 5J5xh1AzmaPyNNS1idZ8gUT91APhjc4c7NZq9Op/VSogkBtSlOmP0V23W5FStZ4bYfIx 90dL7mvjHW8XkRmHr2MPtMG5QqjN8Q4v5V4wPAj1+UqLRsf8J8FJY5SixvI043mNuGUV p3m1U4ogGENYKkPFJtbLNKa45uIqA/jWOuZWuX3kBuJtBYhzfFD9NTj4l/GbBWszL39g xF2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786650481; x=1787255281; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DPXs8j8erucli+FArrA6gPvW9i2D52YxZx0U6KvKwvs=; b=YB2BUOGVIbYMKAjQ2kyiS2fAX9QnqqC2xeiN3UbM74BvE1yTY4o2cRP2TV2tXO5aNw gFxf3M8HwyiduULUjOR254QkXtTiHVeVXNld6n6D6JkRV0ABeOprjLdWbLjK34wmMkjV vPhwvGJbA90+l8DYBivNFaPk/X5i5ybuimxYOauhY7/Dfl5FrmYEIR5O8gdVaGPmamF4 4bpCpih1zZqLNh6hU/H1TaW8c+BYZaa/m14nQYcz0owwgABA5yTr7eTgsBWS2MV48HBd Cudta4bW+R9sBXh44UZIkiWBBRMA/wDyEAVkooyT7zdW3i+REeySp2ZM/BpT2ggJ6Gdx zm0w== X-Forwarded-Encrypted: i=1; AHgh+RrGR0An3F6UC/z92+EXiIOG2Dt0+NXKj8HEWNdIKPIkovIoL+mw3LKvuYkzFyXkbJIanHwjQumMt+L2BWQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc2zJFrTMEChGL4eXVqtXDmuv5DctKrg+1zjRIHP+vV8oav62D BAPNaSgr6YFViYfNGwR/ySZqYDUG6Yt0sC6ZyN7o285nog3M7zkJDaol X-Gm-Gg: AR+sD12E1c6S2Zcsv9On98I6C9X4rFBVstEJmdr7gGcgC1DXGp/zroNyWrYOZTiaEYo 2lR/zB7IIbhdgLmZnic5u6CUZZpFkS9u2CVk7on5gPoG8w0PuWWxPoaw59X88HKSunkM2MBXNjh jCpRozLkA7Ks75ifoC2VYdqdjyUWF1/y6FeK+6Kfxwz/v8dm8dwa6dXGrQenDDJ0ESHu4HLC3go g3k3Q+b/jItht1CcXEEAK44D0gYu7WYWDQozDojJFU+Dm62a9gvOThd2uZ0cUeEx52IvSJJVs4c cbrm8Ax6FeDCkVbjY8T/wEIP3GNBwuwYy6Qb7DUMF+kdPgCFnssKfvZ7WRKIOosY3FBRDo6npjc hnIft2c8BnMKnPNtQUgk1u0NDFdIcFVAsJAV28qmBQo5sPMiOSFQFW213nbzG8RERiOdJJAe+D9 Bhk3JhfryBias2+BtYOIGZfmAHux990IZSbYj/m+EOuocFcCP3QvPnpIu7VsdM1YCr/ya3sw== X-Received: by 2002:a7b:c5ce:0:b0:499:726c:d658 with SMTP id 5b1f17b1804b1-499879bb9e5mr6552485e9.19.1786650480602; Thu, 13 Aug 2026 12:48:00 -0700 (PDT) Received: from [192.168.1.50] ([79.119.240.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49981b631c1sm178430575e9.14.2026.08.13.12.47.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Aug 2026 12:47:59 -0700 (PDT) Message-ID: Date: Thu, 13 Aug 2026 22:47:58 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH rtw-next] wifi: rtw88: usb: send broadcast/multicast via the AC queues To: Mehmet Fide Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Mehmet Fide References: <12eaffd0-9d0f-44bd-8163-d05b6a3df611@gmail.com> <20260813185021.2290877-1-mehmet.fide@gmail.com> Content-Language: en-US From: Bitterblue Smith In-Reply-To: <20260813185021.2290877-1-mehmet.fide@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/08/2026 21:50, Mehmet Fide wrote: > From: Mehmet Fide > > Hello Bitterblue, > >> Could you check what the official driver is doing in the same situation? >> >> https://github.com/morrownr/88x2bu-20210702 > > Good timing, we had already done exactly that comparison before your > mail arrived. That driver was our working reference on the same bench > throughout the investigation (5/5 reconnect cycles where in-tree fails > 0/5), and we went through its AP transmit path to understand why it is > immune. It handles this quite differently, in five ways: > > 1. bmc frames are buffered only while a station is actually dozing > (sta_dz_bitmap check in core/rtw_xmit.c, rtw_xmit_ap_enqueue). With > no sleeper present they leave immediately through the normal AC > path, which is what my patch restores for rtw88. > > 2. The buffering happens in software (the bmc sta's sleep_q), not in > the hardware high queue. The hardware HIQ receives at most one DTIM > burst at a time (chk_bmc_sleepq_hdl), so it can never accumulate > into the page pool the way rtw88's standing high queue does. > > 3. Even then, a filter decides what may ride the HIQ at all. The > default (rtw_hiq_filter=1, "allow special") lets only ARP, EAPOL and > DHCP through; mDNS/SSDP chatter never enters the high queue. The > rest of the buffered frames go out through the normal queues when > the burst is released. > > 4. The driver owns the TIM bit itself: it sets it when it starts > buffering, pushes the updated beacon, and clears it only after both > the software queue and the hardware HIQ are empty, polled through > HW_VAR_CHK_HI_QUEUE_EMPTY. It does not depend on a beacon download > whose pages come from the same pool the backlog is exhausting. > > 5. MORE_DATA is set on every burst frame except the last one, which > carries 0 and terminates the burst. rtw88 sets it on every high > queue frame including the last. That may be part of why I measured > the burst fetch not happening here even with BIT_TCR_UPDATE_HGQMD > set: the hardware never sees the end marker the vendor code > provides. > > So the field-proven driver never routes bulk multicast through the high > queue either, sleeper or not; the high queue is a small, filtered, > explicitly terminated DTIM burst buffer for it, not a transport path. > > Given that, I still think routing bmc through the AC queues is the > right minimal fix for rtw88 USB. If you want to keep buffered delivery > for dozing stations I am happy to work on the fuller shape, meaning PS > tracking plus a software staging queue released at DTIM, but that is a > much bigger change and the current behavior is a hard AP breakage. > > Thanks, > Mehmet I don't know enough to have an opinion on this. Shouldn't mac80211 handle the buffering already?