From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88D1C33B6DB for ; Tue, 7 Jul 2026 15:01:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783436471; cv=none; b=kb0rlbe7BGZlDK1rKwTitZv4IvtVlJd28eLb0NtIr6NqiUn6A79ZJGi1ECqAFhA8mIHHIUt2cI4co+F7lg88TKrzPecaZ1bpVNpJ7rcT3Jd9JmcCfdDU/li8yPfaPycE+FQcqgvKtbk2Y6uR4u76EJ1qjZEc0hj2cGSWw1FS8zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783436471; c=relaxed/simple; bh=+D/GGUvcOsimqDxyfbKlcMTFoXoX4b6/62l9AGfFEj0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OxpXtsL4uPG+FYpHbVJ7HufkZqya+urtTvWbOh0nHEnmqPbKxFg/7gHyrgx+u0zX5W4k9d66BViz7TaiDS5qvmICSUc6BCESlrglXrmzpU/AXEnZoWxZYeiS7axfHACu18ZUaQk42D/JDbej8rUzk5jsVwmM6Pyk5/EU+qs4t98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A/TwjlHq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jIDNLRF3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A/TwjlHq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jIDNLRF3" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 667C8e2c3606093 for ; Tue, 7 Jul 2026 15:01:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ROX+UpJqvFR7fE/ZOEkvXIlyQXppUvkxvyHyF/TuUNk=; b=A/TwjlHq75KU/ZfW CEJVy/6uAXqhErvWZQH3r7SMvWy/EOLUEFWmmM/iNaNS9FsGg9UMPWtI442kAMJ2 coSYWWVmTC4sdigS9xM4kr9hNfQjo8rkNJnja5XeIw5haUZc9pUI/HkBICOUW8mj 5gZt4m/yLpTgZLgEh8BL4FOe9P33CUuZwPHv+xJMkAd5e7niKHo/oXm71RiqMqXb sMJbq0c37+cOidroAvWFNDmmAYbteU4b6E5b08bgVK7rkehwTHNzc9ov2Kuq1WL4 viesWAegCBvxaSSrpU4AS8X5ZI+N1TA0VspkJRvvs5x8oObkzcyujjjlO3rRpGMx Q1AvIg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8sm8jjy8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 15:01:09 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8478d2bea7cso904803b3a.1 for ; Tue, 07 Jul 2026 08:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783436469; x=1784041269; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ROX+UpJqvFR7fE/ZOEkvXIlyQXppUvkxvyHyF/TuUNk=; b=jIDNLRF3ABNqnnYPH0TfxSriV3/l/+GjxxEC1/yJetk9opv1YX+hDqj2jjHT3+S4+4 /ryV2q40vFEMpWlp5r6aqMpMtXhyU6gOK2kB8kJFUZGjxVeJ4VevU7jbXwQnCTAPJDOW OTMQsrwnKTEkdLfXZsO0g3riJOIN7lNss80y2kf5dVZCumYSSuvBooRW3A4wSYl1Mzw4 v9gHXco6E9b2uFF2/oo89EUeE1GqQExmR6NKpW/ZPmcWU2lKT5F/mcYq9AdNnrDGtY// AfkZVilH1oMyM3oBkILWOoDUx7/sx5WCE0xtqZNK56lE9HmpMdzhIGwSitQKfGsmUbwM ZlkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783436469; x=1784041269; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ROX+UpJqvFR7fE/ZOEkvXIlyQXppUvkxvyHyF/TuUNk=; b=g5mIshqcBZrx4fgDDcT3qGJeoMT4PnHYRWknUd8IevQlg0q4/o5fZXkOfuK97mm/wO sAVeDHa5tO/5LFTHSQUO+uEqoo6NXB1LvGnP0DChKeg10PlhSLk6b+JsDmazahInjAsW PSiPAGwlBlkpL5CWtB7x8zOBI/aIJAuO9jmPA2noFnW2/Y+0EXXWpd2jciKF5n4levpI Q8chrqcSxh/3g3P5VFwlJtNTbSz8G5mo0FAVvEbbgZ9ttEGAtYQlQpmtV9ua+bs+Rawx WAH3itHDA0sYjMs/De9YP8giHxH1M8ZH3uBFlV4bcZGFljMG++fQUZkEziVQf+e/8D8W z8Rg== X-Forwarded-Encrypted: i=1; AHgh+Rrr/enVXQSRqgwJjrfPzRg1CEjr6PMChfnGRZUL/kKS8Oc2o4etj6OV78ITxPvxqlGsZFHoqTPptS39p8M=@vger.kernel.org X-Gm-Message-State: AOJu0YwpP+38J/h7/2QjzyXQDqVtcl4GQQMhbGJ02yivHuE9y8ktxL54 i/xPyr/S0hGq41uyXqNSB2zb7AznWflV5Y/EisdGLXbtJTls93CLAU0GnkovhR7avLO6zRSizXQ lw3OY1oL67Emc3IL2M4rSnB/0J/M2G2exceXKXCfFk0i3u55eQOLv/pBdSJSgnHChDu8= X-Gm-Gg: AfdE7ckktAUAf7uxzuarPaGH6BUrGhu7EfVAdiVewVgKhcNe9uHza2CyqNtQSZzpKD+ /8J2vSXOMaiWQMoHGS4vpoUlb31PZB0cpQgtE4P2ZvnSyEjEpqk+kafCOSDNmX5gKHvuh6zx6pJ K3hWjcm1FtoS1tRTjh2iYl1P+hnx5R1cWiTvws6+n9X0e8GAefVqgdx6VRYGPjeOwpj6MzjCcjh 1cNHpQ6qCShQRxXoq2lxhyTRTf6uJuTGpMPcruM2Hae50X6IXqMuyj4qrvpT5EekYzur7nPHktG saNKU+C3zE3iH6fvCPjvOpurzYiys6/x1P33DE8ijtogJHZVK9FnIqTfIMSGpg/QuzletdSFEO7 QZq79kjXt5YjAnfFbiwHntUK8Lc7z5zB0s421WCbW+lXH X-Received: by 2002:a05:6a20:6a0b:b0:3bf:a8fa:a7b1 with SMTP id adf61e73a8af0-3c09b48c10cmr3970591637.37.1783436469159; Tue, 07 Jul 2026 08:01:09 -0700 (PDT) X-Received: by 2002:a05:6a20:6a0b:b0:3bf:a8fa:a7b1 with SMTP id adf61e73a8af0-3c09b48c10cmr3970553637.37.1783436468698; Tue, 07 Jul 2026 08:01:08 -0700 (PDT) Received: from [10.204.101.214] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b6593c9a1sm10749401c88.2.2026.07.07.08.01.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 08:01:07 -0700 (PDT) Message-ID: Date: Tue, 7 Jul 2026 20:30:59 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 13/16] media: iris: Introduce buffer size calculations for AR50LT To: Dmitry Baryshkov Cc: Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal References: <20260616-iris-ar50lt-v5-0-583b42770b6a@oss.qualcomm.com> <20260616-iris-ar50lt-v5-13-583b42770b6a@oss.qualcomm.com> <09f6f0bd-6bde-4dbf-9be7-623c17232b16@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDE0NyBTYWx0ZWRfX5ALabKBjO5ds +7glglOWMVoJPzgjoQgRB0ZYvgZXaA15hosR7JkV0yfO3AKTtLXXXLdjFSPDIbxwUmcUwX0nsvt jZjukH0VWxZY2MAjqrjIR8EQAETJma5AIK2a1TJ+aXLZZwgM+gudocWOz9OAHhaRHtgkRG9Uc6M zlUp2q89dUvUCjk3n9SMT685kKYK4ayPSPTgHpRc0yLcxOYkXqsFTwKFOE52mWyD52E5cK5trpG 4hVN1yQiAQ3+Mv+tQVz4YPuTg8D7+3bJ4DVSgekWokqNQDU5lDHBcDOsoD0wauYw1CCmwXITaJp Q6UZbD89GEgENlBGHj0baB04LT23JV6/rlXe4ci69sqBlfBXKtmQBIjVmnPJsvDiHQrMFcMvaDf 3VqfFHgMhqLeBSFKaV1m3z4lKXdG4N4lMRdQ3TePFMpGwuykqxLuX0xB9bC89X+wUqlovQToI/I YiDgTa88lJXvpQg8xFQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDE0NyBTYWx0ZWRfX65wlsT+m0Vin OIkawstVn+/MzYeuC1EBbIaEfsIT7Ur0IpdRlEL43vEbAY+cgpcElcwk9W5D5bucT3F0E3TIyAr 40D85OVajErCpkRZ8AVivBli9TEnw5A= X-Proofpoint-GUID: yXkXmLnAZifnJRuT69by3X9UV3Yur_2t X-Authority-Analysis: v=2.4 cv=UvdT8ewB c=1 sm=1 tr=0 ts=6a4d14b5 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=FtO3_dRub200-A8TgkkA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: yXkXmLnAZifnJRuT69by3X9UV3Yur_2t X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_03,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070147 On 7/1/2026 7:19 PM, Dmitry Baryshkov wrote: > On Wed, Jun 24, 2026 at 08:40:02PM +0530, Vikash Garodia wrote: >> >> >> On 6/16/2026 5:34 AM, Dmitry Baryshkov wrote: >>> From: Dikshita Agarwal >>> >>> Introduces AR50LT buffer size calculation for both encoder and >>> decoder. Reuse the buffer size calculation which are common, while >>> adding the AR50LT specific ones separately. >>> >>> Signed-off-by: Dikshita Agarwal >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> drivers/media/platform/qcom/iris/iris_vpu_buffer.c | 401 +++++++++++++++++++++ >>> drivers/media/platform/qcom/iris/iris_vpu_buffer.h | 37 ++ >>> 2 files changed, 438 insertions(+) >>> >>> @@ -507,6 +734,13 @@ u32 hfi_buffer_line_vp9d(u32 frame_width, u32 frame_height, u32 _yuv_bufcount_mi >>> return _lb_size + vpss_lb_size + 4096; >>> } >>> +static inline >>> +u32 hfi_buffer_line_vp9d_ar50lt(u32 frame_width, u32 frame_height, u32 _yuv_bufcount_min, >>> + bool is_opb, u32 num_vpp_pipes) >>> +{ >>> + return hfi_ar50lt_vp9d_lb_size(frame_width, frame_height, num_vpp_pipes); >> >> pls keep same name across like "hfi_buffer_line_vp9d_ar50lt" and >> "hfi_ar50lt_vp9d_lb_size" or combine these 2 apis, as the one just calls the >> other. > > I think, Sashiko pointout a different issue here. Should I be calling > size_vpss_lb() to take is_opb into account? The comment is generalizing the ar50 with other iris variants, we dont need that for AR50LT variants. > >> >>> +} >>> + >>> static u32 hfi_buffer_line_h264d(u32 frame_width, u32 frame_height, >>> bool is_opb, u32 num_vpp_pipes) >>> { > Regards, Vikash