From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [PATCH v5 0/9] rtc-cmos,rtc-mc146818-lib: fixes
Date: Fri, 7 Jan 2022 14:14:58 +0100 [thread overview]
Message-ID: <cccbd4cf-f302-b64d-bf32-abdefbc7c6d0@o2.pl> (raw)
In-Reply-To: <Ydg6EnPdWjB3Vznc@piout.net>
W dniu 07.01.2022 o 14:03, Alexandre Belloni pisze:
> Hi,
>
> On 07/01/2022 13:49:25+0100, Mateusz Jończyk wrote:
[snip]
>> v5: Increase maximum accepted duration of the UIP high pulse from 10 to 20ms,
>> in case there are some very slow chips out there.
>>
>> Note: this may cause problems with hpet_rtc_interrupt() if the CMOS
>> RTC stops working while the system is running and RTC update
>> interrupt / RTC alarm interrupt is enabled (which should be rare).
>> In this case, hpet_rtc_interrupt() is executed 64 times per second
>> and takes up to 20ms to complete - which may constantly occupy
>> one CPU. I am not sure if this is likely enough to implement
>> special handling of this case in hpet_rtc_interrupt().
>>
> Because v4 has been applied,
Nice, thank you! I didn't know about this.
> you'd have to send a series against rtc-next.
OK
Greetings,
Mateusz
next prev parent reply other threads:[~2022-01-07 13:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 12:49 Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 1/9] rtc-cmos: take rtc_lock while reading from CMOS Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 2/9] rtc: change return values of mc146818_get_time() Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 3/9] Check return value from mc146818_get_time() Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 4/9] rtc-mc146818-lib: fix RTC presence check Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 5/9] rtc-mc146818-lib: extract mc146818_avoid_UIP Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 6/9] rtc-mc146818-lib: refactor mc146818_get_time Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 7/9] rtc-mc146818-lib: refactor mc146818_does_rtc_work Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 8/9] rtc-cmos: avoid UIP when reading alarm time Mateusz Jończyk
2022-01-07 12:51 ` [DEBUG PATCH v5] rtc-cmos: cmos_read_alarm bug demonstration Mateusz Jończyk
2022-03-29 20:02 ` [PATCH v5 8/9] rtc-cmos: avoid UIP when reading alarm time Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 9/9] rtc-cmos: avoid UIP when writing " Mateusz Jończyk
2022-01-07 13:03 ` [PATCH v5 0/9] rtc-cmos,rtc-mc146818-lib: fixes Alexandre Belloni
2022-01-07 13:14 ` Mateusz Jończyk [this message]
2022-01-07 15:34 ` [PATCH] RFC: rtc-mc146818-lib: wait longer for UIP to clear Mateusz Jończyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cccbd4cf-f302-b64d-bf32-abdefbc7c6d0@o2.pl \
--to=mat.jonczyk@o2.pl \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®