From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Vikash Garodia <vgarodia@codeaurora.org>,
hverkuil@xs4all.nl, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, acourbot@chromium.org
Subject: Re: [PATCH] venus: vdec: fix decoded data size
Date: Wed, 3 Oct 2018 15:36:37 +0300 [thread overview]
Message-ID: <ccce4e75-e800-1d10-2350-463d4a72d481@linaro.org> (raw)
In-Reply-To: <1538566221-21369-1-git-send-email-vgarodia@codeaurora.org>
Hi Vikash,
On 10/03/2018 02:30 PM, Vikash Garodia wrote:
> Exisiting code returns the max of the decoded size and buffer size.
> It turns out that buffer size is always greater due to hardware
> alignment requirement. As a result, payload size given to client
> is incorrect. This change ensures that the bytesused is assigned
> to actual payload size, when available.
>
> Signed-off-by: Vikash Garodia <vgarodia@codeaurora.org>
> ---
> drivers/media/platform/qcom/venus/vdec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
> index 991e158..189ec97 100644
> --- a/drivers/media/platform/qcom/venus/vdec.c
> +++ b/drivers/media/platform/qcom/venus/vdec.c
> @@ -888,8 +888,7 @@ static void vdec_buf_done(struct venus_inst *inst, unsigned int buf_type,
> unsigned int opb_sz = venus_helper_get_opb_size(inst);
>
> vb = &vbuf->vb2_buf;
> - vb->planes[0].bytesused =
> - max_t(unsigned int, opb_sz, bytesused);
> + vb2_set_plane_payload(vb, 0, bytesused ? : opb_sz);
> vb->planes[0].data_offset = data_offset;
> vb->timestamp = timestamp_us * NSEC_PER_USEC;
> vbuf->sequence = inst->sequence_cap++;
>
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
--
regards,
Stan
next prev parent reply other threads:[~2018-10-03 12:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 11:30 Vikash Garodia
2018-10-03 12:36 ` Stanimir Varbanov [this message]
2018-10-05 15:26 ` Stanimir Varbanov
2018-10-08 11:19 ` Vikash Garodia
-- strict thread matches above, loose matches on Subject: below --
2018-07-02 7:44 Vikash Garodia
2018-07-02 8:51 ` Alexandre Courbot
2018-07-06 15:12 ` Stanimir Varbanov
2018-07-06 17:09 ` Alexandre Courbot
2018-07-07 12:26 ` Stanimir Varbanov
2018-07-18 11:31 ` Stanimir Varbanov
2018-07-18 13:26 ` Nicolas Dufresne
2018-07-18 14:37 ` Stanimir Varbanov
2018-09-17 10:00 ` Hans Verkuil
2018-09-17 14:30 ` Stanimir Varbanov
2018-09-17 14:32 ` Hans Verkuil
2018-09-19 10:32 ` Alexandre Courbot
2018-09-19 15:02 ` Stanimir Varbanov
2018-09-19 15:53 ` Nicolas Dufresne
2018-09-20 3:02 ` Tomasz Figa
2018-09-25 9:41 ` Stanimir Varbanov
2018-10-02 7:38 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccce4e75-e800-1d10-2350-463d4a72d481@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=acourbot@chromium.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome