From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47A012FD69D for ; Tue, 9 Dec 2025 14:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765291033; cv=none; b=QF+kMz8iAx5ucAZUaXBFt8nHEMeffZK0WSFz+1EGEvSeSp85IhN4CT16raEMl2+48V/QtiEom9G3jVAFd2Rx4W+Wt02EHQgM2cNL7w15nslPSm2qZc4EI9Dz6cPThNE1G9yXtfgrPlRE7LSF99eZPA6ODCzZ5msWFUhwVsfhCUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765291033; c=relaxed/simple; bh=jPCiTfm5BtmAyDqz4dpNFWOwHkPHShS71sU+oP4hgYQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eIITGZe1iWndQxDq5N712riDDe7vDeskJ3nTr0teyteV0mv+NPZXSHQHRqxuUVy0IHZ7HfUouUrO1DEaj4Sn+MvQySf3/PYdA1vC972lEn8/2nJq9yVbqYYCaOAPJ66RHAUqiDxJuUwfzOKWZSbJpzYNL7914XmuMKgcL0RrnDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SEjQyzbt; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SEjQyzbt" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so73116515e9.2 for ; Tue, 09 Dec 2025 06:37:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765291028; x=1765895828; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j7I6ils17hDCA2e6qFPfR6Sw1ycg9esI4gXIyqhs7Ek=; b=SEjQyzbtS2MrNiTiB0trVfMb3DQbSQn/HpHh1gqp8UWbooQ2t/EzFf+wAyoz7g2R6p hCHtntGBwxM4sZVUgSPwGu39ZCAi3LrlXs2QymLs0a3jPPhqEZPZvNLnLIUUFJAHYHF9 aOA1i8VUqej05wNRgKRfsey2HQJozzVZI1Ph2OYVNMxEYfd25qeQuBBvbKQBXmWcH3J9 raFMbeVo1zCh7KmuYJROudZarfPGsO6r5Fgq/oIvdIByqGy4F3VeCR/aAffy2nE1blKc jZ5lL/P8IDDL7gudgz8TY6gElXjWnGAdf9DVyfq3M7u5CgQN3wZq4RHgueaC7Birv2y9 jqyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765291028; x=1765895828; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j7I6ils17hDCA2e6qFPfR6Sw1ycg9esI4gXIyqhs7Ek=; b=cnclHnbUqX9G5eypAzf4FtX0CIeYYDMbcnG4D/1kGGITU9dd3LaG9bwL5QAPDBJp5K YnPt2l05k7AVTBj9h3ouZaP0HukP7ZNSorE0hDv9BjntIHyUmc1I8pQztVdl/pFIzs/r 9TqkWgxVyR9++Vu5TLdEIb7h+5IGquIpjz9DSpKZlDtPgHfhwPPLcvgEAL7ZJvNwnfjx 9oOk8DcCAit8XsZMnssbrrFYZXyF4eENE4tFfS1xio06JJFOI46gx+5K0nRi5rRBPTWz hpiq3DB75NdLOzRmE4Z9KfkDpXs+MLsctLmwSzgDo5xVLx5oykmD976J+RxLP4lHLCoB /e5Q== X-Forwarded-Encrypted: i=1; AJvYcCUChisK7HWNhmR89A5IdptzVa2Vvn5R+Sc9N/DmJ4tl18SJU7NsAh4l6/O7IAn0977ji2GlCflIKrGbD5E=@vger.kernel.org X-Gm-Message-State: AOJu0YzCYzcl4jFxA6TgRe6REHGwx1DzvDKBAwOpWSx38tbCH4tTcMTH CVvMO1v3/7VUDdl8xuF1dSjhCkHYBi8+7v6wb8azQnyQvjidveQ0mFCBB9HRIj6mYIE= X-Gm-Gg: ASbGncsDHVmB7ZkBTDHrh+f2kr3Vo5j8K+iskp1PmDWSRt3hQ25vbrEgwt9yZcvMhjG 8eKTdeg4cten4xv0Eqmj2ZcS0autM9u1tRnx5PEaYZTGdu79ZylHoveFUpnQ9M6EkS8Rk+tSBoL 7UY59HdyKMAxTRVb0myW6EDX7CFgTFkyHn+FAalBRtCpM4AnCmvZLcceSKMFv87fZFPQch7pGnR YKDwM5sPxN4M5DHSSJUMHw42du2+YmTMqR+OelOtyxy8/cpzWfX5/JEEFRpy5yZ8KK10vfB8T18 k51Z1Q77x4V+rMS4R2txKkoGXMcEYL/J0xKATgLZV9P+CwU4ztNJpS/tFbmklA7YZZMOUjtNw6b XEr8nlx5pjng0WWfvAHCwX+k6HCVcxp+S1kTrg3cIjy/TCCuKRqe9TXIcye01njncGxrcy1lu53 PEmlQjE1qQh6vjsB1C X-Google-Smtp-Source: AGHT+IHOCArQRCixwS/QxD+LfLjq2i2YGAKLD9OGv4He4/CXuZ3NOgcnnS08tJHh+fDElmffX96jyw== X-Received: by 2002:a05:600c:a593:b0:479:3a87:208f with SMTP id 5b1f17b1804b1-4793a8720f6mr73856975e9.36.1765291028436; Tue, 09 Dec 2025 06:37:08 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a7d6228e8sm41449625e9.5.2025.12.09.06.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 06:37:08 -0800 (PST) Date: Tue, 9 Dec 2025 17:37:04 +0300 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Borislav Petkov , Tony Luck , Aristeu Rozanski , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] EDAC/i5400: Fix snprintf() limit calculation in calculate_dimm_size() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: The snprintf() can't really overflow because we're writing a max of 42 bytes to a PAGE_SIZE buffer. But my static checker complains because the limit calculation doesn't take the first 11 space characters that we wrote into the buffer into consideration. Fix this for the sake of correctness even though it doesn't affect runtime. Also delete an earlier "space -= n;" which was not used. Fixes: 68d086f89b80 ("i5400_edac: improve debug messages to better represent the filled memory") Signed-off-by: Dan Carpenter Reviewed-by: Qiuxu Zhuo --- v2: Delete the earlier "space -= n" which is not used. Fix the subject drivers/edac/i5400_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/i5400_edac.c b/drivers/edac/i5400_edac.c index b5cf25905b05..fb49a1d1df11 100644 --- a/drivers/edac/i5400_edac.c +++ b/drivers/edac/i5400_edac.c @@ -1026,13 +1026,13 @@ static void calculate_dimm_size(struct i5400_pvt *pvt) space -= n; } - space -= n; edac_dbg(2, "%s\n", mem_buffer); p = mem_buffer; space = PAGE_SIZE; n = snprintf(p, space, " "); p += n; + space -= n; for (branch = 0; branch < MAX_BRANCHES; branch++) { n = snprintf(p, space, " branch %d | ", branch); p += n; -- 2.51.0