From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752781AbeACNjx (ORCPT + 1 other); Wed, 3 Jan 2018 08:39:53 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:39816 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752176AbeACNju (ORCPT ); Wed, 3 Jan 2018 08:39:50 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AF16360250 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH] i2c: fix ACPI_I2C_OPREGION dependency To: Randy Dunlap , Eric Auger , eric.auger.pro@gmail.com, wsa@the-dreams.de, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-acpi@vger.kernel.org" References: <1511370357-17184-1-git-send-email-eric.auger@redhat.com> <48ff2e75-5ee0-5ac9-8d47-58c3c691ad6e@infradead.org> From: Sinan Kaya Message-ID: Date: Wed, 3 Jan 2018 08:39:47 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/2/2018 1:19 PM, Sinan Kaya wrote: > On 1/2/2018 1:10 PM, Randy Dunlap wrote: >>>> config ACPI_I2C_OPREGION >>>> bool "ACPI I2C Operation region support" >>>> - depends on I2C=y && ACPI >>>> + depends on I2C && ACPI >>>> default y >>>> help >>>> Say Y here if you want to enable ACPI I2C operation region support. >>>> >>> Anybody picking this up? >> Well. It looks to me like the patch is reversed or the patch description >> needs some improvement. Or I just don't understand it. > > I'll let Eric improve the description. > > Issue is that if you compile I2C as a module, ACPI_I2C_OPREGION doesn't get selected. > Therefore, any ACPI opregion calls targeting I2C fail with no opregion found. > > The goal is to select ACPI_I2C_OPREGION independent of the I2C module type selection. > I hope I was able to explain it. =y above is the problem. This config option will only be selected if module is built-in not for m case. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.