From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E652533438F for ; Mon, 1 Jun 2026 09:03:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780304593; cv=none; b=dXisiXwq8eEOcrxIvUXPML/YJS+SYwVA3tsbox3a0B5UJ8cTpSNpxmlDyH1tzFEtlyQSiOZvR8C9o0/q8vagjxSyc0gT71TeBwJcbApTEiMVJPNCAM95gdjwMj+oURrjcbiIS4ZRHoTQXJKudrK4u0gtIV4xzEqXqPddV+pI+Q0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780304593; c=relaxed/simple; bh=iwdGIixbB7IOMHjvrCrRUD7du6GO/MdYTz5mqcpT0VA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m4ZJa8avuZcoZVTA7ZhKk2wC+3Y8m4zBRa2Hnh8A2Uag6ay+cu24M7BO2otHPjDqsle6lNuzJ4EgzGjsfHV/UbnSbkdil9Ax/4pBiu+s76B+3tgd67PWdBIUYg82b7f/AO7YqqkZK/t3voqoFkfIVHCa7E23TSo/9clYWuOtAVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fzOsO17G; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=GF5fV+Wf; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fzOsO17G"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="GF5fV+Wf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780304590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TjeavFCyvS+F4PVctKdom+5aTQFqQqXbjivYX79fNas=; b=fzOsO17GJ4YRNF9U7DwXYoi+X7uZB07TQ9AqlO3suG414eF1IfBeJcGwwgDmT3Ds8/J7Mz 2UiTSKwm8mhhj22EEsqSWvW7qbV0j1N2C3aeSVqmxio+REedVblGkUeYxxpa22L6GxJjg6 mbuTcl+elADSCzNXHQ5IM5U0eZ+Di94= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-L91D7ca1P4Skx2dx_HKEOQ-1; Mon, 01 Jun 2026 05:03:09 -0400 X-MC-Unique: L91D7ca1P4Skx2dx_HKEOQ-1 X-Mimecast-MFC-AGG-ID: L91D7ca1P4Skx2dx_HKEOQ_1780304588 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-490a763180bso10265985e9.0 for ; Mon, 01 Jun 2026 02:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780304588; x=1780909388; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TjeavFCyvS+F4PVctKdom+5aTQFqQqXbjivYX79fNas=; b=GF5fV+WfyRo8YDhUkf9ux4GEwdtITpLk6oxuVC1HbQixjLBhTcRgogHsH5+/2CA+LZ UoPKBPy7DGqzN40VsP1L6fjOEup1zH8vGASn8lXwZlMhl/WvHI3Hy/AX+HrALp4+6a39 eWTrh7eGk4bthVCC6SaHgI/JIaL1RNaQrKUILopFIkIYU4CPat4ebCxxPlLuq20cHikB hqRMO/PVleUVYEs/dv3xvDtfaVZ42kiLFRQ0bv/UUZoAF/2QVdQreziU+gjAaOkH5/Uf uWKvgZtkjkbn++ymxHiD53FXK46YHgvlJ87SNc0RTG+CxqZDkY8gjvP75qSn00gmy2IK ZQ2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780304588; x=1780909388; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TjeavFCyvS+F4PVctKdom+5aTQFqQqXbjivYX79fNas=; b=dAkI6KjRFMndxzgSU6E309n1uhhZ0Md7FOZYur7Z/1xtCiGhO4ln1yXRvGCyHYRorO 0oB0BZOaytBg4bh69T6ubtTYoixdg0jXmReLssYEd8q0Ve5ZoAMmunAYFeGW++lxEBge FqRDaK1eeRHwUWYzzYRhX+xV/zCBai7YlY+p5eM7b8OUgZDLhhb+oEfJT7t9T2dukSyP QPe1k59IKxZNyeCacjb5jlUxdEw8prO9901RINb85tCLrUE0AsuUf8EQH7O3y0YfASOz Ch6W9Vwm/uSmBW6XVtKSx8LhUYJIhhOqodD2iavlHVRMLr2y7oBjmF4DOoi5XRyElt8c /Cpw== X-Forwarded-Encrypted: i=1; AFNElJ9qSag1suytBGQnGXqQwltkbNdJ5sXodJ/dYk8sUrlcQrC6KsRrAehKYWtkiaNJ8GdUUkJ6waAytmeoze8=@vger.kernel.org X-Gm-Message-State: AOJu0YzsAbmtL666UUNVXOEWqzRxZyZq4OHwN12TsdWhIuEZ7Ct3xNs6 6gzalF2je2tLjg/2/c4+akB7u/M3wLP/CmvuA46g+DfxLjC+6qHRCD32et8NfS0AGjAj44QdsjF d6k0Ihm3Gt+a9W8tGJ2a/6tuYOSCIAAn8urjHeg65qj05aGpaODdql20E2kTqy7YFKQ== X-Gm-Gg: Acq92OFtPNw57iVecAJcMupojCaPhdF221oH1TDOajCG3c+NA9FDuoCl05BcrP04xIn m8Ja2sQaFrnLiIwCElt0yKo/K7XSEViFc3huGMCCVxb12k5eTyaEKwHVCnY6/dX7N1U0+aZk69d TKGN4QwZ02kbHoRyMYNleZrZD04/puxOvMEFh4Qc03HPiJ8Y/444t4er2tNGU08zfrteCbGTBy3 yIcJlWKvOf0rbyBfbi5S5U5lU5zCrLs8moouICD1xsXQhlUAlHlpuzbACmFKmRkhHYueQymNSMB k/cYCgFtxDKW5HK3L9hkGV/BJy3uhRyl/nzs7FG9hTFhaNgySahjmdVouPdQGWG8OPz2Dt0yKbb xzOemEK0aktw9XxeGJNqsR+4eU5Hg2AdpoKsSjxTVSJconikXwLtdMg1SnMd9o7HAehOm X-Received: by 2002:a05:600d:8498:10b0:489:5022:39a4 with SMTP id 5b1f17b1804b1-490a2915da1mr135982115e9.9.1780304588239; Mon, 01 Jun 2026 02:03:08 -0700 (PDT) X-Received: by 2002:a05:600d:8498:10b0:489:5022:39a4 with SMTP id 5b1f17b1804b1-490a2915da1mr135981535e9.9.1780304587780; Mon, 01 Jun 2026 02:03:07 -0700 (PDT) Received: from [192.168.88.32] ([169.155.232.197]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909d7002e8sm261964345e9.15.2026.06.01.02.03.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2026 02:03:07 -0700 (PDT) Message-ID: Date: Mon, 1 Jun 2026 11:03:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 7/9] net: dsa: microchip: implement port_hsr_join for KSZ9477 only To: "Bastien Curutchet (Schneider Electric)" , Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Russell King Cc: Pascal Eberhard , =?UTF-8?Q?Miqu=C3=A8l_Raynal?= , Thomas Petazzoni , Tristram Ha , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260526-clean-ksz-3rd-v1-0-5b63e732149a@bootlin.com> <20260526-clean-ksz-3rd-v1-7-5b63e732149a@bootlin.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260526-clean-ksz-3rd-v1-7-5b63e732149a@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/26/26 11:47 AM, Bastien Curutchet (Schneider Electric) wrote: > @@ -1744,12 +1784,20 @@ void ksz9477_hsr_join(struct dsa_switch *ds, int port, struct net_device *hsr) > /* Setup HW supported features for lan HSR ports */ > user = dsa_to_port(ds, port)->user; > user->features |= KSZ9477_SUPPORTED_HSR_FEATURES; > + > + dev->hsr_dev = hsr; > + dev->hsr_ports |= BIT(port); > + > + return 0; > } > > -void ksz9477_hsr_leave(struct dsa_switch *ds, int port, struct net_device *hsr) > +static int ksz9477_hsr_leave(struct dsa_switch *ds, int port, > + struct net_device *hsr) > { > struct ksz_device *dev = ds->priv; > > + WARN_ON(dev->chip_id != KSZ9477_CHIP_ID); Since the new op is used only by the relevant switch version, I think you could/should remove the above warning. /P