mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Tao Xiao <guanlan@awinic.com>
Cc: Hans de Goede <hansg@kernel.org>,
	 "open list:ACPI SERIAL MULTI INSTANTIATE DRIVER"
	<platform-driver-x86@vger.kernel.org>,
	 open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: serial-multi-instantiate: Do not request IRQ for AW88399
Date: Wed, 11 Nov 2026 14:28:53 +0200 (EET)	[thread overview]
Message-ID: <ccd77135-cb25-d49f-7e30-1777682485e9@linux.intel.com> (raw)
In-Reply-To: <20261111043759.306458-1-guanlan@awinic.com>

On Wed, 11 Nov 2026, guanlan@awinic.com wrote:

> From: Tao Xiao <guanlan@awinic.com>

I expected problem or justification described here first, but all I got 
was what was done:
 
> Set the IRQ resource type to IRQ_RESOURCE_NONE for both instances so
> the device instantiates regardless of the ACPI interrupt description.

Was there like a problem with some device that you're trying to fix? Why 
that's not mentioned?

-- 
 i.

> Signed-off-by: Tao Xiao <guanlan@awinic.com>
> ---
>  drivers/platform/x86/serial-multi-instantiate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/serial-multi-instantiate.c b/drivers/platform/x86/serial-multi-instantiate.c
> index ffec4f0a4992..f69ad3815c8c 100644
> --- a/drivers/platform/x86/serial-multi-instantiate.c
> +++ b/drivers/platform/x86/serial-multi-instantiate.c
> @@ -309,8 +309,8 @@ static void smi_remove(struct platform_device *pdev)
>  
>  static const struct smi_node aw88399_hda = {
>  	.instances = {
> -		{ "aw88399-hda", IRQ_RESOURCE_AUTO, 0 },
> -		{ "aw88399-hda", IRQ_RESOURCE_AUTO, 0 },
> +		{ "aw88399-hda", IRQ_RESOURCE_NONE, 0 },
> +		{ "aw88399-hda", IRQ_RESOURCE_NONE, 0 },
>  		{}
>  	},
>  	.bus_type = SMI_AUTO_DETECT,
> 
> base-commit: 067c5c24cef23d913b67eaaf71ae67e7169a6620
> 

      reply	other threads:[~2026-11-11 12:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  4:37 guanlan
2026-11-11 12:28 ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccd77135-cb25-d49f-7e30-1777682485e9@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=guanlan@awinic.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®