From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753300AbeCPUd3 (ORCPT ); Fri, 16 Mar 2018 16:33:29 -0400 Received: from mga01.intel.com ([192.55.52.88]:52723 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751880AbeCPUdZ (ORCPT ); Fri, 16 Mar 2018 16:33:25 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,317,1517904000"; d="scan'208";a="25347999" Subject: Re: [PATCH 13/22] signal: Move addr_lsb into the _sigfault union for clarity To: "Eric W. Biederman" References: <87k1wimybi.fsf_-_@xmission.com> <20180116004009.31036-13-ebiederm@xmission.com> <29eb3438-0891-36ee-e5f6-36e26ccf2b89@intel.com> <818f8945-f990-a770-476e-f82bdc77dbda@intel.com> <87efkjeqe8.fsf@xmission.com> Cc: linux-kernel@vger.kernel.org, Al Viro , Oleg Nesterov , linux-arch@vger.kernel.org, Ram Pai From: Dave Hansen Message-ID: Date: Fri, 16 Mar 2018 13:33:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87efkjeqe8.fsf@xmission.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/16/2018 01:06 PM, Eric W. Biederman wrote: >> It does not revert cleanly so I reverted it manually. Patch doing that >> is attached. Should we do this, or is there a better option? > Please see: > 859d880cf544 ("signal: Correct the offset of si_pkey in struct siginfo") It would be really nice to actually cc the folks that wrote and maintain the code when you both break their stuff and fix it. I don't see myself or the x86 maintainers cc'd on any of this: the patch that caused the breakage *or* the fix.