From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753677AbcEYKf4 (ORCPT ); Wed, 25 May 2016 06:35:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42137 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbcEYKfy (ORCPT ); Wed, 25 May 2016 06:35:54 -0400 Subject: Re: [PATCH v3] sched/cputime: add steal time support to full dynticks CPU time accounting To: Wanpeng Li , Rik van Riel References: <1463574454-3587-1-git-send-email-wanpeng.li@hotmail.com> <1464117768.16149.46.camel@redhat.com> Cc: "linux-kernel@vger.kernel.org" , kvm , Wanpeng Li , Ingo Molnar , "Peter Zijlstra (Intel)" , Thomas Gleixner , Frederic Weisbecker , Radim From: Paolo Bonzini Message-ID: Date: Wed, 25 May 2016 12:35:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 25 May 2016 10:35:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/05/2016 04:16, Wanpeng Li wrote: > Ping Paolo or Peterz. No need to ping, since Rik reviewed it 7 hours ago so the thread has gotten a bump in our mailboxes. And anyway this is the merge window, which is the most annoying time to get pings and one-patch changes. I don't mind at all getting large series during the merge window, but the small ones definitely can wait a week or two. Thanks, Paolo > 2016-05-25 3:22 GMT+08:00 Rik van Riel : >> On Wed, 2016-05-18 at 20:27 +0800, Wanpeng Li wrote: >>> From: Wanpeng Li >>> >>> This patch adds steal guest time support to full dynticks CPU >>> time accounting. After 'commit ff9a9b4c4334 ("sched, time: Switch >>> VIRT_CPU_ACCOUNTING_GEN to jiffy granularity")', time is jiffy >>> based sampling even if it's still listened to ring boundaries, so >>> steal_account_process_tick() is reused to account how much 'ticks' >>> are steal time after the last accumulation. >>> >>> Suggested-by: Rik van Riel >>> Cc: Ingo Molnar >>> Cc: Peter Zijlstra (Intel) >>> Cc: Rik van Riel >>> Cc: Thomas Gleixner >>> Cc: Frederic Weisbecker >>> Cc: Paolo Bonzini >>> Cc: Radim >>> Signed-off-by: Wanpeng Li >> >> This also nicely fixes up f9c904b7613b ("sched/cputime: >> Fix steal_account_process_tick() to always return jiffies"), >> which relies on a bool function returning a certain number >> of jiffies :) >> >> Reviewed-by: Rik van Riel >> >> -- >> All rights reversed > > >