From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854AbcHLMkg (ORCPT ); Fri, 12 Aug 2016 08:40:36 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:45631 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbcHLMke (ORCPT ); Fri, 12 Aug 2016 08:40:34 -0400 Subject: Re: [PATCH v3 2/9] hwmon: (core) New hwmon registration API To: Keerthy , Jean Delvare References: <1469417552-9749-1-git-send-email-linux@roeck-us.net> <1469417552-9749-3-git-send-email-linux@roeck-us.net> <57AD85C4.5020409@ti.com> Cc: Jonathan Cameron , Zhang Rui , Eduardo Valentin , Punit Agrawal , linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-omap@vger.kernel.org" , "R, Vignesh" From: Guenter Roeck Message-ID: Date: Fri, 12 Aug 2016 05:40:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <57AD85C4.5020409@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/12/2016 01:16 AM, Keerthy wrote: > On Monday 25 July 2016 09:02 AM, Guenter Roeck wrote: >> Up to now, each hwmon driver has to implement its own sysfs attributes. >> This requires a lot of template code, and distracts from the driver's core >> function to read and write chip registers. >> >> To be able to reduce driver complexity, move sensor attribute handling >> and thermal zone registration into hwmon core. By using the new API, >> driver code and data size is typically reduced by 20-70%, depending >> on driver complexity and the number of sysfs attributes supported. >> >> With this patch, the new API only supports thermal sensors. Support for >> other sensor types will be added with subsequent patches. >> > Hi Guenter, > > Seems like this patch introduces a cycling dependency between > thermal_sys and hwmon: > > DEPMOD 4.8.0-rc1-next-20160811-00001-g2f84cf7854e7 > depmod: ERROR: Found 2 modules in dependency cycles! > depmod: ERROR: Cycle detected: hwmon -> thermal_sys -> hwmon > > As reported by R, Vignesh . > Hmm ... interesting. Thanks for letting me know. I'll have to think about that. Guenter