Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

[Krzysztof Kozlowski <krzk@kernel.org>]

On 21/11/2024 03:15, Keith Zhao wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 2024年11月20日 15:38
>> To: Keith Zhao <keith.zhao@starfivetech.com>; devicetree@vger.kernel.org;
>> dri-devel@lists.freedesktop.org
>> Cc: andrzej.hajda@intel.com; neil.armstrong@linaro.org; rfoss@kernel.org;
>> Laurent.pinchart@ideasonboard.com; jonas@kwiboo.se;
>> jernej.skrabec@gmail.com; maarten.lankhorst@linux.intel.com;
>> mripard@kernel.org; tzimmermann@suse.de; airlied@gmail.com;
>> simona@ffwll.ch; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
>> hjc@rock-chips.com; heiko@sntech.de; andy.yan@rock-chips.com; William Qiu
>> <william.qiu@starfivetech.com>; Xingyu Wu <xingyu.wu@starfivetech.com>;
>> kernel@esmil.dk; paul.walmsley@sifive.com; palmer@dabbelt.com;
>> aou@eecs.berkeley.edu; p.zabel@pengutronix.de; Changhuang Liang
>> <changhuang.liang@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
>> linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.
>>
>> On 20/11/2024 07:18, keith zhao wrote:
>>> +	/* Unmute hotplug interrupt */
>>> +	hdmi_modb(hdmi, HDMI_STATUS, m_MASK_INT_HOTPLUG,
>>> +v_MASK_INT_HOTPLUG(1));
>>> +
>>> +	ret = devm_request_threaded_irq(hdmi->dev, irq, inno_hdmi_hardirq,
>>> +					inno_hdmi_irq, IRQF_SHARED,
>>> +					dev_name(hdmi->dev), hdmi);
>>> +	return ret;
>>> +}
>>> +EXPORT_SYMBOL_GPL(inno_hdmi_bind);
>>> +
>>> +MODULE_AUTHOR("Keith Zhao <keithzhao@starfivetech.com>");
>>> +MODULE_DESCRIPTION("INNO HDMI transmitter driver");
>>> +MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:inno-hdmi");
>>
>> You should not need MODULE_ALIAS() in normal cases. If you need it, usually it
>> means your device ID table is wrong (e.g. misses either entries or
>> MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute for incomplete
>> ID table.
>>
> Thank you for your suggestion! 
> I will review the device ID table to ensure its completeness 
> and avoid using MODULE_ALIAS().

In this context neither MODULE_ALIAS nor ID table are suitable/needed.
If you need them, means your driver does not build in all setups :/
Best regards,
Krzysztof