mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>, Guopeng Zhang <guopeng.zhang@linux.dev>
Cc: "Ridong Chen" <ridong.chen@linux.dev>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"Hui Peng" <benquike@gmail.com>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup/cpuset: Properly disable partition when partition state switching fails
Date: Tue, 29 Sep 2026 14:21:21 -0400	[thread overview]
Message-ID: <ccfaf01f-2bd9-41fd-b733-693de840c2f4@redhat.com> (raw)
In-Reply-To: <95e04dc55645c84c033ccca1a1359d84@kernel.org>


On 9/29/26 12:42 PM, Tejun Heo wrote:
> Hello,
>
> On Tue, Sep 29, 2026 at 03:40:27PM +0800, Guopeng Zhang wrote:
>> However, after the parent is created, the ownership of full housekeeping
>> CPUs can still change, so passing the check at creation time doesn't seem
>> to guarantee that returning CPUs later is still safe.
> I think any CPU under an isolated partition should count as isolated when
> testing whether the system has a housekeeping CPU left, whether child
> partitions carved some out or not. Those CPUs go back to the isolated
> parent whenever the child partition is disabled or invalidated, so they
> can't be counted on for housekeeping. In your example, making C isolated
> would then fail.

I am now thinking about treating the whole user defined exclusive CPUs 
(exclusive_cpus or cpus) as wholly owned by the cpuset in question from 
the housekeeping check perspective.  That will require reworking the 
current housekeeping checking code and will require more extensive 
changes. So it will take some time before a patchset will be ready for 
review. This will prevent housekeeping check failure when a child 
partition is disabled and its CPU are moved back to its parent.

Cheers,
Longman


      reply	other threads:[~2026-09-29 18:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 23:51 Waiman Long
2026-09-29  2:07 ` Tejun Heo
2026-09-29  3:16   ` Waiman Long
2026-09-29  7:40     ` Guopeng Zhang
2026-09-29 15:49       ` Waiman Long
2026-09-29 16:42       ` Tejun Heo
2026-09-29 18:21         ` Waiman Long [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccfaf01f-2bd9-41fd-b733-693de840c2f4@redhat.com \
    --to=longman@redhat.com \
    --cc=benquike@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=guopeng.zhang@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=ridong.chen@linux.dev \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®