mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Alain Volmat <alain.volmat@foss.st.com>,
	Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
	Sylvain Petinot <sylvain.petinot@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] media: i2c: st_mipid02: cascade s_stream call to the source subdev
Date: Wed, 19 Jul 2023 12:26:37 +0200	[thread overview]
Message-ID: <cd0a1ec0-5ab9-dc14-b1ca-c990b062b3c5@xs4all.nl> (raw)
In-Reply-To: <20230711123211.794838-2-alain.volmat@foss.st.com>

On 11/07/2023 14:32, Alain Volmat wrote:
> Cascade the s_stream call to the source subdev whenever the bridge
> streaming is enable / disabled.
> 
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> ---
>  drivers/media/i2c/st-mipid02.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c
> index 906553a28676..703d2f06f552 100644
> --- a/drivers/media/i2c/st-mipid02.c
> +++ b/drivers/media/i2c/st-mipid02.c
> @@ -547,6 +547,13 @@ static int mipid02_stream_disable(struct mipid02_dev *bridge)
>  	struct i2c_client *client = bridge->i2c_client;
>  	int ret;
>  
> +	if (!bridge->s_subdev)
> +		goto error;

I'm getting this compiler warning:

media-git/drivers/media/i2c/st-mipid02.c: In function 'mipid02_stream_disable':
media-git/drivers/media/i2c/st-mipid02.c:568:12: warning: 'ret' may be used uninitialized [-Wmaybe-uninitialized]
  568 |         if (ret)
      |            ^
media-git/drivers/media/i2c/st-mipid02.c:548:13: note: 'ret' was declared here
  548 |         int ret;
      |             ^~~

I'm dropping this series, waiting for a v2.

Regards,

	Hans

> +
> +	ret = v4l2_subdev_call(bridge->s_subdev, video, s_stream, 0);
> +	if (ret)
> +		goto error;
> +
>  	/* Disable all lanes */
>  	ret = mipid02_write_reg(bridge, MIPID02_CLK_LANE_REG1, 0);
>  	if (ret)
> @@ -633,6 +640,10 @@ static int mipid02_stream_enable(struct mipid02_dev *bridge)
>  	if (ret)
>  		goto error;
>  
> +	ret = v4l2_subdev_call(bridge->s_subdev, video, s_stream, 1);
> +	if (ret)
> +		goto error;
> +
>  	return 0;
>  
>  error:


  parent reply	other threads:[~2023-07-19 10:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-11 12:32 [PATCH 0/2] media: stm32: correct s_stream calls in dcmi & st-mipid02 Alain Volmat
2023-07-11 12:32 ` [PATCH 1/2] media: i2c: st_mipid02: cascade s_stream call to the source subdev Alain Volmat
2023-07-11 12:44   ` Benjamin Mugnier
2023-07-19 10:26   ` Hans Verkuil [this message]
2023-07-21 12:18     ` Alain Volmat
2023-07-11 12:32 ` [PATCH 2/2] media: stm32: dcmi: only call s_stream on " Alain Volmat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd0a1ec0-5ab9-dc14-b1ca-c990b062b3c5@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=alain.volmat@foss.st.com \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sylvain.petinot@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®