From: Adrian Hunter <adrian.hunter@intel.com>
To: Jiri Olsa <jolsa@redhat.com>, Stephane Eranian <eranian@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
mingo@elte.hu, Peter Zijlstra <peterz@infradead.org>,
"Shishkin, Alexander" <alexander.shishkin@intel.com>
Subject: Re: [RFC] perf record: dead code perf_event__synthesize_id_index()
Date: Thu, 3 May 2018 09:15:58 +0300 [thread overview]
Message-ID: <cd10fb5e-90bc-f190-6553-7b29cd618ef5@intel.com> (raw)
In-Reply-To: <20180502165737.GF11539@krava>
On 02/05/18 19:57, Jiri Olsa wrote:
> On Wed, May 02, 2018 at 04:38:33PM +0000, Stephane Eranian wrote:
>> Hi,
>>
>> It looks like perf_event__synthesize_id_index() is dead code in the current
>> tip
>> tree. I don't see any invocation of the function anywhere in perf.I
>> understand why
>> you'd want to keep the rest of the code related to PERF_RECORD_ID_INDEX
>> because some perf.data file may have this user-level record type. But the
>> synthesize code is not needed anymore, in my opinion.
>>
>> Shouldn't we remove this code?
>
> looks like there never was any user of it, probably some
> preparation for follow up that haven't happened yet.. Adrian?
Yes it is for AUX area sampling support, which we have patches for. Just
waiting on Alex to get the kernel side accepted.
prev parent reply other threads:[~2018-05-03 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 16:38 Stephane Eranian
2018-05-02 16:57 ` Jiri Olsa
2018-05-03 6:15 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd10fb5e-90bc-f190-6553-7b29cd618ef5@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@redhat.com \
--cc=alexander.shishkin@intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®