From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758325AbcHYHYE (ORCPT ); Thu, 25 Aug 2016 03:24:04 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:59145 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758299AbcHYHYB (ORCPT ); Thu, 25 Aug 2016 03:24:01 -0400 X-AuditID: cbfec7f4-f79cb6d000001359-e2-57be9a753072 Subject: Re: [PATCH v3 5/5] gpu: drm: exynos_hdmi: Remove duplicate initialization of regulator bulk consumer To: Milo Kim , Kukjin Kim , Krzysztof Kozlowski , David Airlie References: <1472044039-16536-1-git-send-email-woogyom.kim@gmail.com> <1472044039-16536-6-git-send-email-woogyom.kim@gmail.com> Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Rob Herring , linux-arm-kernel@lists.infradead.org From: Andrzej Hajda Message-id: Date: Thu, 25 Aug 2016 09:12:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1472044039-16536-6-git-send-email-woogyom.kim@gmail.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNLMWRmVeSWpSXmKPExsVy+t/xK7pls/aFG7yczGjRe+4kk8X8I+dY La58fc9m8fqFoUX/49fMFmeb3rBbbHp8jdXi8q45bBYzzu9jsmjde4TdYsbkl2wWtydPZ3Pg 8dg56y67x6ZVnWwe2789YPW4332cyWPzknqPvi2rGD0+b5ILYI/isklJzcksSy3St0vgyrh6 dzdbwXfuimNfrzI3MDZydTFyckgImEj8fXyfEcIWk7hwbz0biC0ksJRR4vScgi5GLiD7OaPE xwnNLCAJYYF8iX/P3jKBJEQEpjJK3O69wApR1cgo8XvBAxYQh1lgIZNE38YGsBY2AU2Jv5tv As3l4OAVsJM48NEcJMwioCrx7fp0VhBbVCBC4taqj2Bn8AoISvyYfI8FpJxTwE1i7TUmEJNZ QF1iypRckApmAXmJzWveMk9gFJiFpGEWQtUsJFULGJlXMYqmliYXFCel5xrqFSfmFpfmpesl 5+duYoREyZcdjIuPWR1iFOBgVOLh3bFqb7gQa2JZcWXuIUYJDmYlEd6KGfvChXhTEiurUovy 44tKc1KLDzFKc7AoifPO3fU+REggPbEkNTs1tSC1CCbLxMEp1cBYorp2Mc/xtW8jQx5qadl4 H3mglKYYrP/kbfK1PRdcy21Dmda4/xLf3OvZJC2Rtunyh383uyJnWcq+/3pXdd1rwXeVaimT /UU5P27x+5Zw1CniQeVamTO3fLPfJWzfsk5b71Vb6k3WE3fVfl5ctva9ytFbM9cv4ZnMu9Ip 98UnsaqI3Ofr8pR2KbEUZyQaajEXFScCAFelIGWOAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24/2016 03:07 PM, Milo Kim wrote: > The helper, devm_regulator_bulk_get() initializes the consumer as NULL, > so this code can be ignored. > > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: David Airlie > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Milo Kim Reviewed-by: Andrzej Hajda -- Regards Andrzej > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c > index 249cb23..4e17877f 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -1669,10 +1669,9 @@ static int hdmi_resources_init(struct hdmi_context *hdata) > if (ret) > return ret; > > - for (i = 0; i < ARRAY_SIZE(supply); ++i) { > + for (i = 0; i < ARRAY_SIZE(supply); ++i) > hdata->regul_bulk[i].supply = supply[i]; > - hdata->regul_bulk[i].consumer = NULL; > - } > + > ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(supply), hdata->regul_bulk); > if (ret) { > if (ret != -EPROBE_DEFER)