From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8246D2980BA for ; Fri, 11 Apr 2025 08:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744360552; cv=none; b=ZuitfhwDzRtO4K8AFt7vTtCYNylJWQHymN9LIK2VHqzC36HTaMllkeCEcBgbXIVEk1PGfBeqor+NyDo3OrvwOFuWhuM5mi9DEy9gB69ZsPJkiQFuJbkisyTBu5kr2I2yZkNv77UZN32eAg5YcQZGYJ8UFRUly93/KCdyaBpj9Wc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744360552; c=relaxed/simple; bh=+9AbACK5K6GlC+ll7IX0NZn7vGxKN9QF2fW0BIOEzKI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iPzynsd6j5hCuVOmr82TMuunWk3g8GSVER+FPDkgS39BGxl5yS1LA1LLQyDbQ8U89z/y+WRPOMKR3+kLkWdIP5/3LhCxyMEyWawQy/yGMxIjT0surByNYFyoUZbxXKzTETER9JbRhme+W/1AJ/UgF2VYttw1NaeNwtmDoGRdDD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=ocZhzBPb; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="ocZhzBPb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1744360548; bh=+9AbACK5K6GlC+ll7IX0NZn7vGxKN9QF2fW0BIOEzKI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ocZhzBPbK1nk7t+xQ27xK7ppksn+DK2uKAxqV98S1qXuZstwXZrsZZIzXrPUnxIhD ykJADh+etnfRyNnwtFdbrjl/h8fuBN3yTZWwXh9PXZGVmksEArM4KV4In8WhbAL9Pf 0QpiVfmb+11WcJPnea9GStdZdc74GdBH481069e9Fl7ldNjdhxt2NekSXKWFGJOfn/ ZYIdURYSydTcVHv8S8LWGgKSN5SYNVyTtAMtYZqarBIL+EDEcLx3poc/ChvMeVc7i6 57w9sMvpuV1cAkkH5TuLf+/rFIORzRL4bGK5h32/wJllz/tY8C4CUT9ow7UTSvezf3 kCHakW8OA5QbQ== Received: from [192.168.50.250] (unknown [171.76.80.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: vignesh) by bali.collaboradmins.com (Postfix) with ESMTPSA id E1C4B17E0EB8; Fri, 11 Apr 2025 10:35:44 +0200 (CEST) Message-ID: Date: Fri, 11 Apr 2025 14:05:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests To: Helen Koike , dri-devel@lists.freedesktop.org Cc: daniels@collabora.com, daniel@fooishbar.org, helen.fornazier@gmail.com, airlied@gmail.com, simona.vetter@ffwll.ch, robdclark@gmail.com, guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com, valentine.burley@collabora.com, lumag@kernel.org, quic_abhinavk@quicinc.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, linux-kernel@vger.kernel.org References: <20250409061543.311184-1-vignesh.raman@collabora.com> <2266002e-372d-434c-a2f5-282166e28c70@igalia.com> Content-Language: en-US From: Vignesh Raman In-Reply-To: <2266002e-372d-434c-a2f5-282166e28c70@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Helen, On 10/04/25 20:10, Helen Koike wrote: > > > On 10/04/2025 05:07, Vignesh Raman wrote: >> Hi Helen, >> >> On 09/04/25 23:53, Helen Koike wrote: >>> Hi Vignesh, >>> >>> Thank you for your patch. >>> >>> On 09/04/2025 03:15, Vignesh Raman wrote: >>>> Add jobs to validate devicetrees and run KUnit tests. >>>> >>>> Pipeline link, >>>> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1400550 >>> >>> I see the checks are in the same stage as build, does it make sense >>> to create another stage? Similar to what was proposed on kci-gitlab? >>> >>> Also, I don't think it make sense for kunit to be in the build stage. >>> Maybe in software-driver? Since kunit runs on a qemu. >> >> We can add a `test` stage for kunit and a `static-checks` stage for >> devicetree validation and check patch. What do you think? > > Ack on static-checks stage. I will update it. > > `test` stage confuses me, because all the other stages with driver names > are also tests, this is why I suggested to move to `software-driver`. > > Or maybe we could just have a kunit stage for now. Yes, we can add kunit stage. Let the `software-driver` have only vkms and virtio-gpu tests. Regards, Vignesh > > Helen > >> >> Regards, >> Vignesh >> >>> >>> Helen >>> >>>> >>>> Link to v1, >>>> https://lore.kernel.org/all/20250327160117.945165-1- >>>> vignesh.raman@collabora.com/ >>>> >>>> Vignesh Raman (2): >>>>    drm/ci: Add jobs to validate devicetrees >>>>    drm/ci: Add jobs to run KUnit tests >>>> >>>>   drivers/gpu/drm/ci/check-devicetrees.yml | 43 ++++++++++++++++++++ >>>> ++++ >>>>   drivers/gpu/drm/ci/dt-binding-check.sh   | 16 +++++++++ >>>>   drivers/gpu/drm/ci/dtbs-check.sh         | 19 +++++++++++ >>>>   drivers/gpu/drm/ci/gitlab-ci.yml         |  2 ++ >>>>   drivers/gpu/drm/ci/kunit.sh              | 11 ++++++ >>>>   drivers/gpu/drm/ci/kunit.yml             | 32 ++++++++++++++++++ >>>>   6 files changed, 123 insertions(+) >>>>   create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml >>>>   create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh >>>>   create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh >>>>   create mode 100755 drivers/gpu/drm/ci/kunit.sh >>>>   create mode 100644 drivers/gpu/drm/ci/kunit.yml >>>> >>> >> >