From: Lars-Peter Clausen <lars@metafoo.de>
To: Vasileios Amoiridis <vassilisamir@gmail.com>,
jic23@kernel.org, mazziesaccount@gmail.com
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] iio: core: remove iio_validate_own_trigger() function
Date: Sat, 21 Sep 2024 12:23:39 -0700 [thread overview]
Message-ID: <cd1df0c5-d95f-4880-b374-a7544a323d93@metafoo.de> (raw)
In-Reply-To: <20240921181939.392517-1-vassilisamir@gmail.com>
On 9/21/24 11:19, Vasileios Amoiridis wrote:
> The iio_validate_own_trigger() function was added in this commit [1] but it is
> the same with the below function called iio_trigger_validate_own_device(). The
> bodies of the functions can be found in [2], [3].
>
> [1]: https://lore.kernel.org/all/51cd3e3e74a6addf8d333f4a109fb9c5a11086ee.1683541225.git.mazziesaccount@gmail.com/
> [2]: https://elixir.bootlin.com/linux/v6.11/source/drivers/iio/industrialio-trigger.c#L732
> [3]: https://elixir.bootlin.com/linux/v6.11/source/drivers/iio/industrialio-trigger.c#L752
The signature of the two functions are different, the order of the
parameters is switched. So you can't just swap them out for the
`validate_trigger` callback since the signature is not compatible. But
maybe you can update the implementation of one of the functions to
calling the other function.
next prev parent reply other threads:[~2024-09-21 19:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-21 18:19 Vasileios Amoiridis
2024-09-21 18:19 ` [PATCH v1 1/2] iio: Drop usage of iio_validate_own_trigger() Vasileios Amoiridis
2024-09-22 3:17 ` kernel test robot
2024-09-22 3:27 ` kernel test robot
2024-09-21 18:19 ` [PATCH v1 2/2] iio: remove iio_validate_own_trigger() completely Vasileios Amoiridis
2024-09-21 19:23 ` Lars-Peter Clausen [this message]
2024-09-21 20:07 ` [PATCH v1 0/2] iio: core: remove iio_validate_own_trigger() function Vasileios Amoiridis
2024-09-22 9:44 ` Matti Vaittinen
2024-09-22 11:07 ` Vasileios Amoiridis
2024-09-28 14:55 ` Jonathan Cameron
2024-09-29 10:36 ` Vasileios Amoiridis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd1df0c5-d95f-4880-b374-a7544a323d93@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®