From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net v2] net: ethernet: 8390: Add HAS_IOPORT dependency for mcf8390
Date: Mon, 09 Dec 2024 18:12:44 +0100 [thread overview]
Message-ID: <cd1fb2205d974ee320ddb648c0589940e8646a6c.camel@linux.ibm.com> (raw)
In-Reply-To: <20241209-mcf8390_has_ioport-v2-1-3254267dc35e@linux.ibm.com>
On Mon, 2024-12-09 at 12:26 +0100, Niklas Schnelle wrote:
> Since commit 6f043e757445 ("asm-generic/io.h: Remove I/O port accessors
> for HAS_IOPORT=n") the I/O port accessors are compile-time optional. As
> m68k may or may not select HAS_IOPORT the COLDFIRE dependency is not
> enough to guarantee I/O port access. Add an explicit HAS_IOPORT
> dependency for mcf8390 to prevent a build failure as seen by the kernel
> test robot.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202412080511.ORVinTDs-lkp@intel.com/
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
> Changes in v2:
> - Add missing "net" prefix. Sorry about the noise
> - Link to v1: https://lore.kernel.org/r/20241209-mcf8390_has_ioport-v1-1-f263d573e243@linux.ibm.com
See Arnd's answer[0] to v1 for why this patch may be fixing the compile
error but the code may already be broken independently.
[0]
https://lore.kernel.org/all/3ca55478-a5a9-442b-ae4f-a0a822f786d9@app.fastmail.com/
prev parent reply other threads:[~2024-12-09 17:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 11:26 Niklas Schnelle
2024-12-09 17:12 ` Niklas Schnelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd1fb2205d974ee320ddb648c0589940e8646a6c.camel@linux.ibm.com \
--to=schnelle@linux.ibm.com \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®