From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 586A23EC2E1 for ; Tue, 31 Mar 2026 21:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774993956; cv=none; b=ZEn7I5wQUR9nhXeOOKyUC9leXYxM+7vIZyLwWCKvXzwNAXabQia+CaXioFJfO2GMbtojIosRkMStY4AaWZtiC6tOU5gEw+slGUVXXXX9DGX3H+n+NAhvaUHuF46enOMYBQxwf889fYUj4SlYDMeN4m97g4to3KePESqmbnvGvrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774993956; c=relaxed/simple; bh=QcIiO2S2cP3X0u81SLXxDNHm9VFTbljHwH99aAux3Zg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qSHPlwEi6JaP9fJ4zlmO1MjvTNQfdlb546d+4rn3C1I7NduSp1sdo8bqAB8S7arnFJJsRwSVQcvR0+4C60Gmr5BE5VEWOcwp7LP09JSHpavHIpqP7KhDoow3KCrmRrEc8CO/e/sQ4EbszmreWa2d/QYq/4VpOoW8fjlp/1hM3Pc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JvbXmziQ; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JvbXmziQ" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-4138136f02eso4036699fac.2 for ; Tue, 31 Mar 2026 14:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1774993954; x=1775598754; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EKq8H2JGsP7bFZjiH5OJgOchLeIYAjNY+kxkSl5F2HQ=; b=JvbXmziQC7TolDpMbPyFpqCGlCzk87t0l1KlvxkiFF4lHuj0UfidsvlhL/hhnwVzYN CHkMVGL1U3bMaCP9WwtDcgrIQ74W6IZFjqTDvGL6ZldD2fmtRQqFeSPa/HtsBb26+xsN OagGXcrvWRxPRYJTs+KCK8UN3k7mArIjUALzY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774993954; x=1775598754; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EKq8H2JGsP7bFZjiH5OJgOchLeIYAjNY+kxkSl5F2HQ=; b=hSRydeQTmoM1cC9VYMjKsO0UDOftPJYu+6AMuou19k/dHb7IWFsZcp2Ab/SIbBQxau 6fweZxV5faQOABxZ/xni9a6B8+XRcZcYNbd3WxcjXDKWGt6ngw4sGSSAXTi1ppGRsuMO sjCKrFD7V4n+qQRqI4ccdA3tqkYRvZqFZNZfOzIVXwLEiErD/AAWeGr7NKVpkD8qXTcE P5aGOp3Fmue88zkMAJP5kAZjq4Zz9FGQwDeOBr3GIHm4dfneMcEDVPd7V8TJQM1Ht/Vf Ax66RP/1rwAzi6Aa8tkzWQkw15Nmqe1SVyezBsKkjkIi7WuNxxl+5RqGsla/NgjbhGBR rivw== X-Forwarded-Encrypted: i=1; AJvYcCXH5+vjuT6HE3YtZqXDCI93ZNnT3g4mPhQ83JzBDOPU1M6yRiyRwCUzDZKD1wGQaoeNnVFbGMd6Orychv0=@vger.kernel.org X-Gm-Message-State: AOJu0YztLQf820WIwdD0Xtj+E1hiPnx6Vo6rUmFiFNOqYqtas0X5aR3T dNCDYo0tjc/N9HTwai3oRvo3uibkJqW1rthXRaL+npQNZtnvu5dPFHVSvyio8N25z1I= X-Gm-Gg: ATEYQzyPgEL2DNlvxtTiU/TT0iY6acF2A8Kqt8QhNeYkKhR7+VXvWuQZ/U9OrS/Qlxt utbn79/Bov3SZikyHcOfjUUvb489TFMpzzHuHfI1ge8K1y9BwmkdLDKmVNLtPUTdAyrHf3omdxL GIDMztPCekd/f5xnhkEMg9WzoSQKpKdECNAcuPmWzcC1iBzIdjicfzzlYARzAhM1+IG3z0ayJMT v3iSyqIsQfE7FBgGpEtX4its+WXi46Df0pli6spe/CsAeqKMhkT0BndtPT9ffTRdBqKV4PRaVTL zLzEikVAGLcdolLi9aiT04ukZDMDsgu1hHy7ivXtVOVzMm14Jg+aXva3xM7NOaK28AjkzBJNyfz xzu2CG3yhaBNpjQWnjWfSUhaxQx+yc2Rqv15rkrMpAh8UKApVR4JrrJH1hTPN5WS4v1gw87lcwO vtv4rSvtfAugBFOU9nlWdbCpa3USyBgU7lJj+vwu39n+Hwmg== X-Received: by 2002:a05:6870:200b:b0:409:a4d3:a30e with SMTP id 586e51a60fabf-422cfbf5808mr880410fac.2.1774993954054; Tue, 31 Mar 2026 14:52:34 -0700 (PDT) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-41d04d79c35sm8117986fac.18.2026.03.31.14.52.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 14:52:33 -0700 (PDT) Message-ID: Date: Tue, 31 Mar 2026 15:52:32 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] selftests/cpu-hotplug: Make the script complaint with sh shell To: Hubert Mazur , Shuah Khan , Jihed Chaibi Cc: Slawomir Rosek , Lukasz Majczak , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20260318080825.3063959-1-hmazur@google.com> <20260318080825.3063959-2-hmazur@google.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260318080825.3063959-2-hmazur@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/18/26 02:08, Hubert Mazur wrote: > The script uses by default the bash shell that is inaccessible in > the x86 embedded devices. This leads to the syntax errors. To mitigate some x86 embedded devices - which ones? > this, change the interpreter to /bin/sh and properly assign the > FUNCNAME variable for each of the functions as 'sh' doesn't set this > env. Change the conditional check for being a root from not > existent UID and replace with command execution "id -u". Please include errors in the change log > > Signed-off-by: Hubert Mazur > --- > tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > thanks, -- Shuah