From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A66C43466 for ; Sun, 20 Sep 2020 07:28:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A54F121741 for ; Sun, 20 Sep 2020 07:28:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726301AbgITH2m (ORCPT ); Sun, 20 Sep 2020 03:28:42 -0400 Received: from smtprelay0218.hostedemail.com ([216.40.44.218]:55180 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726216AbgITH2l (ORCPT ); Sun, 20 Sep 2020 03:28:41 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id ACE941DF5; Sun, 20 Sep 2020 07:28:40 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wave03_5c128222713a X-Filterd-Recvd-Size: 2238 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Sun, 20 Sep 2020 07:28:39 +0000 (UTC) Message-ID: Subject: Re: [PATCH] lib/scatterlist: Avoid a double memset From: Joe Perches To: Christophe JAILLET , akpm@linux-foundation.org, natechancellor@gmail.com, geert+renesas@glider.be Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Sun, 20 Sep 2020 00:28:38 -0700 In-Reply-To: <20200920071544.368841-1-christophe.jaillet@wanadoo.fr> References: <20200920071544.368841-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-09-20 at 09:15 +0200, Christophe JAILLET wrote: > 'sgl' is zeroed a few lines below in 'sg_init_table()'. There is no need to > clear it twice. > > Remove the redundant initialization. I didn't look very thoroughly, but there are at least a few more of these with kcalloc and kzalloc like block/bsg-lib.c- size_t sz = (sizeof(struct scatterlist) * req->nr_phys_segments); block/bsg-lib.c- block/bsg-lib.c- BUG_ON(!req->nr_phys_segments); block/bsg-lib.c- block/bsg-lib.c- buf->sg_list = kzalloc(sz, GFP_KERNEL); block/bsg-lib.c- if (!buf->sg_list) block/bsg-lib.c- return -ENOMEM; block/bsg-lib.c: sg_init_table(buf->sg_list, req->nr_phys_segments); --- drivers/target/target_core_rd.c- sg = kcalloc(sg_per_table + chain_entry, sizeof(*sg), drivers/target/target_core_rd.c- GFP_KERNEL); drivers/target/target_core_rd.c- if (!sg) drivers/target/target_core_rd.c- return -ENOMEM; drivers/target/target_core_rd.c- drivers/target/target_core_rd.c: sg_init_table(sg, sg_per_table + chain_entry); --- net/rds/rdma.c- sg = kcalloc(nents, sizeof(*sg), GFP_KERNEL); net/rds/rdma.c- if (!sg) { net/rds/rdma.c- ret = -ENOMEM; net/rds/rdma.c- goto out; net/rds/rdma.c- } net/rds/rdma.c- WARN_ON(!nents); net/rds/rdma.c: sg_init_table(sg, nents);