From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 716AC3EA96A for ; Thu, 24 Sep 2026 18:41:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790275277; cv=none; b=e8pBhCfSbZicEoueSOlbk2ckDZlOFRX06iBA2ZM8/9N6lvzXIyKLxMKYT7lyr68RKCGMh75/7m//nIecPRilxaB0PYs9nBFDdSe75xclFLFCl5FmIsQGYol844Oln2H56HUNQMf1Wg0MTRo/qBA7FlJVCvIIor47zZa79lLv4gM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790275277; c=relaxed/simple; bh=qfFDSW0M6GwOc1pzVZ9dR2y+xJOYtqD1VMTPO8FB+Oo=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aV3rA9EGL9jKCFfMnTBH70K06DmEKnNU6wBYVAn/j0I2HMoA2gDI1+OxB/TirfY2zNaMlz4bcx4WXWBAZrU4ZrO+K5Cr7lJp/usLUWJFbEFlhlDyfOgPPtuIR40tFkVzJ0FTN9rybQf5nva2znsLJwUdPw1FgzgxwL9ERiihm4A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256:X25519MLKEM768) (Exim 4.100) (envelope-from ) id 1x9oNa-000000007NM-1xEM; Thu, 24 Sep 2026 18:41:10 +0000 Date: Thu, 24 Sep 2026 19:41:07 +0100 From: Daniel Golle To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Allen Chen , Hermes Wu , Pin-yen Lin , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v7 08/14] drm/bridge: it6505: avoid division by zero in audio FS debug print Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: REG_AUDIO_INPUT_FREQ reads back 0 when no audio clock has been latched, and it6505_read() returns a negative errno on i2c failure. The debug print divides by the readback, and its arguments are evaluated even with debug output disabled. Only print when the value is usable as a divisor. Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") Signed-off-by: Daniel Golle --- v7: no changes v6: no changes v5: new patch --- drivers/gpu/drm/bridge/ite-it6505.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index 180a270ecfc1..0e7dbc119a05 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -1623,8 +1623,11 @@ static void it6505_enable_audio(struct it6505 *it6505) it6505_set_bits(it6505, REG_AUDIO_SRC_CTRL, AUDIO_FIFO_RESET, 0x00); it6505_set_bits(it6505, REG_RESET_CTRL, AUDIO_RESET, 0x00); regbe = it6505_read(it6505, REG_AUDIO_INPUT_FREQ); - DRM_DEV_DEBUG_DRIVER(dev, "regbe:0x%02x audio input fs: %d.%d kHz", - regbe, 6750 / regbe, (6750 % regbe) * 10 / regbe); + if (regbe > 0) + DRM_DEV_DEBUG_DRIVER(dev, + "regbe:0x%02x audio input fs: %d.%d kHz", + regbe, 6750 / regbe, + (6750 % regbe) * 10 / regbe); it6505_set_bits(it6505, REG_DATA_MUTE_CTRL, EN_AUD_MUTE, 0x00); } -- 2.55.0