From: Markus Elfring <Markus.Elfring@web.de>
To: "Leo L. Schwab" <ewhac@ewhac.org>, linux-input@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
Hans de Goede <hansg@kernel.org>, Jiri Kosina <jikos@kernel.org>,
Kate Hsuan <hpa@redhat.com>
Subject: Re: [PATCH v2] HID: lg-g15 - Add support for Logitech G13.
Date: Tue, 12 Aug 2025 13:51:03 +0200 [thread overview]
Message-ID: <cd294a60-1696-4ba0-8b25-ea259e8ccfb5@web.de> (raw)
In-Reply-To: <20250812065327.515098-2-ewhac@ewhac.org>
…
> +++ b/drivers/hid/hid-ids.h
…
> +static int lg_g13_event(struct lg_g15_data *g15, u8 const *data)
> +{
…
> +#ifdef CONFIG_LEDS_BRIGHTNESS_HW_CHANGED
…
> + if (hw_brightness_changed) {
> + led_classdev_notify_brightness_hw_changed(
> + &g15->leds[0].cdev,
> + TEST_BIT(rep->keybits, 23) ? LED_FULL : LED_OFF);
> + }
> +#endif
…
> +static void lg_g13_init_input_dev(struct hid_device *hdev,
> + struct input_dev *input, const char *name,
> + struct input_dev *input_js, const char *name_js)
> +{
…
> + for (int i = 0; i < ARRAY_SIZE(g13_keys_for_bits); ++i) {
> + if (g13_keys_for_bits[i]) {
> + input_set_capability(input, EV_KEY, g13_keys_for_bits[i]);
> + }
> + }
…
> + for (int i = 0; i < ARRAY_SIZE(g13_keys_for_bits_js); ++i) {
> + if (g13_keys_for_bits_js[i]) {
> + input_set_capability(input_js, EV_KEY, g13_keys_for_bits_js[i]);
> + }
> + }
…
May curly brackets be omitted at selected source code places?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.17-rc1#n197
Regards,
Markus
next prev parent reply other threads:[~2025-08-12 11:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 6:53 Leo L. Schwab
2025-08-12 11:24 ` Markus Elfring
2025-08-12 11:51 ` Markus Elfring [this message]
2025-08-12 12:55 ` Markus Elfring
2025-08-13 0:11 ` kernel test robot
2025-08-14 9:09 ` Kate Hsuan
2025-08-14 20:27 ` Leo L. Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd294a60-1696-4ba0-8b25-ea259e8ccfb5@web.de \
--to=markus.elfring@web.de \
--cc=bentiss@kernel.org \
--cc=ewhac@ewhac.org \
--cc=hansg@kernel.org \
--cc=hpa@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®