Re: [PATCH 09/12] rtc: ds1685: use sysfs_emit() instead of sprintf()

[Joshua Kinard <linux@kumba.dev>]

On 10/29/2026 09:23, alexandre.belloni@bootlin.com wrote:
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
> 
> Use sysfs_emit() instead of sprintf() in sysfs show callbacks
> (ds1685_rtc_sysfs_battery_show, ds1685_rtc_sysfs_auxbatt_show and
> ds1685_rtc_sysfs_serial_show) to conform to the recommended sysfs
> attribute formatting guidelines in
> Documentation/filesystems/sysfs.rst.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
>   drivers/rtc/rtc-ds1685.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
> index 284815e5f478..323fc9c17106 100644
> --- a/drivers/rtc/rtc-ds1685.c
> +++ b/drivers/rtc/rtc-ds1685.c
> @@ -988,8 +988,8 @@ ds1685_rtc_sysfs_battery_show(struct device *dev,
>   
>   	ctrld = rtc->read(rtc, RTC_CTRL_D);
>   
> -	return sprintf(buf, "%s\n",
> -			(ctrld & RTC_CTRL_D_VRT) ? "ok" : "not ok or N/A");
> +	return sysfs_emit(buf, "%s\n",
> +			  (ctrld & RTC_CTRL_D_VRT) ? "ok" : "not ok or N/A");
>   }
>   static DEVICE_ATTR(battery, S_IRUGO, ds1685_rtc_sysfs_battery_show, NULL);
>   
> @@ -1010,8 +1010,8 @@ ds1685_rtc_sysfs_auxbatt_show(struct device *dev,
>   	ctrl4a = rtc->read(rtc, RTC_EXT_CTRL_4A);
>   	ds1685_rtc_switch_to_bank0(rtc);
>   
> -	return sprintf(buf, "%s\n",
> -			(ctrl4a & RTC_CTRL_4A_VRT2) ? "ok" : "not ok or N/A");
> +	return sysfs_emit(buf, "%s\n",
> +			  (ctrl4a & RTC_CTRL_4A_VRT2) ? "ok" : "not ok or N/A");
>   }
>   static DEVICE_ATTR(auxbatt, S_IRUGO, ds1685_rtc_sysfs_auxbatt_show, NULL);
>   
> @@ -1032,7 +1032,7 @@ ds1685_rtc_sysfs_serial_show(struct device *dev,
>   	ds1685_rtc_get_ssn(rtc, ssn);
>   	ds1685_rtc_switch_to_bank0(rtc);
>   
> -	return sprintf(buf, "%8phC\n", ssn);
> +	return sysfs_emit(buf, "%8phC\n", ssn);
>   }
>   static DEVICE_ATTR(serial, S_IRUGO, ds1685_rtc_sysfs_serial_show, NULL);
>   

Acked-by: Joshua Kinard <linux@kumba.dev>