From: Dan Carpenter <dan.carpenter@linaro.org>
To: Hoorad Farrokh <hourrad.f@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] staging: rtl8723bs: remove unnecessary braces in while loop
Date: Tue, 23 Jan 2024 09:10:28 +0300 [thread overview]
Message-ID: <cd2fd58b-1017-4019-8810-c2421ddf02e0@moroto.mountain> (raw)
In-Reply-To: <delmvvkjuq2t76jrrxxb4a33tuef3m7bhkzpnopp5x7xzjdntb@ceybtr5piecl>
On Tue, Jan 23, 2024 at 12:28:44PM +1300, Hoorad Farrokh wrote:
> Hello,
> Thanks for your comment.
>
> >
> > This function doesn't do anything... The name says "free_all" but it
> > doesn't free anything. I would prefer to fix this warning by adding
> > a comment:
> >
>
> I didn't fully understand this part of your comment. Do you mean I should add a comment
> to the while loop + my changes and submit it agian? or
> do you mean I should find a way to free things in the while loop? then submit again?
>
Either one.
It's weird to note down the bugs in the source, but if we don't know how
to fix it, then perhaps that's the best we can do...
regards,
dan carpenter
prev parent reply other threads:[~2024-01-23 6:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 20:01 Hoorad Farrokh
2024-01-22 7:37 ` Dan Carpenter
2024-01-22 23:28 ` Hoorad Farrokh
2024-01-23 6:10 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd2fd58b-1017-4019-8810-c2421ddf02e0@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hourrad.f@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®