From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4E84C433F5 for ; Mon, 28 Mar 2022 07:36:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238864AbiC1HiF (ORCPT ); Mon, 28 Mar 2022 03:38:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238843AbiC1HiD (ORCPT ); Mon, 28 Mar 2022 03:38:03 -0400 Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 018F852E0D; Mon, 28 Mar 2022 00:36:22 -0700 (PDT) Received: from [192.168.0.3] (ip5f5aef5a.dynamic.kabel-deutschland.de [95.90.239.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 48F0061EA1927; Mon, 28 Mar 2022 09:36:21 +0200 (CEST) Message-ID: Date: Mon, 28 Mar 2022 09:36:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] drm/amdgpu: resolve s3 hang for r7340 Content-Language: en-US To: Zhenneng Li Cc: Alex Deucher , Andrey Grodzovsky , Jack Zhang , Lijo Lazar , Guchun Chen , David Airlie , Pan Xinhui , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Sumit Semwal , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Kevin Wang , Evan Quan , =?UTF-8?Q?Christian_K=c3=b6nig?= , linux-media@vger.kernel.org References: <20220328040536.4121797-1-lizhenneng@kylinos.cn> From: Paul Menzel In-Reply-To: <20220328040536.4121797-1-lizhenneng@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Zhenneng, Thank you for your patch. Am 28.03.22 um 06:05 schrieb Zhenneng Li: > This is a workaround for s3 hang for r7340(amdgpu). Is it hanging when resuming from S3? Maybe also use the line below for the commit message summary: drm/amdgpu: Add 1 ms delay to init handler to fix s3 resume hang Also, please add a space before the ( in “r7340(amdgpu)”. > When we test s3 with r7340 on arm64 platform, graphics card will hang up, > the error message are as follows: > Mar 4 01:14:11 greatwall-GW-XXXXXX-XXX kernel: [ 1.599374][ 7] [ T291] amdgpu 0000:02:00.0: fb0: amdgpudrmfb frame buffer device > Mar 4 01:14:11 greatwall-GW-XXXXXX-XXX kernel: [ 1.612869][ 7] [ T291] [drm:amdgpu_device_ip_late_init [amdgpu]] *ERROR* late_init of IP block failed -22 > Mar 4 01:14:11 greatwall-GW-XXXXXX-XXX kernel: [ 1.623392][ 7] [ T291] amdgpu 0000:02:00.0: amdgpu_device_ip_late_init failed > Mar 4 01:14:11 greatwall-GW-XXXXXX-XXX kernel: [ 1.630696][ 7] [ T291] amdgpu 0000:02:00.0: Fatal error during GPU init > Mar 4 01:14:11 greatwall-GW-XXXXXX-XXX kernel: [ 1.637477][ 7] [ T291] [drm] amdgpu: finishing device. The prefix in the beginning is not really needed. Only the stuff after `kernel: `. Maybe also add the output of `lspci -nn -s …` for that r7340 device. > Change-Id: I5048b3894c0ca9faf2f4847ddab61f9eb17b4823 Without the Gerrit instance this belongs to, the Change-Id is of no use in the public. > Signed-off-by: Zhenneng Li > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 3987ecb24ef4..1eced991b5b2 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -2903,6 +2903,8 @@ static void amdgpu_device_delayed_init_work_handler(struct work_struct *work) > container_of(work, struct amdgpu_device, delayed_init_work.work); > int r; > > + mdelay(1); > + Wow, I wonder how long it took you to find that workaround. > r = amdgpu_ib_ring_tests(adev); > if (r) > DRM_ERROR("ib ring test failed (%d).\n", r); Kind regards, Paul