From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A618BC7EE2C for ; Tue, 30 May 2023 14:40:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232392AbjE3Ok3 (ORCPT ); Tue, 30 May 2023 10:40:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230351AbjE3OkZ (ORCPT ); Tue, 30 May 2023 10:40:25 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18DD7C5 for ; Tue, 30 May 2023 07:40:23 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5148e4a2f17so6854333a12.1 for ; Tue, 30 May 2023 07:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685457621; x=1688049621; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Xe6HK9Kb35n4rfCfNWtBuecD+uDUu7lqn2KbidhEueY=; b=Plsb8fika+/zh+L/6FO0YtwBdpqBVezJiZNWFl1VRMvGSMEhCLKcxWhOraKns36TDF uqdpMfUTfAhBc2/OkGK3xDCAmrng9gbAF9Z7hmf8ywWHpeBSoNUfCuFHIHkFfYhNFY96 ABDuCIcXn8HEA/RE6fhbKDjbQ8nMbpvdiA3CqiK8g+MUEm+JgasKDXesrpPNrUftMAI/ dARy6NLOm2X2M/OywmrqVCytL4CNoOk2hJAUZ+bjveYeC/zmXcmSU72Jtk6nZ9eeVUlF EnXr6CimLZR8/UXu+JKsudTXoQhrmE9IA7sxOad2ae2PP3I9d1nqxJc7juXUhwEPUd6V sGSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685457621; x=1688049621; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xe6HK9Kb35n4rfCfNWtBuecD+uDUu7lqn2KbidhEueY=; b=LfexA1JR74Jcb5aymuRZ7WGgS4OGM8DKYfsD9rMYRJo9KlX5qiYrCFIayQVmli6LFi jEvPZT1Wx7TsOLsWpY2hlxf6ReMo52aYGgNr8Ugo0pxyrRpT7IvwcRmy4twHbd2xcHpe hyd4grjIAcm93mDydRTFVoYQ0/tXrS0WOn8z92KavLBqdTz2Rorkl7T6i0h7O2QduT+G bwRT4c11gWuVwrKHUzlw1NCsxvV822jOnmkDPMgMvqRvIyTzNwVlm3qa4o5MD6ERrtKm NzVd86eY/Meprkg47b07Zx0cyKU7edYOsvsX5AWbB+hqzJ2rZYE0W1/KLINQWJHKbzT/ 1NfQ== X-Gm-Message-State: AC+VfDy7i7CEVBasdQm3n9cv0dxAMj2vUNPY12dCqYtfqZO7TUg5KbBL YyR/VGSYJOTm+HNd9jCOB3CJqA== X-Google-Smtp-Source: ACHHUZ5Ta7S9kKaVrAx84G6ObMgsg+WsFPS9nY9M8aUCa8bxlB3xzf4hXlb1WcyJ4QEO+vwXrQsD+w== X-Received: by 2002:a17:907:7d90:b0:94a:8291:a1e3 with SMTP id oz16-20020a1709077d9000b0094a8291a1e3mr2573651ejc.74.1685457621030; Tue, 30 May 2023 07:40:21 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id d7-20020a170906c20700b0096f55247570sm7412780ejz.0.2023.05.30.07.40.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 07:40:20 -0700 (PDT) Message-ID: Date: Tue, 30 May 2023 16:40:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 6/6] ASoC: dt-bindings: Add tas2781 amplifier Content-Language: en-US To: Shenghao Ding <13916275206@139.com>, broonie@kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com Cc: kevin-lu@ti.com, shenghao-ding@ti.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, x1077012@ti.com, peeyush@ti.com, navada@ti.com, gentuser@gmail.com, Ryan_Chu@wistron.com, Sam_Wu@wistron.com, tiwai@suse.de References: <20230527223632.11781-1-13916275206@139.com> From: Krzysztof Kozlowski In-Reply-To: <20230527223632.11781-1-13916275206@139.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/05/2023 00:36, Shenghao Ding wrote: > Create tas2781.yaml for tas2781 driver. > > Signed-off-by: Shenghao Ding <13916275206@139.com> > > --- > Changes in v4: > - remove '\t' in the file Keep the rest of the changelog. > Changes to be committed: > new file: Documentation/devicetree/bindings/sound/ti,tas2781.yaml This is useless, drop. Your mail threading is still broken. This breaks usage with b4, so I cannot easily make diffs or apply it easily (e.g. via any message ID). I already mentioned this and no improvements at v4. > --- > .../devicetree/bindings/sound/ti,tas2781.yaml | 88 +++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/ti,tas2781.yaml > > diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > new file mode 100644 > index 000000000000..b3dcd7b18f5d > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > @@ -0,0 +1,88 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 - 2023 Texas Instruments Incorporated > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/ti,tas2781.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments TAS2781 SmartAMP > + > +maintainers: > + - Shenghao Ding > + > +description: > + The TAS2781 is a mono, digital input Class-D audio amplifier > + optimized for efficiently driving high peak power into small > + loudspeakers. Integrated an on-chip DSP supports Texas Instruments > + Smart Amp speaker protection algorithm. The integrated speaker > + voltage and current sense provides for real time > + monitoring of loudspeaker behavior. > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + '#address-cells': > + const: 1 > + '#size-cells': > + const: 0 Put compatible first. What's more I don't understand why added it. Your changelog does not explain it - you wrote there is only one change, fix of tab. > + > + compatible: > + enum: > + - ti,tas2781 > + > + reg: > + description: > + I2C address, in multiple tas2781s case, all the i2c address > + aggreate as one Audio Device to support multiple audio slots. > + maxItems: 4 > + items: > + minimum: 0x38 > + maximum: 0x3f > + > + reset-gpios: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + ti,broadcast-addr: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Generic I2C address for all the tas2781 devices in > + purpose of I2C broadcast during the multi-device > + writes, useless in mono case or remove this item to > + disable broadcast mode. > + > + '#sound-dai-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + /* example with quad support, such as tablet or pad device */ > + #address-cells = <1>; > + #size-cells = <0>; > + quad: codec@38 { > + compatible = "ti,tas2781"; > + reg = < 0x38 /* Audio slot 0 */ > + 0x3a /* Audio slot 1 */ > + 0x39 /* Audio slot 2 */ > + 0x3b /* Audio slot 3 */ These should be four items, right? <0x38>, <0x3a> etc. Drop spaces around <>, that's not DTS syntax. > + >; > + #sound-dai-cells = <1>; > + reset-gpios = < &gpio1 10 GPIO_ACTIVE_HIGH >; Drop redundant white space. Best regards, Krzysztof