From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9B9F1DC9B1 for ; Tue, 8 Jul 2025 17:05:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751994357; cv=none; b=LJrKppdox1RExjljO1zwgrYL4CiATs5h9+pCzYKlFdsa7FKhKXA8ZEyz9u/GlVzLToUAie7A8nQXjcya8n/iEQk/5QuaCG6txqruQtcCbzYxsSLO/IwbaSdZapRItpAzydA74PEYgphovg2866dNdBUUsT4poxowG3EZDaxO57A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751994357; c=relaxed/simple; bh=JkkoRasbjut5jeEzMBbaFs/deflEAfLkvWph7zunias=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CIRVr69xWl3KCdv2C8ZfVS6p7PA1trTprtUwcMLM+UVyfMtD4QmBpK8f5kLpziYK7CpfhFY8ccGb7ynFwcXrBWk7KiHX5rv74QD+qqZUvF/wIY35bYY25XJz6o3Wm6o0mLsJcUoIoWq/X6/hhy5mEfTJpVH6Rb9CjqkGKdsym2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Elv9pl0o; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Elv9pl0o" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 568Ebf1g006230 for ; Tue, 8 Jul 2025 17:05:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jO475jfbdZtuUnAEEFejjl9IeIhw70hd63tcQP0evVc=; b=Elv9pl0o+5MZFAaR LAVj+oBZl/wr4/pN4jBlBNCmyWyV4dXEj4GbqpPXQ0DpXNR4JB/2NayF4qwXjZyj AoAbzxEbSK4TnNPCwDrDYc8ZciHU294JmiV+wQTNqDve5Scc/WOJkq6akMzqUrWp FaO5lkfSc3ubII7n8tLipOuf7h9n61BnGN+JIR6s3833dDbMMr/AmsPv4TQ5ypiE thOYe8ZI8bUYTpqX/yRnOJ0DSPKJxKLlIPnbQef35YHjQfHlVT0rhXNgxGeB2B2J jVOk8XvXnMQ41+UYieWCFF4K41r37iWcbJa7Z75kGKyH3SxK4V8uL8B8ZpTfhges HQbTHA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47pu2b8csb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 08 Jul 2025 17:05:54 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7d0979c176eso47364785a.1 for ; Tue, 08 Jul 2025 10:05:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751994354; x=1752599154; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jO475jfbdZtuUnAEEFejjl9IeIhw70hd63tcQP0evVc=; b=G6B2gu+1r1Roq0GhdcnDFIQEswR2hPu1QlhN0QbRO0FqtHazpxSnfkOu9TPU2zsJOc 05D87ipPUlU/IsNxBZ8karjirZoBu+47GFRcmo0pO8V6UZgGKy4Uq+e2WpvenVwFKDT2 lzrQDHM4Z5Wmx/pKvYbwJmxrADygfEGrB9sCLgv3TN7VQimU7S7Mu9arbtaAQvSOhoHS n9WrNRQXb4IHabN3bGbGYGQVarPyaZexkJko5mC1kQj3w7W0Zjr+eH9e3zgieOj+WRrE KKE9/PeBy/eT7E2CSZFKl9V9a3Wtf5bWCW67YIdpf3jb4XwqBn5xlKZ+HLMkmT5NIXhq sU/w== X-Forwarded-Encrypted: i=1; AJvYcCX3v0Qd2EtBnYrY5OzijoeAiD9L285qdnXePQ1FOyhluTgncCLU4uc71YSYA1j6ON/zbLdiBZf3fsdOtRE=@vger.kernel.org X-Gm-Message-State: AOJu0YynUGtiCpaoWU3UHsjFXkOB5dCtYNsRzyw88hiQWarEld3z51WF pD1ZIDNq82ibNA5eyR9xjB3YDT8XcIxRDh3zjpC/P4SkOjVS/ZpTCGFo43Fb6+CCHiyzrIu6iDJ M3/QC29mMvNy/aXNTBlQvTUq4BwMlJApm0caZ5aTmkVUJKNY1g2wqYuEE0HewoMdHgNg= X-Gm-Gg: ASbGncs/4D3Fjh93VloosEsSdXArfCZa1ML2lUfZCbUA9OW9hrGawNbnyDfo6Pr+zXo /WdKE/TRqRtPxxQ/glqsecaWRTWhdzQZPFXjtT7PYKVfU6KsBeQOW8t19YEOCc8KvFSoO5sGZgJ sUJ4+pruILRV6M0FGSqtpexgVKgDUaYO2g6WBHyH6MgfCdro8enhNeRqBW5a/BgzGHWn83P6t3N feVDkmUxbGaa8Mq2taMUarVhtSX2u1tpCFej2YCr5/EsHY8aeY5wjiKzVKGzYoL3rj8NevhS0SU DLNHRBuu3rmf5TBThvCIavxvp1qobkUVKpeaQRiA1s3oPIdsjEDpPbdIE6iM5PjVJtk2IaKVEDB qsoU= X-Received: by 2002:a05:620a:4620:b0:7c3:e399:328f with SMTP id af79cd13be357-7d5ddc6a375mr819210185a.11.1751994353672; Tue, 08 Jul 2025 10:05:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBQAgQK/OIkLhExQIO7Vx5N12WVddGC+qRYQISOisMxT+bNVcjk5L/dx/BL3EDDSLrEuk+UA== X-Received: by 2002:a05:620a:4620:b0:7c3:e399:328f with SMTP id af79cd13be357-7d5ddc6a375mr819206885a.11.1751994352952; Tue, 08 Jul 2025 10:05:52 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60fca69657fsm7480922a12.26.2025.07.08.10.05.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jul 2025 10:05:51 -0700 (PDT) Message-ID: Date: Tue, 8 Jul 2025 19:05:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] clk: qcom: gcc-x1e80100: Add missing video resets To: Stephan Gerhold , Bjorn Andersson Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Jagadeesh Kona , Konrad Dybcio , Abel Vesa , Johan Hovold , Bryan O'Donoghue , Stefan Schmidt , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250701-x1e-videocc-v1-0-785d393be502@linaro.org> <20250701-x1e-videocc-v1-5-785d393be502@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250701-x1e-videocc-v1-5-785d393be502@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA4MDE0NSBTYWx0ZWRfX56jn9jG/1TRo PownpwYF4aN2if+2Y8VXmDF3j222uSS66QKGO0uVORwiDTEX7ZWEeqR0qiqP/B0DxzW7oDEpP4O /W+CXCFU/lFl7FmRxZoSYb6Z4uDyweoVmYIzz3GG2uYEfeoi10JMqF3iaqMSMKTcRkn1vS7PsvD 6zQztIxK7sWZAGRwKSUZYkg93FsZFYb0rBV5kRDUPVhDiorKOcXS5/AKd40emwybHChLb8yzIkW sVrWFi0f3Q79mInLvKKx8s4Y830zPWQYwZTOEqyyMUXARdRULN0NWr+38aTUJNXBBU0kPBB4SgM 5+qZhSmWhhgMLexNwTb8KT8cCjhsfGI7CbwLYEowRUsX/VAud+6NnkD14zeyoYPeI92+0TYGe9J orQiTMibk6OVzX/FFgo4Pp4VLPKyJNUDuG1PtYwvRH65StuMUPOBdsObgN1xvnFREARf9NmR X-Proofpoint-ORIG-GUID: 09C37NYBW07Z1W3qjfZsoopVDIePjlhd X-Proofpoint-GUID: 09C37NYBW07Z1W3qjfZsoopVDIePjlhd X-Authority-Analysis: v=2.4 cv=erTfzppX c=1 sm=1 tr=0 ts=686d4ff2 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=tov9PLxJY7Hhyj_3EZwA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-08_04,2025-07-07_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 mlxlogscore=999 bulkscore=0 adultscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507080145 On 7/1/25 7:28 PM, Stephan Gerhold wrote: > Add the missing video resets that are needed for the iris video codec. > Adapted from gcc-sm8550.c (with adjusted addresses). I don't think they changed > > Signed-off-by: Stephan Gerhold > --- > drivers/clk/qcom/gcc-x1e80100.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/qcom/gcc-x1e80100.c b/drivers/clk/qcom/gcc-x1e80100.c > index 3e44757e25d3245e455918e9474c978c8dacaa5e..301fc9fc32d8e6e1ddf59c1d3350d84f6c06e4b6 100644 > --- a/drivers/clk/qcom/gcc-x1e80100.c > +++ b/drivers/clk/qcom/gcc-x1e80100.c > @@ -6674,6 +6674,8 @@ static const struct qcom_reset_map gcc_x1e80100_resets[] = { > [GCC_USB_1_PHY_BCR] = { 0x2a020 }, > [GCC_USB_2_PHY_BCR] = { 0xa3020 }, > [GCC_VIDEO_BCR] = { 0x32000 }, > + [GCC_VIDEO_AXI0_CLK_ARES] = { .reg = 0x32018, .bit = 2, .udelay = 1000 }, > + [GCC_VIDEO_AXI1_CLK_ARES] = { .reg = 0x32024, .bit = 2, .udelay = 1000 }, Hm, so this is actually gcc_video_axi0_clk (same reg), but the bit indeed is described to pass on a reset signal to the hw block on the other side Reviewed-by: Konrad Dybcio Konrad