From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04CC742B75B for ; Tue, 20 Jan 2026 12:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768913538; cv=none; b=rtihf0otM5LkUhYd/QokZMvDfaJDlfsvB8KMpv7iSEz5zjTu5x6Rlx9YWj/ngWfjnQ/XhA2LdmuX7rsu6i6MqIipY0cgc4u29Pl3nBpigGUDo5dxr3jqDY8ZA9kda1r/YvU/zK2pynNby7g5lomJcZephjJK5vR/971OpVLtfYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768913538; c=relaxed/simple; bh=qwRTDcexgqB8UO6ImlZARduSMCBdN3aQSsAG3RPO/qI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lNyuINBNrBli0IYGG5Jbmn0K2q5ZFMOza4gGwjJ44DTaBxNCQGbHZDwUhVnikFSDlPLaaMuLoSYfPmfU+cwmWcyIrL7G3H6Qwlc/hB54A5z2ecZzWIOuCGWtRfu7iBH7j55y9zcpA/Oq73XO0t5JZXrJfpRTzchJC/P55Vd5NU4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YqL0zhuF; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YqL0zhuF" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-47ee2ea598bso2220385e9.2 for ; Tue, 20 Jan 2026 04:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768913535; x=1769518335; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hohucwzV8N+oNhlDNJ0PPwzKcIESBcXAG4tNEyAv2Lc=; b=YqL0zhuF2uJZZgUy3/UvpIEkp8/CM7WhpfH7rNlFaKLzczlRpfhxsCI66ngAhcpyJg 12yuJAmCjmuzJIQGIZ5cV+6v4zlbOJy1ve8lrVNd5AbgTug7FPM5GkSdvVm+oQtdmPcq IwIqInMDB1vdans4Hm6qDnk0cq2qzwo5gbltYgxYeZn+qDUGA5LAVOz4qd8jAiAxKwH1 SqgAVKmbBKgmu45/d1b46PuPTY7eIabm9z9isps1qEk4XDRzSsDor9Isl6HMuvWZ73Iv dQvGTLZlSbwJcaim3TNNMHn8YtgxmzaDnkeqErDozLm0AEZFKy4cExxTsbpWh5Z1AmHa d0qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768913535; x=1769518335; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hohucwzV8N+oNhlDNJ0PPwzKcIESBcXAG4tNEyAv2Lc=; b=eIfOOaIhFYWIiSXRZMKpllqy36SpREYu+/zR0qoSGJcmY9e+NE5W8NKdYvsRONgKrm An5W0c+Zto8RgodzENmwRYEFLa6SrlbjNDPMy1pS/SLeyf7Pnq68MWFGvb+lh6so3ICN oUGXbCvt7D+AWbUr7j6g7fSuj5wgFfp1DvE8lsSkY4VG0vGkGSWL4z1RoN09CNpnmDqb rSrLpA8p+ls6avYjcCo9WPYwLrEwSceMm50mJdOA66VUuOxYkzPEvaBH6P1tOz4oAaV8 S77ZSDQ79QGP8VTkDgxQ6tp/ia1IbDOoc2e6WJUgCNQMapJYFtO+0Z9NGsMn13yDC2jd GgSw== X-Forwarded-Encrypted: i=1; AJvYcCUJvkAwxBVETK6lLKoT18PT1ynft3lNx2v7ZLBvoKVo8Jc0N0NiGaDxjVcN9Kv1a3JEr4hbvoD2+W8+lUM=@vger.kernel.org X-Gm-Message-State: AOJu0YwnjnPqH7BbvAsJz1eBjeNnF9+fe0rbFmPcbny8/3ANxq/I8JJ7 AfsqkHTIG1y9ORSoS+2222MG/fgAP4I90jHy8rp2GNLlGPDCEHIcz1WO X-Gm-Gg: AY/fxX6cCbbdYh1ix0a3HDDvNXL2potF60Vw6foI9P2+lH2pPBt4Bdy2XJPvgj2S62k bNPByOEJ7ebjAYDFMzVlcU1Cae5i+yyvh1/bVFxDjxMuB0KXSXZjp6CyW21W9RM3b6gIBVipWFn rueEP08LDLy31KvldHmHZET6jw1S2yBEpndZevQ1KExDtIN5yZjGL9KNRGdVSsFiztMm1sV2OBF MUdsFnzHXP/0CAdGzhA4xgGLfuoPR99fmjqhzEFNrRmo7vk2CGz9mcJY4aSXPhieVWd9Y2lRNna 9a3ES1jV+WchSaaYO11NuCLPbl1bRCXEPOInIECGwceSr0v+6vR9f5SlJQKz0NFhU2HslcdSRl2 RSv2cfDNUvolkFUYKncUcrF5eygMkTuvHQV+kRVWw7eU5yhqaqiLtaUInb8fX1FAs6yOXj1N42v hl1CNAvM99bUBg+tuvQp2OOvGM6NttJTCY+7Uw4LA= X-Received: by 2002:a05:600c:828f:b0:477:7b16:5f97 with SMTP id 5b1f17b1804b1-4801e2a2216mr110600595e9.0.1768913535151; Tue, 20 Jan 2026 04:52:15 -0800 (PST) Received: from [192.168.1.105] ([165.50.95.41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43595e0a705sm1088207f8f.14.2026.01.20.04.52.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jan 2026 04:52:14 -0800 (PST) Message-ID: Date: Tue, 20 Jan 2026 14:52:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] fs/hfs: fix s_fs_info leak on setup_bdev_super() failure To: Viacheslav Dubeyko , "brauner@kernel.org" Cc: "jack@suse.cz" , "khalid@kernel.org" , "frank.li@vivo.com" , "linux-fsdevel@vger.kernel.org" , "slava@dubeyko.com" , "david.hunter.linux@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-kernel-mentees@lists.linuxfoundation.org" , "viro@zeniv.linux.org.uk" , "skhan@linuxfoundation.org" , "syzbot+ad45f827c88778ff7df6@syzkaller.appspotmail.com" , "glaubitz@physik.fu-berlin.de" References: <20251119073845.18578-1-mehdi.benhadjkhelifa@gmail.com> <20251126-gebaggert-anpacken-d0d9fb10b9bc@brauner> <04d3810e-3d1b-4af2-a39b-0459cb466838@gmail.com> <56521c02f410d15a11076ebba1ce00e081951c3f.camel@ibm.com> <20251127-semmel-lastkraftwagen-9f2c7f6e16dd@brauner> <4bb136bae5c04bc07e75ddf108ada7e7480afacc.camel@ibm.com> <59b833d7-4a97-4703-86ef-c163d70b3836@gmail.com> <9061911554697106be2703189f02e5765f3df229.camel@ibm.com> <7d38a29d-9d81-42e0-99c1-b6a09afe61fd@gmail.com> <8a96ddbefd84ed0917afc13f91ee0f33ea2e0c10.camel@ibm.com> <4e65ea7b-79aa-4c36-a8ea-0ca84966d089@gmail.com> <4d545c3f-50cf-4ad4-8427-35f87398838e@gmail.com> <1bfac55095419b8c5d9dd73dbf9b8b94c74b264a.camel@ibm.com> Content-Language: en-US From: Mehdi Ben Hadj Khelifa In-Reply-To: <1bfac55095419b8c5d9dd73dbf9b8b94c74b264a.camel@ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/19/26 9:55 PM, Viacheslav Dubeyko wrote: > On Mon, 2026-01-19 at 22:34 +0100, Mehdi Ben Hadj Khelifa wrote: >> On 1/19/26 7:27 PM, Viacheslav Dubeyko wrote: >>> > > > >>> >> I have ran xfstests on both my desktop and laptop on the for-next branch >> for the repository that you have mentionned and I didn't have any crash >> or issue. Here is the test results(identical for both desktop and laptop): >> FSTYP -- hfsplus >> PLATFORM -- Linux/x86_64 bhk 6.19.0-rc1-00008-ged8889ca21b6 #1 SMP >> PREEMPT_DYNAMIC Mon Jan 19 20:53:58 CET 2026 >> MKFS_OPTIONS -- /dev/loop1 >> MOUNT_OPTIONS -- /dev/loop1 /mnt/scratch >> >> generic/001 2s ... 2s >> generic/002 1s ... 1s >> >> Failed 51 of 772 tests >> > > The 51 failed xfstests is expected situation. However, if you apply [1,2] on > xfstests code base, then you could have around 31 failed xfeststs for HFS+. > I have applied both patches and got the expected results on my desktop and laptop: Failed 31 of 772 tests I can confirm that indeed those patches fix 20 of the previously failed tests. > Thanks, > Slava. > Best Regards, Mehdi Ben hadj Khelifa >> Many tests were skipped of course. If you want full output I can send >> you that.But for now the issue seem to be resolved (for hfsplus at least >> I'm not sure about hfs since I still can't test it on my system). >> Thanks for your efforts slava. >> >> > > [1] > https://lore.kernel.org/linux-fsdevel/20260118180519.xdddwoke2tey6ogt@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com/ > [2] > https://lore.kernel.org/linux-fsdevel/20251231224937.uu67l76cytcd36ns@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com/