From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934454AbdIYJrk (ORCPT ); Mon, 25 Sep 2017 05:47:40 -0400 Received: from foss.arm.com ([217.140.101.70]:49476 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933057AbdIYJrj (ORCPT ); Mon, 25 Sep 2017 05:47:39 -0400 Subject: Re: [PATCH] iommu/io-pgtable-arm-v7s: Need dma-sync while there is no QUIRK_NO_DMA To: Yong Wu , Joerg Roedel Cc: Will Deacon , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org References: <1506331727-25018-1-git-send-email-yong.wu@mediatek.com> From: Robin Murphy Message-ID: Date: Mon, 25 Sep 2017 10:47:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1506331727-25018-1-git-send-email-yong.wu@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/09/17 10:28, Yong Wu wrote: > Fix the commit 81b3c2521844 ("iommu/io-pgtable: Introduce explicit > coherency"). If there is no IO_PGTABLE_QUIRK_NO_DMA, we should call > dma_sync_single_for_device for cache synchronization. Oops! Reviewed-by: Robin Murphy Thanks, Robin. > Signed-off-by: Yong Wu > --- > Rebased on v4.14-rc1. > --- > drivers/iommu/io-pgtable-arm-v7s.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/io-pgtable-arm-v7s.c b/drivers/iommu/io-pgtable-arm-v7s.c > index d665d0d..6961fc3 100644 > --- a/drivers/iommu/io-pgtable-arm-v7s.c > +++ b/drivers/iommu/io-pgtable-arm-v7s.c > @@ -245,7 +245,7 @@ static void __arm_v7s_free_table(void *table, int lvl, > static void __arm_v7s_pte_sync(arm_v7s_iopte *ptep, int num_entries, > struct io_pgtable_cfg *cfg) > { > - if (!(cfg->quirks & IO_PGTABLE_QUIRK_NO_DMA)) > + if (cfg->quirks & IO_PGTABLE_QUIRK_NO_DMA) > return; > > dma_sync_single_for_device(cfg->iommu_dev, __arm_v7s_dma_addr(ptep), >