From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7421E1ADC98; Mon, 21 Apr 2025 07:21:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745220086; cv=none; b=QG6+dwgXbaZjtNxuois/I7fHGGF+MlAU1IEjQJAPh0Cf8anKkPLkOl5ga2nOIrutr0X65gpnDl/ZLDEn9P46LWCyYVSjhD3rSYvy+oj00x77l9vjKvsc1ITsaXbE9JHyB8F7GcHWiCLq05/T4GyIw/0MIct8Aj4vZaiLd34OSws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745220086; c=relaxed/simple; bh=WTyiMCMZ6ijxrHuUViQAAvsvE09RVd9etBrf2x8xzig=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u85cI27PWyhratMQuI0JPHy0ZU4yz3tjnFl/d/l+O7Gbv007Pgcl7IXi6x38YSI+Xy5mxDpZR26Wwb8hFrGHKpK5LNVzaDgcKPIPBmowNffoUPcoMfRwEUHJm86HQIOjgEYnlu4qPEV4g6uql2CHNtgdFqIRMlQv1zaYzxbWvM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ghiti.fr; spf=pass smtp.mailfrom=ghiti.fr; arc=none smtp.client-ip=217.70.183.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ghiti.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ghiti.fr Received: by mail.gandi.net (Postfix) with ESMTPSA id 4C44444201; Mon, 21 Apr 2025 07:21:21 +0000 (UTC) Message-ID: Date: Mon, 21 Apr 2025 09:21:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] riscv: misaligned: use get_user() instead of __get_user() Content-Language: en-US To: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , "open list:DOCUMENTATION" , open list , "open list:RISC-V ARCHITECTURE" , "open list:KERNEL SELFTEST FRAMEWORK" Cc: Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Shuah Khan , Andrew Jones , Samuel Holland References: <20250414123543.1615478-1-cleger@rivosinc.com> <20250414123543.1615478-4-cleger@rivosinc.com> From: Alexandre Ghiti In-Reply-To: <20250414123543.1615478-4-cleger@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgedtvddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttddvjeenucfhrhhomheptehlvgigrghnughrvgcuifhhihhtihcuoegrlhgvgiesghhhihhtihdrfhhrqeenucggtffrrghtthgvrhhnpedtgeeuhffhveeujeetveevieekleekvdffudefleevgefgieekkefggefhtddtveenucfkphepvddttddumeekiedumeeffeekvdemvghfledtmedufhehjeemvgdutggumedukegutdemtgdtvdeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvddttddumeekiedumeeffeekvdemvghfledtmedufhehjeemvgdutggumedukegutdemtgdtvdekpdhhvghloheplgfkrfggieemvddttddumeekiedumeeffeekvdemvghfledtmedufhehjeemvgdutggumedukegutdemtgdtvdekngdpmhgrihhlfhhrohhmpegrlhgvgiesghhhihhtihdrfhhrpdhnsggprhgtphhtthhopeduvddprhgtphhtthhopegtlhgvghgvrhesrhhivhhoshhinhgtrdgtohhmpdhrtghpthhtoheplhhinhhugidqughotgesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrr dhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhrihhstghvsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdhrtghpthhtoheplhhinhhugidqkhhsvghlfhhtvghsthesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopegtohhrsggvtheslhifnhdrnhgvthdprhgtphhtthhopehprghulhdrfigrlhhmshhlvgihsehsihhfihhvvgdrtghomhdprhgtphhtthhopehprghlmhgvrhesuggrsggsvghlthdrtghomh X-GND-Sasl: alex@ghiti.fr On 14/04/2025 14:34, Clément Léger wrote: > Now that we can safely handle user memory accesses while in the > misaligned access handlers, use get_user() instead of __get_user() to > have user memory access checks. > > Signed-off-by: Clément Léger > --- > arch/riscv/kernel/traps_misaligned.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/kernel/traps_misaligned.c b/arch/riscv/kernel/traps_misaligned.c > index 4354c87c0376..97c674d7d34f 100644 > --- a/arch/riscv/kernel/traps_misaligned.c > +++ b/arch/riscv/kernel/traps_misaligned.c > @@ -268,7 +268,7 @@ static unsigned long get_f32_rs(unsigned long insn, u8 fp_reg_offset, > int __ret; \ > \ > if (user_mode(regs)) { \ > - __ret = __get_user(insn, (type __user *) insn_addr); \ > + __ret = get_user(insn, (type __user *) insn_addr); \ > } else { \ > insn = *(type *)insn_addr; \ > __ret = 0; \ Reviewed-by: Alexandre Ghiti Thanks, Alex