From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6F9A19F128 for ; Wed, 23 Oct 2024 12:58:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729688323; cv=none; b=CRbR7pFfgnb9DgRSatZ7BYt+QRbjLxAI9Q34vPDhv7H9tXdkBCOf4Sh238CIOTEexi58d/NbDpmxHxRz4OHNTjjGyW+oSMJstRNKKAcJwvACUXLEStKb3tUlr0SvqyG+SdZ7n4WFmF+XJ3i8j6bo7JFCrVorSp6sXKaIQ3RgbW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729688323; c=relaxed/simple; bh=jFFsV+7qXKcZbB1QpgWXBO43D1kMLy2XtiXCrHjAheM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aAjnp3cFAvwwWkJW9moLF8ikJW6E776uwerrqsRtuLZMPBpgtB6NHkTGeKaYDIgvujh0rbVsL4VLtrP+0gSxteIaUOB7NDrO8QlDt9WIzidla/8NCNvtRcTqUyF945oiXOiXOY7sZwInt2iwL0rdByoqiudi+sBRPBq7NK+oO7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DH6x5Zr3; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DH6x5Zr3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729688320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cmc0ZXr9HAxJy8JyfDlIHzfWmtCzYV/tdIH6aM6k9ag=; b=DH6x5Zr3EYuQHcruwMAs74iw1DEQ6Zq+sRl2dGaPG+sCq9WCTdSwLmZz7jnubjdNt1NuI2 rlEYN6ZF53ciFQ9VYMiFxQx2+V5Cfa9NuKMGm51P4wzV42SmOIOQc9DmbJcSeU7z75EZxa AVjAOCORyWOF6EgjlqC42AUDbup6L94= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-Melke-2HMPmmBVMigXrgog-1; Wed, 23 Oct 2024 08:58:38 -0400 X-MC-Unique: Melke-2HMPmmBVMigXrgog-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43154a0886bso48981015e9.0 for ; Wed, 23 Oct 2024 05:58:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729688318; x=1730293118; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cmc0ZXr9HAxJy8JyfDlIHzfWmtCzYV/tdIH6aM6k9ag=; b=TmlThFqWCxSqG+lhpPkQEfrfxkfgnwflPTxBJ6oJUgNyo8hOSy71yWLai6avOsx2Fe L4LboGb4D+cpTP72ugY+tGCmOXjCXHGGhkwoa2G/qFNDYC2KrNMHA5lJMaHConDTvzvT lH9rtepJ+kMYKNzhGBntMHCtOmYUEuytWjK5y2LxED6TCUniuqAX53n9kXlSaUYW56UF Iqps1TMyUfZwcaC9K8IMIkrE347D2WpntoF86WjJysH0IuoQrO3KBLd5eJPWU0Dsq7JE nmFPq4a8YINgfAO4hNP9b87CY2sj5cVRRD0S1mCw4zroh9SpukxDXPCoOZcImsdF6Wn/ X9Lg== X-Forwarded-Encrypted: i=1; AJvYcCXeDoRKAB4iKHaC3Nm8hfhUPwCovzNAchYVylTs8SIHV9Ygt3DQrnBc6Cnc9REeBEyW9G1EJrzDBt/v5TM=@vger.kernel.org X-Gm-Message-State: AOJu0YyesZpajRHRJ/1vFjAlzfsQlgI7ot/ZRjmYCmv2L+pjFGdU8w8Y ahel4xlEAxo6DpXUBH+7JkOKgeNsq8rvlhVr7pfUbAN0IOrOUPoEJ/WXgz4fU+KtEuXO0ulB3Fu iFxT7OtilCrh2pUr9vNC3VtOGfMiyYD5+nDEGYeYd+5RTNT0nAAgLPsSI6UYZ+Q== X-Received: by 2002:a05:600c:4e48:b0:426:6f27:379a with SMTP id 5b1f17b1804b1-4318421150amr22824665e9.13.1729688317715; Wed, 23 Oct 2024 05:58:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHRqhovKJglA+voaQrphSfrRMVD0g6zoIKMkSl73MqSyuppwrsC7R63Gw4JXp3527O9cedgiw== X-Received: by 2002:a05:600c:4e48:b0:426:6f27:379a with SMTP id 5b1f17b1804b1-4318421150amr22824475e9.13.1729688317286; Wed, 23 Oct 2024 05:58:37 -0700 (PDT) Received: from [192.168.10.3] ([151.95.144.54]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4317d03b8b4sm44004325e9.0.2024.10.23.05.58.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Oct 2024 05:58:36 -0700 (PDT) Message-ID: Date: Wed, 23 Oct 2024 14:58:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] KVM: Array access out of bounds To: Liu Jing , mpe@ellerman.id.au Cc: npiggin@gmail.com, christophe.leroy@csgroup.eu, naveen@kernel.org, maddy@linux.ibm.com, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241023120111.3973-1-liujing@cmss.chinamobile.com> From: Paolo Bonzini Content-Language: en-US Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20241023120111.3973-1-liujing@cmss.chinamobile.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/23/24 14:01, Liu Jing wrote: > In the kvmppc_mmu_book3s_64_xlate function, > r = be64_to_cpu(pteg[i+1]); i used is 16 after the last loop and adding 1 will cross the line. > > Signed-off-by: Liu Jing > > diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c > index 61290282fd9e..75d2b284c4b4 100644 > --- a/arch/powerpc/kvm/book3s_64_mmu.c > +++ b/arch/powerpc/kvm/book3s_64_mmu.c > @@ -284,11 +284,16 @@ static int kvmppc_mmu_book3s_64_xlate(struct kvm_vcpu *vcpu, gva_t eaddr, > second = true; > goto do_second; > } > + if (i < 14) { This should be i <= 14 (not "<"). And in fact, if you get here you must have found == true, and therefore i is indeed <= 14. The code right above is this: if (!found) { if (second) goto no_page_found; v_val |= HPTE_V_SECONDARY; second = true; goto do_second; } and "found = true" is set just before a break statement. Paolo > + r = be64_to_cpu(pteg[i+1]); > + pp = (r & HPTE_R_PP) | key; > + if (r & HPTE_R_PP0) > + pp |= 8; > + } else { > + dprintk("KVM: Index out of bounds!\n"); > + goto no_page_found; > + } > > - r = be64_to_cpu(pteg[i+1]); > - pp = (r & HPTE_R_PP) | key; > - if (r & HPTE_R_PP0) > - pp |= 8; > > gpte->eaddr = eaddr; > gpte->vpage = kvmppc_mmu_book3s_64_ea_to_vp(vcpu, eaddr, data);