From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88F021DA10B for ; Mon, 21 Jul 2025 14:37:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753108681; cv=none; b=Ja9P1rMcBFSk9uKHCNI+3RCXivx9tVw7sAGk55h5aiDdm2M5kqEDhRtArRc0d/s6WMuXi5mZDrf2XMVParkF7QaubErEHJdWo/PIMPtDhi82iwey4sbtXEcVMshZHzks7OAuyLBCo3Zv9RqVUTlewjqWoZh3vGFxZHG7i7DFMWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753108681; c=relaxed/simple; bh=IccSnGnUczyKc/44zvZoy4blD7YV7Ykzb64QaXHQ4Xk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CK7Lg+L1PbN4qoR0P6yTAl+Wu8kFqrYD3yw6z0Ewt0PTlN4ckV3i+roGsq/kKOn2IkOG7YZpb49kS+pfEExh8qqfVV+mq5jFVZbluJXoqnVNNlUUZS4bVHuH+/ChY5L5TNW4UY2v2XhVryyHN+TpBbnajQFXrVZTmX9Tcx/Vr+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu; spf=fail smtp.mailfrom=g.harvard.edu; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b=WBjYM/CT; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=g.harvard.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b="WBjYM/CT" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-7e33d36491dso632609085a.3 for ; Mon, 21 Jul 2025 07:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowland.harvard.edu; s=google; t=1753108678; x=1753713478; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C/9ylmxApnP7AxoWtezPRKBv6ZGPphJ0NlvJQQ3XOa8=; b=WBjYM/CTI2GGKfMkfQ9I7jjys3vA97NGCBt61ORWUqUp3owhlM3bpSVxb9+CGCFxBP BldHuTe5N3WREEsbGa2CMfcBMwElE1M9PB7WvUgWHq/rcnimXYQ79PSpQ9bCgJkdXi1U lqVMnaaYUwrYyVtEtN2ie9DRNDJMsFK+sjo55elnZSAMdX6qg7uEnpK2nZKF3Z+rI63f s6/DBkWzJjDf6l0UJ9/cw7QDzIaGElzSjFkjlFVt0+rsKxifdAniX3t2N/aIln7QkZ3/ kGQz4FpBNCVB+ZfhtHSr52aB2lx8yQkGufJeuoAyOrK4EomJujb+qafYsSrZFRXUmZ7Y tX6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753108678; x=1753713478; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C/9ylmxApnP7AxoWtezPRKBv6ZGPphJ0NlvJQQ3XOa8=; b=Dz4XOlzkXOgCUSE4MOsU/lUvYw3UvaM2edg5kis3ixoalkIUoGo1nFyRcYMDpYTEPq /XRuGaH1VpcZi3nsee5BEg9OH6apBRpUdlb9PL18IdgC8m59X0A67504nicaRLi0NvrD 8dCuT1l2v8BnNt7Z2NyNCvZNs8KJYsgE3utLAjuQvK5RAgyqU4E+rCifUHQ3Qt+MrJ2h KcTBBFlUlW/t+I+2LF6xE7RtrTZvlaErONlLNBFERQX9E5IA2IYqIDuqWYjMJbBNbQOJ 1oMXHWwYtu6ujclQlbAr2H9E7bW7fKA1/jMfXQ4rtwGbVoKMp9jBpZa3ja2f75omXQrg UWOg== X-Forwarded-Encrypted: i=1; AJvYcCX6sqwVuvtpG7RNez+kKma6CeMleoLQaCXSeWBDRKSFFiGZALnuS/o55VCRYIh17O3fFLgk6mym2IFY//8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw24g191upPlPFt3GwGxOvq7e1czmI4R2SNZwb6p+4KOSFVcUnk 0YA3p82UYM5O4DIb9H5mIfbUqSb27zbHm3uR3UwHSyjmrQMRYu500Wh/5TCC6gZ01w== X-Gm-Gg: ASbGnctkQU71rbI7a6wV9F2+d53F3K29N4WvrEppl5UZh8ljVmoOMBofLyFlHYDSGdU pSiDCiSCPfB0CgrepFyhLiayk5TM0DimlMCbXFbDxF0mbvwl38F9DrofY/W5mPiI+Lt0PGI0iA7 buL3OPyZCTTGBTx09BlmF12vI/uQCIYDaM6pLfWFqG0jjouRmSyKFlrOCqdW/DyCujCdYPMmkbi rxPf/X0BNnNAQoaVVjUS2IqX9Oq9kOu2Z9Ru7CKbRR2XpGvuFoD/rpw8hNkBL0eqH6FePIJT9wy vFe8Oc9IfUAjHkb0VnU1vQ9X7BguEZ5qfYl+Z9I7zcgjGO/DIRcR/Iou8IxblnuCTegRwt8PuEu e8s6G2pbIuiyWnV9tAG0BIR7zy9iIzlejeFLMofVd X-Google-Smtp-Source: AGHT+IFu9gQ4T/xGAbMTQXG3WPYgohMsmI9ueVB9rM2XMJClNzfOEU7Ji4LWWYs8o8fj+HmfjDCM5A== X-Received: by 2002:a05:620a:4443:b0:7e3:3996:f4a0 with SMTP id af79cd13be357-7e356b058dbmr1713007185a.43.1753108678345; Mon, 21 Jul 2025 07:37:58 -0700 (PDT) Received: from rowland.harvard.edu ([140.247.181.15]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e356c9015dsm419569485a.92.2025.07.21.07.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jul 2025 07:37:57 -0700 (PDT) Date: Mon, 21 Jul 2025 10:37:54 -0400 From: Alan Stern To: syzbot Cc: bentiss@kernel.org, jikos@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [input?] [usb?] UBSAN: shift-out-of-bounds in s32ton (2) Message-ID: References: <15723551-960b-4257-bfbd-073e136deaa2@rowland.harvard.edu> <68791b6f.a70a0220.693ce.004b.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68791b6f.a70a0220.693ce.004b.GAE@google.com> On Thu, Jul 17, 2025 at 08:49:03AM -0700, syzbot wrote: > Hello, > > syzbot has tested the proposed patch and the reproducer did not trigger any issue: > > Reported-by: syzbot+b63d677d63bcac06cf90@syzkaller.appspotmail.com > Tested-by: syzbot+b63d677d63bcac06cf90@syzkaller.appspotmail.com > > Tested on: > > commit: c2ca42f1 HID: core: do not bypass hid_hw_raw_request > git tree: git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git > console output: https://syzkaller.appspot.com/x/log.txt?x=148b258c580000 > kernel config: https://syzkaller.appspot.com/x/.config?x=ec692dfd475747ff > dashboard link: https://syzkaller.appspot.com/bug?extid=b63d677d63bcac06cf90 > compiler: Debian clang version 20.1.7 (++20250616065708+6146a88f6049-1~exp1~20250616065826.132), Debian LLD 20.1.7 > patch: https://syzkaller.appspot.com/x/patch.diff?x=14dd1382580000 > > Note: testing is done by a robot and is best-effort only. Let's try a different approach: hardening against invalid field attributes. As far as I can tell on a quick scan through the code, only one change is needed. Alan Stern #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git c2ca42f190b6 Index: usb-devel/drivers/hid/hid-core.c =================================================================== --- usb-devel.orig/drivers/hid/hid-core.c +++ usb-devel/drivers/hid/hid-core.c @@ -66,8 +66,12 @@ static s32 snto32(__u32 value, unsigned static u32 s32ton(__s32 value, unsigned int n) { - s32 a = value >> (n - 1); + s32 a; + if (!value || !n) + return 0; + + a = value >> (n - 1); if (a && a != -1) return value < 0 ? 1 << (n - 1) : (1 << (n - 1)) - 1; return value & ((1 << n) - 1);