From: Jon Hunter <jonathanh@nvidia.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Daniel Golle" <daniel@makrotopia.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Robert Marko" <robimarko@gmail.com>,
"Paweł Owoc" <frut3k7@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH net-next v3 2/2] net: phy: aquantia: allow forcing order of MDI pairs
Date: Fri, 11 Oct 2024 19:34:04 +0100 [thread overview]
Message-ID: <cd6d8dc3-5f26-4f2c-afd3-c881c1df3160@nvidia.com> (raw)
In-Reply-To: <795c9b87-ecd5-4fa5-82ae-b88069cbaafb@lunn.ch>
On 11/10/2024 19:12, Andrew Lunn wrote:
>> This change is breaking networking for one of our Tegra boards and on boot I
>> am seeing ...
>>
>> tegra-mgbe 6800000.ethernet eth0: Register MEM_TYPE_PAGE_POOL RxQ-0
>> tegra-mgbe 6800000.ethernet eth0: __stmmac_open: Cannot attach to PHY
>> (error: -22)
>>
>> The issue is that of_property_read_u32() does not return -ENOENT if the
>> property is missing, it actually returns -EINVAL. See the description of
>> of_property_read_variable_u32_array() which is called by
>> of_property_read_u32().
>>
>> Andrew, can we drop this change from -next until this is fixed?
>
> If it is as simple as s/ENOENT/EINVAL we should just fix it, rather
> than revert it.
That also works for me. And yes it is that simple.
Thanks
Jon
--
nvpublic
next prev parent reply other threads:[~2024-10-11 18:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 16:18 [PATCH net-next v3 1/2] dt-bindings: net: marvell,aquantia: add property to override MDI_CFG Daniel Golle
2024-10-04 16:18 ` [PATCH net-next v3 2/2] net: phy: aquantia: allow forcing order of MDI pairs Daniel Golle
2024-10-08 21:13 ` Andrew Lunn
2024-10-11 17:37 ` Jon Hunter
2024-10-11 17:40 ` Jon Hunter
2024-10-11 18:12 ` Andrew Lunn
2024-10-11 18:34 ` Jon Hunter [this message]
2024-10-05 18:46 ` [PATCH net-next v3 1/2] dt-bindings: net: marvell,aquantia: add property to override MDI_CFG Rob Herring (Arm)
2024-10-09 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd6d8dc3-5f26-4f2c-afd3-c881c1df3160@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=frut3k7@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®