From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BBFA19F12D for ; Mon, 25 May 2026 13:07:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779714468; cv=none; b=edPCD68VC4tESVWdfD9Z6cKxw73kwKqsvZ9MaL/wEaZCef8KyuTxIgx6Ejmc5LMb3aIjNzyadjNbR8V7jfG+/AAS1l9Ae+gNbqIM0/sn/Y9rGxI2jnH2NTyrxX6K1xWRbYbaF3CpD1ZpDcrx0/lIXe//qsa83KEq2bP4EsRAk7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779714468; c=relaxed/simple; bh=FGh9wbyR5wQdQfoGl5QdsfDgHApADG1vGkiBgzcWpaY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IMBy7ruR+fyRk55y3wctm/OUvbts0kh+vFOAqQW9KR8HTFYBs3F//hwzeyz2WwIxpL5beBiQlxvApQ/lGFNp+3fDnNYJLjl395kFZFxl7C8d7Sp5QC4+wZhvYDFJEvtrZXaWqBxcL7s5e209SxzT8Pj2qAHz6at/3/PNFBOW/WE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DC/D71z8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=X5QdKJqW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DC/D71z8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="X5QdKJqW" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64P9leRc1457776 for ; Mon, 25 May 2026 13:07:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RzRZmaAdBmhSzzrkfPycqssxyvsq883C0Kdc/KcJSts=; b=DC/D71z8QIuEE9yE J6LYQFcfF3WoXYg3CH72K09dPr7t/U7zFstNCqpQt14dmegsZnHEu4hAv91Xh351 XJSbG205ZLpjFhz/zhyafNeghE5kqLpi+jP+Bk41+se61hYajslr1K03Zamtwd0G f406Pi40hWQPsKkMdty4ikv7+8oOxLgnPLRd/0Ly8GqSiRNsV0vZEHedB/TAWJmU 4sJJdORNHuUvPj7xI8y5XUC7ipPukIo21wusbJr+y+Yc4hMNHKK2SI/CnOu+iap+ KDztTk0uOCS8pdUjcWBXME/J8edliqJQS/pOhuutirEqdePpFTL057yHEB7emDhj 4Getxw== Received: from mail-oa1-f69.google.com (mail-oa1-f69.google.com [209.85.160.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eb4f3epn8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 25 May 2026 13:07:46 +0000 (GMT) Received: by mail-oa1-f69.google.com with SMTP id 586e51a60fabf-43b49d2c95bso496371fac.0 for ; Mon, 25 May 2026 06:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779714466; x=1780319266; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RzRZmaAdBmhSzzrkfPycqssxyvsq883C0Kdc/KcJSts=; b=X5QdKJqWGMiVTAFfbqXhTgvwO8y92Ew7TTlRVY09I4PTXTk07/PRmhXbMkBMiIwpAI dK+78MktPzfXhrBMjabodXhCw5KO/ni4zYmdKkNj3o/9wzH1NbTNnIp1TzmT7RTv9bVp yybg1XZkrD15lHE6PMbmoMGG/1wWbwpZNRoQGPv5lvwudruEYfSaOcCuRrJNCUrdNyRP 8NHl57i/LjQ7WF6PF/xEtWwj2lipJFHZ6yLXRRCA+Dt1FP9LIbMvdo4Qg5fgn1RCmtIi tae3uuJfr1CoeE38jO8SX/S4SupMNzuu5XlxWKsCTS7MuCCGvfvqdCeakMpZXQQQnnzS TWGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779714466; x=1780319266; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RzRZmaAdBmhSzzrkfPycqssxyvsq883C0Kdc/KcJSts=; b=Zn/lWaWtYC3a5E/McvTXVUeyM7mspqbMn69iSLQa8tsTXIJpywCIHn3NTDQJ4SnHh5 Fx3wwWrQcswfJaroM+TmR+BcLBigUQSyjEe1Ax3GmVUuRBffRJH2ntEhGQZhIRrA6L5/ UMLOmYqzVlPK8pZlP4V1vSjdjEumvH8IlpNOGcW0qoRG1IdPBDlwaCxHkFpI/iQtwXR1 zmPwuhdGaLjTEMnuUKDGL+/IhL5yoYeXtVf5LR+tChBTqeJ8iXW4to/0VNSPnlPZ3CTz TyoefD3tcWwm3YcIvsGB389ILDImCsCL+8ZAk6rDOAT4AMRx6/Zsa/rI/NkwP7Drdb6a fZ/A== X-Forwarded-Encrypted: i=1; AFNElJ+Xom+exAlaG9Fb0efaR8UJzNO1qOTkorkCK9bj+zl6t8dqbcmV0o3TGF6Sw8U8jnoiZra6BgG3CBYCNHA=@vger.kernel.org X-Gm-Message-State: AOJu0YygqSkb6uG73VNhCzlzQjonLUU6Fs9cIqPgi1RVq7yy5OMe4gTo +a2uMQZQ8cKEe51QGAR8x0Q5dLMTbN4qJ73zxq4RqQ1sICyv5Y81onvfJT3KIiyiwYJFKQfIgbG A2JjjsmAVY9bGxgjoT9mgHB73uL+l6LLy/4i8BNMGB5BNCrRGLlAAkRfXiN4zjCheDIA= X-Gm-Gg: Acq92OGPvgsit8vG8flIUkiJMbxD4GvLbluKM+ntKtkCJBFS24kHZtlsdUlEEYXOclR C3kRI7ok7jiIxCfzpJBUZWdHPimCTbQxQ2vCAd4YL8+jEwU8f2i/5ScvwJxoIPGaiLuSrPufLD4 qb7EyB8SL9aaClcgVqvujIT/wq2iFxGHiNTTvuWK7oUgbE+M+OVeUFUwk/YI7HWZ8Ojn1KD1jK5 bhrtadkRg68CwSwDediDdqclqU114lLdhOdIrtF3tjnaGDHy25BXAhhfe7EknBn1dnOpKNwiHK9 eA3TEkP8CCTlT33wjPLaFVYXJ3iZYpz0gJ3f8l0mKo/x7OSrdJANjDHbNZ9KLIS0pwNTrcDZC88 3TlxbJ0zm4ZZhQ15Q/+PAD0xF4ccgUz13iTV0PO+mCgcj/g== X-Received: by 2002:a05:6820:5457:b0:69d:449a:2bed with SMTP id 006d021491bc7-69d7e854c29mr3518790eaf.0.1779714465641; Mon, 25 May 2026 06:07:45 -0700 (PDT) X-Received: by 2002:a05:6820:5457:b0:69d:449a:2bed with SMTP id 006d021491bc7-69d7e854c29mr3518774eaf.0.1779714465275; Mon, 25 May 2026 06:07:45 -0700 (PDT) Received: from [192.168.119.254] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc62d9520sm393075866b.50.2026.05.25.06.07.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 06:07:44 -0700 (PDT) Message-ID: Date: Mon, 25 May 2026 15:07:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM To: Ajay Kumar Nandam , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com References: <20260522073324.e18bb240b6f6@oss.qualcomm.com> <20260522130459.3411038-1-ajay.nandam@oss.qualcomm.com> <9e8c0351-0168-4d94-8610-cf2cc2f030f0@oss.qualcomm.com> <1e54db48-e618-4525-abf9-ee65d0a1b71d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <1e54db48-e618-4525-abf9-ee65d0a1b71d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 07CWtPJEy8oR12eqIK2LID9e-q29FOub X-Authority-Analysis: v=2.4 cv=WvYb99fv c=1 sm=1 tr=0 ts=6a1449a2 cx=c_pps a=zPxD6eHSjdtQ/OcAcrOFGw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EXL2SugY_77LC3pzBmYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=y8BKWJGFn5sdPF1Y92-H:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI1MDEzNSBTYWx0ZWRfX1BMLrZmBZxUs VNY0OgjARt3/tnrFF4AIGsIiS0qw1Bv0dFuPGDEtvAL8WBtfZzIjGkBDZsrsm/w4HPhg3Nm/I0V DQgfLI1a7w1j1uWd4kx0YTgkkHuOzeEOsLSqXXGaHzG/Z+CEygzyrGHHNcM8LCviyae1pm/jNv0 8V8q+M0fza9Df84+qbvyQwqtSGSqjK0Av4rYO9nNbIOmPfNuLXO9QwJjB3ZDmsWbOw5DYe73O+d +26RdVeFLGqsSPgPsts/efktVesxPrDOhaZ0SIT7LEhpeUwNTYycDKQlSiZYjtoVJP+IGjrclSo DZvT/QzPEmAAWHmRoqYRciwByDWU5VcvX95jDHh7Ric9OOJQ8Vc7JbKUm0StqBtQsTsu4YpzJyG IlqoABM8jNsYmrJBVks8x/r41q2f3g1acIs23PGKNoqGnQnAkljUxesNT0lLBaeABcxycvqyp8c 2oWMn3MIQlmXDJw2w6A== X-Proofpoint-GUID: 07CWtPJEy8oR12eqIK2LID9e-q29FOub X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-25_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 clxscore=1015 phishscore=0 adultscore=0 suspectscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605250135 On 5/22/26 9:26 PM, Ajay Kumar Nandam wrote: > > > On 5/22/2026 6:55 PM, Konrad Dybcio wrote: >> On 5/22/26 3:04 PM, Ajay Kumar Nandam wrote: >>> Convert the LPASS WSA macro codec driver to use the PM clock framework >>> for runtime power management. >>> >>> The driver now relies on pm_clk helpers and runtime PM instead of >>> manually enabling and disabling macro, dcodec, mclk, npl, and fsgen >>> clocks. Runtime suspend and resume handling is delegated to the PM >>> core via pm_clk_suspend() and pm_clk_resume(), while existing runtime >>> PM callbacks continue to manage regcache state. >>> >>> This ensures clocks are enabled only when the WSA macro is active, >>> improves power efficiency on LPASS platforms supporting LPI/island >>> modes, and aligns the driver with common ASoC runtime PM patterns used >>> across Qualcomm LPASS codec drivers. >>> >>> Keep the SWR gate runtime-PM reference from SWR clock enable until >>> disable so autosuspend does not gate clocks while SWR is prepared. >>> >>> Add a PM dependency for SND_SOC_LPASS_WSA_MACRO so PM clock helpers are >>> available when this driver is built. >>> >>> Suggested-by: Mark Brown >> >> You added this tag, but was the entire content of this patch sparked >> by Mark's suggestion? > > Apologies for not including the Reviewed-by tag earlier — that was an oversight on my end. I'm not sure we're on the same page. Please read: https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes Konrad