From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752434AbcICINj (ORCPT ); Sat, 3 Sep 2016 04:13:39 -0400 Received: from mail-bl2nam02on0064.outbound.protection.outlook.com ([104.47.38.64]:49902 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751127AbcICINe (ORCPT ); Sat, 3 Sep 2016 04:13:34 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm: amdgpu: add missing header dependencies To: Baoyou Xie , , , , , References: <1472882501-19515-1-git-send-email-baoyou.xie@linaro.org> CC: , , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Sat, 3 Sep 2016 10:13:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472882501-19515-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="iso-8859-15"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:852b:c1d5:2598:985f] X-ClientProxiedBy: AMSPR02CA0032.eurprd02.prod.outlook.com (10.242.225.160) To BN6PR12MB1298.namprd12.prod.outlook.com (10.168.227.148) X-MS-Office365-Filtering-Correlation-Id: 61f40465-d2a5-4f75-2d42-08d3d3d231b1 X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;2:oszqKBXPHhG1gK2SzcjvChFKkZQ7vaWJH9ySU85rx4h3hXLqkk611zNht6yJDQbRIpOrm8qoqsB0j2UH+U/8ikqWW0HeXy+tOEeUp/P7XXJzKZ5yg3O58HlgAieMQQgQR0gBZVJvyOgZXQIRffVOw+8CROW9tz1T2BducxotBTP8TAJAfjbXIzWvNrFFFy+M;3:GfJzLpoWetHfc+OdbNmqoNZ+/UX8lADhZATGN7jad79K2PNEEYIBpYf7/JRLT6hEsT0x6S7QRKtQi4XWo75VgNcigrJ751htyqW5BCCO/G2T8KsJPGwELqbE6akHeua/ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;25:VOLDymZcqcWDmLGFkPXGnmh/CFf3ut59F7sEgF6wqsQ5PJgRZHIFovcHEjQWw5byw9q+JYvdyFW96TEL610MAlxkDj9hulUxeToEz4ccyTurPDu4v2B/GgFzawZ5fgojXdbH7gMCRvc5Pj2Dn9GrY/w54KSDZ19uTG0F2WUZRrAZf+QK757M93o9Hmf1DlfvUHXN6viiNWKteeC4/wgiCsbWdNJDWI6rz1pjdhZ0gKbeQ735MRr+zKwdxPXuTrKv27+6RJuLFq5cCbEsFzUPcekwOT4eeeTJRf56ocBVQl1mRkwQRqV4Yj1v08n4nC9rC4hnaSWZz/4/xpYpDG35YiVvEzmd5tdDlPgjlV7x45xmwQDbWji8tePp1C+wwhsbj1elzfuG1ST7Aa5BTA5hixNuOwOJORZ14dIC3IgVUdlA9jQ1f9UsF5vz7FvDMfkPLTncgclM/PKNWmV+8nbfXK3GMfz8iOo4nVQLhnhqUbf7W+1pe/8ae66ZYfK/H3JZvqfOfvgvfzb2UeD61GBB4LtNmO1BDpYjSXNNpwKt8fX/DPXffTmVECjft6DGgx2gB+9DsBTD8cyc0GXhZjgoZmN352nEbQedTgFIE/3sye4MVOX3SwX+xjSaJk2kXWTzv/JTRDoso5INvFqvrJa0fklTmmX524bmwpuEi9zHsIwvzJoDflO387QmbpD2IE31nHHItfmJcZb8633UB+GulCx3BBX3bx8D8umh4uKXJxk= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;31:ztHrnrbyuPMzrlisZFgFP+sWeKCzJdib/FjLGRQoalje65Mnsv5+RG1eBv+/DbuGnyoU7LtfZYhcIbKj/9V+MoQINrvYPKimV9ISMB/CUag4KU+67zKtTXUQy727worLHJ+htn1zsHaqqw2NdePL14rZQeGuoqVyBfFIObIOEAminhk8xNfwh96E20BTqYmuqaqo7IEeL40WggkvvvqJcbG0IFMlzMtwsDLtK4davW8=;20:gEeriaS7PZXLwbtBNEVBD/t8PefIXRX3xKN7fKalS8l8REKrYzal+l/RJdc3pQaRclSNF/rI04aV7JyvDUtUDtlmry+nToNNq0uIa33h43au5vxNh+dPdYZR4mfBWSuJJqhR9lwjR43vCx3xsRA16xU5Vi/rc7CjtDtq4jBGl6I5n5zJF0d3D3j+4Ja7Yqv5kWKknspJI9K7NFYaODzj0tk8VdfYeyJ6ddC81YmltVCKavqlpAVhYWyUGkOwLxDvLalrzLSHcb6bOn/GjpdZ84SX0iTx0yKBREdIzHKmbKGtB++8myZp1v7JY3WzFrFsDTCEMHNgOn6Og/d9lA33H7JISDomBLyXpcqZrj27jTzAGfOKJxZoUGGUFJMJcO/yYUa6HJlYZYCqhE7FpXe6nQs/VEL0kg+wmFwK7DvAj64c/do9w11uAkjZEYNBBx7xXZPpcY3dQpQWVpqZX8kKMGXTiU26C+IGIN1Oa/xITUKDDlT7TJiZHFWUxbJZe2rZ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:BN6PR12MB1298;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;4:4BKcbnO4UXWeWVmsvBfle+i+s7MZ4Od60IyFqaKUA1ZYDsJpEDa+zNGUBHZbT7zdO2/z91omjGC6458R8e9bBF/KGAHkKnQStNaA3GZMDel4TNudg2oPkQpN1Ksv4EDX3OCCSu4Pc0AVm2363+jfgyJLrBGHrXsxOhjDGLz6wBgKNq+/E0dxV2LVklwUu/icHrAM5Cmsmo3YpO7jr7XHUFxHZRuYZ1OrTULPxAjSI196PkYSiwDD36r7fHPFiF0sLsctoASIWizHEmgJVZ7n7fcDzqepDz9PNBUpe9f/5gVs7VzMEh5R/4UkcZr61lsUEoYWifiSjF8aFko6BPywCkNT2JW/EiSFqAb2TgNby2WIrEjAAvqayqshVoyfDcKkIIoEV1D2XFm+mfjHc8vLFC/7V6a6IvFbCf3TNOQLMugsWNMwFd7REfH1qInxyV7T X-Forefront-PRVS: 00540983E2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(33646002)(31686004)(50986999)(31696002)(76176999)(65956001)(23756003)(65806001)(1706002)(8676002)(2950100001)(2201001)(83506001)(92566002)(54356999)(81156014)(305945005)(81166006)(7846002)(7736002)(64126003)(47776003)(77096005)(42186005)(5001770100001)(97736004)(36756003)(101416001)(5660300001)(2906002)(65826007)(4001350100001)(6116002)(189998001)(4326007)(586003)(19580395003)(86362001)(19580405001)(50466002)(105586002)(106356001)(2870700001)(68736007)(3826002)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1298;H:[IPv6:2a02:908:1251:7981:852b:c1d5:2598:985f];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;BN6PR12MB1298;23:MBGb5P10m3be+3jhv32NwiKW9EDxVHTGd9oB/3?= =?iso-8859-15?Q?Hw1zBGIMHZ0mCkiuixTxkmwkufDsElBpMGRM53xV3YK8MgRiGRKmc2x2T?= =?iso-8859-15?Q?Ba0bk+ufVGFlG9EsjFVuCE2iHiRQvkMkPbYQqJVr2Ffb2urjg1gKYwDUS?= =?iso-8859-15?Q?sUjMu+VRlZM1DQz+vvLadrT4+PWYgDsCzjUjx3KigS41r3nwUdYQndLtS?= =?iso-8859-15?Q?kBfgNUJVNWd8oujf84g6EmB+oWA8JWtzylulo/etlZ83hjuyPeLHdo1d7?= =?iso-8859-15?Q?2hbpoCM+Nro9ah0X06vb3FNlJ6Uq2n+Xz+pP0XRv4cXaJA9cnReQv0a5C?= =?iso-8859-15?Q?vOxeKI+/+8jv0GM4oOA6pi/u3ELiFMGf/70RMnTvj7YDad3rd9jnTgKX4?= =?iso-8859-15?Q?gPoogXPJCG51eE1016aBABhahlrzSUN0qM1gm+ehy4IDY4rCyUXQrgDw5?= =?iso-8859-15?Q?cF2O3vrg5ZC7hikr1eIW1aAH9wUwyHyJrEfjjXfWKQB9Q5qvkQN77Lt9H?= =?iso-8859-15?Q?YbK/XloVUgtU5t1eMBsAFDWzeHgV65Aw8X1RVvzxPMBz79z9nyJW5O7vi?= =?iso-8859-15?Q?qD77DdCyRlEwyZckNaWDEWVsscU37XvIcy4ed3o/6WQNgfBFYdCugEg+w?= =?iso-8859-15?Q?IOlK2/npT7x18QqEIc6AuqIdZ5a+9bakeyc4hkFa60t3WEEjSqUZ5hPfE?= =?iso-8859-15?Q?zc7jgSzxQ49KfT6vQc+jm86LjiJ03jNjdUHPc8uAsPDs26lqosMBA5lmd?= =?iso-8859-15?Q?fuowvDX2ZAudxGS/SoKFmPzUM8sm5XP4vdflRvV9ocgSv5zKnKUb9vIzM?= =?iso-8859-15?Q?zEYKtrGYvpQd8+3VQ3YZqfwUsStMWo2/l0bHKhEMQhCamdpRcexiH5hfF?= =?iso-8859-15?Q?/ZJEQVoc039lIdG/+coj9SYHSCy/nBkQjYvKYmhCV2jCcn8zvtPtufY6n?= =?iso-8859-15?Q?wiX9CQv9TLxvFAFqH+oClf9sCABl3p2YV1N17Uy+1luPgCK5p5Uo6N2B7?= =?iso-8859-15?Q?Xp5KGIuLqQr/L9mzflkR0R8m15fULLYqpsVb9nAgmABUa/Hc072asG3jm?= =?iso-8859-15?Q?1Dy4MYPzJRvGrJyPjIW+EIwq2AMIxklAUa1IdhvPeeJ4kCTngYD674jU1?= =?iso-8859-15?Q?BDd7O6J8SU693PS6yCoT4KoTAc0tvuxq4AX++GehZ/Jzl2aEtOtUWtZ9L?= =?iso-8859-15?Q?RwehaJ5IzQMWUvqydVGokahTukM5FUeJ8zZdqwDEiT7DzjCcdij4H9Oqm?= =?iso-8859-15?Q?ycVvqb1irdRvTaIx/q/pUg+JHZHsUKLmxiXl8+P3ARWYLEGy90cXKN9n3?= =?iso-8859-15?Q?bBTuq5IxBecZfNr01JtpdpGdyM1vaLDbrfNTgmiaRqbxx?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;6:cTfJyGq3eAsyssK07kViH+BQmWQRVO6gMX7sYInN4w1kciKUGaFS5+btfvgjnQyVevrEmmV/dhTOCxPaU3iEpsXOAZvPDnqJGH8dEZ+OWsjID94rIEsPUfv4Lc/zXgbVDFTmRoSrf6gG75Wh5mYwhwk7k8/qd4oYjIDe73RLCKqre73n72ZC0/KvJ0RjfuUfe3cY3Tu9H/9qaJEc9ERYSOzfBMyBFKcn3NvGec65Jll/OI3rRj+6AWKl+/mwXUNG2OBR4ZlovAEMqu4XxMYtEbn3DslbtfNJuKPTbGNlMAtGjmOfol/PC3jigUhPQB/v+GJMalWhIyjr0WIMtU1MMg==;5:42Z8LK12jLLD+N6XwieYPwTF19c7B0NrsRpyQKT1xyMPk0H0QArGPqXWvyIOH/idPH8wyJUF99qaDZTgEU11zFN13BDCwGMhVOjJoNmFXdy/0QMY3tGVRMDJFxHXBFtv7IoAXaHEA8HVLugStE40RQ==;24:TNkEm20DbOZ5dLHawfCGjjQeO2zfo5lQ3rNyH3JZPQnP01BjKAtWFDYFFM98vwy1f/F+tRNj7LR+rXy9F5ghNFmG+C7HdJJRlAozb79z+I8=;7:zGpPOXZ99dJK/WANq7VdwvEOnji4HJg5aIbpI4lbpYJ9yeklmym+h39V9lLYK25l3ZR1NTIPpSo/F0hfxlDEmqolKcIOE1iLK9amTDIApfNvD4h7vYGwy7UzXUrHDuMWNUNSU8WbG92crW3JOSfqRRtDGgchsFiYRRvcSEsQhpMTjPRGz53sIS+/W6QJH3EQpB+DogNzcuv0ruFI4kNzNTu6QxM7AZ/Rx7XAxYEqh9KPBrvY2IJ9/pyIqn6Z5d7Y SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;20:IZnKiahuuyW3iVD6aFstUX0DtUndXlj4V9wmF9oubjoJyvLgJl7dFMIF9lMUUBURd2taVpGrFewkkO76qk/mLhOyF0sj2ldILonLwmPwcdp9pIl1YiZ3A7JnKUNR4COTyLx8kf8cDYKQCOl/U+vGxa4Gqcn9jJW3wZHMTCSyp8RXtRxNZdOpaW9EhZEY4gTir6o4Xrt0Id4AxF49Xrdl4Ikwm7tUoE9bQEzV/K5MxTGVNQ6s0otVPRx31dCxWLbG X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2016 08:13:30.6458 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1298 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 03.09.2016 um 08:01 schrieb Baoyou Xie: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:113:6: warning: no previous prototype for 'amdgpu_pll_compute' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/cz_smc.c:38:10: warning: no previous prototype for 'cz_get_argument' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/cz_smc.c:302:5: warning: no previous prototype for 'cz_smu_start' [-Wmissing-prototypes] > .... > > In fact, these functions are declared in > drivers/gpu/drm/amd/amdgpu/atombios_i2c.h > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.h > drivers/gpu/drm/amd/amdgpu/cz_dpm.h > drivers/gpu/drm/amd/amdgpu/vi_dpm.h. > So this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie Reviewed-by: Christian König . > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c | 1 + > drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 1 + > drivers/gpu/drm/amd/amdgpu/cz_smc.c | 2 ++ > 3 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c > index d153149..8e67c12 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c > @@ -25,6 +25,7 @@ > #include "amdgpu.h" > #include "atom.h" > #include "atombios_encoders.h" > +#include "amdgpu_pll.h" > #include > #include > > diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c > index bc56c8a..b374653 100644 > --- a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c > +++ b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c > @@ -27,6 +27,7 @@ > #include "amdgpu.h" > #include "atom.h" > #include "amdgpu_atombios.h" > +#include "atombios_i2c.h" > > #define TARGET_HW_I2C_CLOCK 50 > > diff --git a/drivers/gpu/drm/amd/amdgpu/cz_smc.c b/drivers/gpu/drm/amd/amdgpu/cz_smc.c > index c80c2e9..95887e4 100644 > --- a/drivers/gpu/drm/amd/amdgpu/cz_smc.c > +++ b/drivers/gpu/drm/amd/amdgpu/cz_smc.c > @@ -29,6 +29,8 @@ > #include "cz_smumgr.h" > #include "smu_ucode_xfer_cz.h" > #include "amdgpu_ucode.h" > +#include "cz_dpm.h" > +#include "vi_dpm.h" > > #include "smu/smu_8_0_d.h" > #include "smu/smu_8_0_sh_mask.h"