From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7951310E3 for ; Thu, 19 Mar 2026 06:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.110 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773902466; cv=none; b=BU5c3WQzKon/JGLAMOf+A9b54yMT4tEQgst8pNPmAe+6a4BwWNzaGhIlExZjWZ/a8Ve44330/adryUucW+eIEnXlnTKKa77u2tn1Ym6LPpU7HIViSDWTnyvse+kx042mzdrShB09Wdsb/QD3rZ8xjP/CUwxzemwm8qseSh011Gk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773902466; c=relaxed/simple; bh=SmzLZ5+0+ZBpD8vFD0SFHdXkvkK7DzWEzI/ZKHqOlaA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gJnwCPDrwyb23O2LpwGJoN0cWAVWGwnJGMmgQY0vwpK4rHtyimlAiW7mcmzZebzwKNiWmo0fP6iYHDOyrYFgLfUUCCPTDRq99BJ4w1piNnZgR+NLT7ZVZN4Bjs7gl8h2pi5oJ9Mu39nWoKPfUvpGIrdTawKfLoA0Mpa2jST9yHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=BbguUpda; arc=none smtp.client-ip=115.124.30.110 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="BbguUpda" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1773902462; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=B1mdaIGIx853k/Oe8qWYkRnKkbI6dGMHnMB8adNIIoM=; b=BbguUpdaPkbqx6EDnfKxG4GVDxL2KH5wDCmZptR59HbPhLGkzkiK6oiujIVJauggPQVWQPwmiPpBpZvLM+z+a8LPXDeAXibd+OUxPJPlMTynfhsnIl/AD5focxwwRSlMI+MnZN7f4YOqiytLuWAQE8P26n1xB+jhYXyEDbQ47Rw= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033045133197;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0X.HUZpe_1773902460; Received: from 30.74.144.123(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0X.HUZpe_1773902460 cluster:ay36) by smtp.aliyun-inc.com; Thu, 19 Mar 2026 14:41:01 +0800 Message-ID: Date: Thu, 19 Mar 2026 14:41:00 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/8] mm/huge_memory: have zap_huge_pmd return a boolean, add kdoc To: "Lorenzo Stoakes (Oracle)" , Andrew Morton Cc: David Hildenbrand , Zi Yan , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20e00d784adf1540c32b46024a709dfe1be93019.1773865827.git.ljs@kernel.org> From: Baolin Wang In-Reply-To: <20e00d784adf1540c32b46024a709dfe1be93019.1773865827.git.ljs@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/19/26 4:39 AM, Lorenzo Stoakes (Oracle) wrote: > There's no need to use the ancient approach of returning an integer here, > just return a boolean. > > Also update flush_needed to be a boolean, similarly. > > Also add a kdoc comment describing the function. > > Signed-off-by: Lorenzo Stoakes (Oracle) > --- Make sense to me. Reviewed-by: Baolin Wang