mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Victor <avictor.za@gmail.com>
To: Albin Tonnerre <albin.tonnerre@free-electrons.com>
Cc: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
	linux-kernel@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: Re: [PATCH] Add poll_get_char and poll_put_char uart_ops to  atmel_serial.
Date: Mon, 7 Sep 2009 08:22:06 +0200	[thread overview]
Message-ID: <cd73a99e0909062322j683952e6m803dd6b703bf758d@mail.gmail.com> (raw)
In-Reply-To: <20090727151900.GB4052@pc-ras4041.res.insa>

hi Albin,

Any reason you're not using the register access macro's like the rest
of the driver?

> +       while (!(__raw_readl(aup->uart.membase + ATMEL_US_CSR) & ATMEL_US_RXRDY))

while (!(UART_GET_CSR(..) & ATMEL_US_RXRDY))

> +       return __raw_readl(aup->uart.membase + ATMEL_US_RHR);

return UART_GET_CHAR(..);

> +       __raw_writel(ch, aup->uart.membase + ATMEL_US_THR);

UART_PUT_CHAR(..., ch);


Otherwise the patch looks fine to me.

Regards,
  Andrew Victor

  parent reply	other threads:[~2009-09-07  6:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30  9:05 Albin Tonnerre
2009-07-27 14:23 ` Haavard Skinnemoen
2009-07-27 15:19   ` Albin Tonnerre
2009-07-28 16:09     ` Haavard Skinnemoen
2009-09-04 15:34       ` Albin Tonnerre
2009-09-07  6:22     ` Andrew Victor [this message]
2009-09-07  9:52       ` [PATCH v2] " Albin Tonnerre
2009-09-07 18:17         ` Andrew Victor
2009-09-08  8:30         ` Haavard Skinnemoen
2009-09-11 11:31           ` Albin Tonnerre
2009-10-10 18:57             ` Albin Tonnerre
2009-11-11 11:37         ` Albin Tonnerre
2009-11-12 22:24         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd73a99e0909062322j683952e6m803dd6b703bf758d@mail.gmail.com \
    --to=avictor.za@gmail.com \
    --cc=albin.tonnerre@free-electrons.com \
    --cc=haavard.skinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®