From: Peter Chen <Peter.Chen@freescale.com>
To: "Arnd Bergmann" <arnd@arndb.de>,
"Antoine Ténart" <antoine.tenart@free-electrons.com>
Cc: "sebastian.hesselbarth@gmail.com"
<sebastian.hesselbarth@gmail.com>, "balbi@ti.com" <balbi@ti.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"alexandre.belloni@free-electrons.com"
<alexandre.belloni@free-electrons.com>,
"thomas.petazzoni@free-electrons.com"
<thomas.petazzoni@free-electrons.com>,
"zmxu@marvell.com" <zmxu@marvell.com>,
"jszhang@marvell.com" <jszhang@marvell.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx
Date: Wed, 16 Jul 2014 11:58:14 +0000 [thread overview]
Message-ID: <cd73d8a384cc4040a0bbc6afc1f3063d@DM2PR0301MB0783.namprd03.prod.outlook.com> (raw)
In-Reply-To: <5615007.cNNjmu3rBK@wuerfel>
> >
> > Some people wanted the possibility to set the DMA mask as this USB2 CI
> > driver does not do specific Berlin operation and can be reused later.
> > I don't particularly need to call dma_coerce_mask_and_coherent() in my
> > case, as far as I know.
>
> Ok, just remove the call then and rely on the default mask.
>
> > They can maybe give the restrictions they might want to put on the DMA
> > mask.
>
> If the restriction is from the bus, it should get handled automatically
> by the device probe as long as the correct dma-ranges property is there
> (though we have a small bug there at the moment). If there is a variation
> of ci13xxx that can't do 32-bit DMA, that should use a different
> compatible string and pass a fixed mask into dma_set_mask_and_coherent()
> based on the device.
>
Correct me if my below understanding is wrong please.
For three chipidea users:
user_a: don't need dma mask
user_b: dma mask value is dma_mask_b
user_c: dma mask value is dma_mask_c
We don't need to call dma_coerce_mask_and_coherent() at generic chipidea
glue driver, and set dma-ranges as dma_mask_b at user_b's dts, and set
dma-ranges as dma_mask_c at user_c's dts.
Peter
next prev parent reply other threads:[~2014-07-16 11:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 8:25 [PATCH v3 00/12] ARM: berlin: USB support Antoine Ténart
2014-07-16 8:25 ` [PATCH v3 01/12] reset: add the Berlin reset controller driver Antoine Ténart
2014-07-16 16:39 ` Andrew Lunn
2014-07-16 8:25 ` [PATCH v3 02/12] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs Antoine Ténart
2014-07-16 8:25 ` [PATCH v3 03/12] ARM: Berlin: select the reset controller Antoine Ténart
2014-07-16 8:25 ` [PATCH v3 04/12] ARM: dts: berlin: add a required reset property in the chip controller node Antoine Ténart
2014-07-16 8:25 ` [PATCH v3 05/12] phy: add the Berlin USB PHY driver Antoine Ténart
2014-07-16 9:19 ` Varka Bhadram
2014-07-16 9:25 ` Antoine Ténart
2014-07-16 9:33 ` Varka Bhadram
2014-07-16 9:47 ` Antoine Ténart
2014-07-16 9:50 ` Varka Bhadram
2014-07-16 8:26 ` [PATCH v3 06/12] Documentation: bindings: add doc for the Berlin USB PHY Antoine Ténart
2014-07-16 8:26 ` [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx Antoine Ténart
2014-07-16 8:41 ` Arnd Bergmann
2014-07-16 9:15 ` Antoine Ténart
2014-07-16 10:14 ` Arnd Bergmann
2014-07-16 11:58 ` Peter Chen [this message]
2014-07-16 12:12 ` Arnd Bergmann
2014-07-17 1:20 ` Peter Chen
2014-07-17 10:21 ` Arnd Bergmann
2014-07-17 11:19 ` Peter Chen
2014-07-17 11:34 ` Arnd Bergmann
2014-07-17 12:20 ` Russell King - ARM Linux
2014-07-25 2:18 ` Peter Chen
2014-07-25 8:07 ` Antoine Ténart
2014-07-25 8:22 ` Peter Chen
2014-07-16 8:26 ` [PATCH v3 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver Antoine Ténart
2014-07-16 8:39 ` Arnd Bergmann
2014-07-16 8:59 ` Antoine Ténart
2014-07-16 8:26 ` [PATCH v3 09/12] ARM: dts: berlin: add BG2Q nodes for USB support Antoine Ténart
2014-07-16 8:26 ` [PATCH v3 10/12] ARM: dts: Berlin: enable USB on the BG2Q DMP Antoine Ténart
2014-07-16 8:26 ` [PATCH v3 11/12] ARM: dts: berlin: add BG2CD nodes for USB support Antoine Ténart
2014-07-16 8:26 ` [PATCH v3 12/12] ARM: dts: berlin: enable USB on the Google Chromecast Antoine Ténart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd73d8a384cc4040a0bbc6afc1f3063d@DM2PR0301MB0783.namprd03.prod.outlook.com \
--to=peter.chen@freescale.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=antoine.tenart@free-electrons.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®