From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0561936D4E7 for ; Fri, 21 Nov 2025 08:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763714486; cv=none; b=bBnLXADr62QUyDrWomrDvNII5ss0JjknFxQ7HocN2iEhmDqH8CXHX3DK331PpjCDCj7UdR+mJaIVcer1uyFRIjxQ5j71BEPU4fSUEB/BsITE2QjLAHmWqfIHb6m0nCF6sR6VEKUDDihYWlR8hC91tKtEPWIzqKWAjnfV59qIj+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763714486; c=relaxed/simple; bh=rtIrDC96mTgKWbY8x0I4Pr2/zpiqTKqEpQN3wuMsceo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UeYTH7eYLxNl6TPeskg3acD9ldH8X9sgfXe3IwS5xbKYzKVmWmyilHcs6+1Lp6Alur6t5kKaZShvpnAjinqt3o5AhjDpT6H1+J3IIfZjFer3ah1lHV1gGUXpqVsXJpHng/2LdQojCY2Q0HvDMDSgJcTIXfqa9DBW/UIw2KL2xdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dWF1L1Of; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dEOavG44; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dWF1L1Of"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dEOavG44" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AL8YpEE3139454 for ; Fri, 21 Nov 2025 08:41:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1obC42n6b3J5kEBmbJSlvAg84+J6sxQ0LZfCOR4Aq0g=; b=dWF1L1Of6F4MQkX/ /5hMDCSFoJkC8knlHsE+lggQcdVIskF7gpr/h+XyZF0FM/pkHgHcEiiOAvxyXVvW bE4qURmyDGiu2IaQh3xOx6abgpdXUNhdK7YeqiV3uNHBdLXEJM2VNAI/TbNoQir0 DrqGlDlSRU1Gg/cCpRrTwqEGeI769o5DWO22lqZofq1mpXx5P/VdAPnpwurZbd9L cxQQJlKdG0AXPEkfTG/yVfiwvY34fopixbrb2w4DuW4GK2gs39jGUKpH53xigSPx kxawBMpzEZ2bF6it9Z0+2436lSQF1se5VVXjGN6CyfxaVtLxtDWi/n4pnKli7C9V v1wvAw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ajmppg0vf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Nov 2025 08:41:24 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-297f48e81b8so27439175ad.0 for ; Fri, 21 Nov 2025 00:41:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763714483; x=1764319283; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1obC42n6b3J5kEBmbJSlvAg84+J6sxQ0LZfCOR4Aq0g=; b=dEOavG44c3WTQhMlw+EsXn5FmOZ+qXhtXl0rmUsw4b5J0si649x2YMB15pB6XeBVed r3Clf/LUHtLJBpcaSzShnWLUAleuBSswMOsGjB7UbTYVCBSa3SZ96uKnbTBGYmktOeJJ zDHaEVAkIFtZPvj++PiNAf0njdNFou+1iznYqtpstp8DJB75YlRIWc1xh0a7lWLkGio2 jPRReBJFAG4GDxI+Pl7LaMgloph0Sap0LGht7cn6uHbuJh2gsJemuscS58baVgDM3TDO xlYLODYioq1l9HpR7XW7YiVVCCV0lLUTjqUrVEf7OjS2bk6faZKwFBjfEgISk9SqwomD vYLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763714483; x=1764319283; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1obC42n6b3J5kEBmbJSlvAg84+J6sxQ0LZfCOR4Aq0g=; b=Fm9Y803wCUFPvJlLHpHSqUoE6a+kADe4bQDkUBhfBpvzwL5JxrAMTvbs0LAyM/Mm+2 7NYFfiBXHcxf2k51qtvlRpfRtVCseg7/NxahZs5r48kuyh8u9SowjEKgJHIW/sTZFKu8 GyltsNeYVj6bmaFP1mNY8lMKS/xavQUul/Dux9sQproO03LEP9K8OJO9knF+c097rVFl GuIjrtyGUax0ij6p/cSBToynpjuN1gZ6Cmxp6qm8v1I68D2JYa4iBna0ehTx4zKSxRqZ dUjN6HMK8CwEd1zUjwxmfrtgumPW6Uxleqo6oP60rWXzGDCqHPPsuTF74nScpSoH3law 3yuA== X-Forwarded-Encrypted: i=1; AJvYcCWQGFkx+ipMpn/o013JuhHa9BtIT7uZoNkOVJTHobEs1h1mFDnZUnhDhu6cBvDz1JXSbOi6r/FaUTqX0OU=@vger.kernel.org X-Gm-Message-State: AOJu0YywOkNetoaZsyWJLrgR7G+ag2ItH9fZxP4hpM2xEWw/RfhXo+qR Bex6XqP+WC6dLMm5J1Wi0ayyoQKM+UnaDonePAuBVbyqJiHfrPizyS9pmKQNEY/p6tqSXj2wjRA sNvCLNfg1c0ATtZ0u8su46AMfX4Ci4CZndRhZP6YNUx/LGSavu3pI3v/9C0BIMumgMS8= X-Gm-Gg: ASbGnctM5xnkRXalHenW21ltdXvrKncSLRAxzur5wTLwdLGbOVvFf21mHcQh/ZoPBKz 17xkK9kvRLqUex3QbPQSIi8gz54KMQBHMOlAxaZ8XtziEZ9IahIKSqFhB3Be5LJf3YeA941iQKL CnrnUL/pVmQFVSttG1P+LzUogVahWLcJTPNJyKT1G/YAPljP/9iWdhoyQpgmCSr28mB/GRKQHJV j8lMj5Gy8FsDthu6XE4SJjVJEg9PS3uy1oV+bnBeStrbqLW9p+M9x3O6dxr4s96aL4zsZei+SEn 1HrZcmWSufPvkl4h7AfQkvC65jKX/c6Ij31xM0OvBznTKrSRn085u12M3A1GH180q7xwwJZkYfQ sPlR8KveNFWf7fUegw3sGKfpM1ZDHJorBPL73HZ0B X-Received: by 2002:a17:903:17c3:b0:295:134:9ae5 with SMTP id d9443c01a7336-29b6bff8643mr21811605ad.24.1763714483325; Fri, 21 Nov 2025 00:41:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHu9OhsrpqD/vOOIYbL5aK/VDwfehVXxqDU/g61B7pL8avMK0XFkCzI81AKoxkQVzFDcO6Mzw== X-Received: by 2002:a17:903:17c3:b0:295:134:9ae5 with SMTP id d9443c01a7336-29b6bff8643mr21811355ad.24.1763714482837; Fri, 21 Nov 2025 00:41:22 -0800 (PST) Received: from [192.168.29.179] ([49.43.203.163]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b274d39sm49558875ad.77.2025.11.21.00.41.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Nov 2025 00:41:22 -0800 (PST) Message-ID: Date: Fri, 21 Nov 2025 14:11:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] soc: qcom: rpmh: Add support to read back resource settings To: Konrad Dybcio , Kamal Wadhwa , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251022-add-rpmh-read-support-v2-0-5c7a8e4df601@oss.qualcomm.com> <20251022-add-rpmh-read-support-v2-2-5c7a8e4df601@oss.qualcomm.com> <9e8b47d8-9a20-40da-a6eb-cdd167c108dd@oss.qualcomm.com> <5029600e-a3b8-4aec-a374-526fb3f6417e@oss.qualcomm.com> <8580c092-3e1f-4b53-8330-ac1746b7a126@oss.qualcomm.com> Content-Language: en-US From: "Maulik Shah (mkshah)" In-Reply-To: <8580c092-3e1f-4b53-8330-ac1746b7a126@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: j51fGOIDlAXIC5Yg3QI7EGbFL_1CqF_v X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIxMDA2NSBTYWx0ZWRfX2HkhHLH6ZA02 IdNlVsw7jiYcQm6I+brpAk++2HC4gyQXltZxv7jkZuWVXSgNeZQZgNEQzBCkqCKIsoPbfZY8z4D c3x/KWFxMudkYTnRbvV8UwUaTVU2aQLF1LzU1SJ/uDjgf7tVMg+HCph7m9IcEDMDSWGl7HJ+WJS vioI0yGpmP+0asWkLMLnkLn5OXyqK89ikvOWXziQjL6XCHGv9a4v7UZfpP406bFhIi0qeueLIsK 2y7tTDKayG/WWxhPf5hDPdshG0mrkpZCuL429v3w3I6RNC8FBjqqlmNW+D3ZCtnZ/I3DjwHsKrU tSJ7DixqeMYMkmAooYd2Bf50pEY8orxLlV1FZ1uhdtdbG9fm14+U3aOtCpwVu97nwzChcORvprt XmCxQfOpEoUhpYjsRGG9e+UV3D0c1g== X-Proofpoint-GUID: j51fGOIDlAXIC5Yg3QI7EGbFL_1CqF_v X-Authority-Analysis: v=2.4 cv=CK4nnBrD c=1 sm=1 tr=0 ts=692025b4 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=hPSFuvTr37ou3SCYi0sSZg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=N99UGyZIW9bo-gJ1gAMA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-21_02,2025-11-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511210065 On 11/17/2025 6:04 PM, Konrad Dybcio wrote: > On 11/17/25 9:26 AM, Maulik Shah (mkshah) wrote: >> >> >> On 11/12/2025 4:56 PM, Konrad Dybcio wrote: >>> On 10/21/25 11:08 PM, Kamal Wadhwa wrote: >>>> From: Maulik Shah >>>> >>>> All rpmh_*() APIs so far have supported placing votes for various >>>> resource settings but the H/W also have option to read resource >>>> settings. >>>> >>>> This change adds a new rpmh_read() API to allow clients >>>> to read back resource setting from H/W. This will be useful for >>>> clients like regulators, which currently don't have a way to know >>>> the settings applied during bootloader stage. >>>> >>>> Link: https://lore.kernel.org/r/20250623-add-rpmh-read-support-v1-1-ae583d260195@oss.qualcomm.com >>>> Signed-off-by: Maulik Shah >>>> Signed-off-by: Kamal Wadhwa >>>> --- >>> >>> [...] >>> >>>> +int rpmh_read(const struct device *dev, struct tcs_cmd *cmd) >>>> +{ >>>> + DECLARE_COMPLETION_ONSTACK(compl); >>>> + DEFINE_RPMH_MSG_ONSTACK(dev, RPMH_ACTIVE_ONLY_STATE, &compl, rpm_msg); >>>> + int ret; >>>> + >>>> + ret = __fill_rpmh_msg(&rpm_msg, RPMH_ACTIVE_ONLY_STATE, cmd, 1, true); >>>> + if (ret) >>>> + return ret; >>>> + >>>> + ret = __rpmh_write(dev, RPMH_ACTIVE_ONLY_STATE, &rpm_msg); >>> >>> Is there a reason for making this ACTIVE_ONLY? >> >> Yes, using ACTIVE_ONLY makes the read request place immediately to read back the current resource setting. >> Sleep/Wake are H/W based trigger and are not applicable for this API. > > Huh? So if I send a read request with e.g. SLEEP_STATE, it would only > get fulfilled upon an active->sleep transition? > Read requests will get fulfilled immediately with the return of the current resource setting, there is no separate active/sleep/wake vote values that can be read, put it other way the rpmh_read() API do not take any "enum rpmh_state state" argument like various rpmh_write_*() APIs. Thanks, Maulik