From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C28D3AFB11 for ; Mon, 22 Jun 2026 13:03:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782133428; cv=none; b=mbc92HbBz6FhOgKOWIITklku4cRAT2myzOytFKUnl+c3sAc7hO6VhX/Zp38UyDW66qzB8izckVhcFn9E29fsaJyc+eXzekHX9x/YwF9IrBOAef6FOZLbIY+WB2rvQbMVsA2MMNvJ8cSUmBP61PcWcQ3vl5keaCEIbjtbFHYywCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782133428; c=relaxed/simple; bh=LfAbiZfa6DruHOchJf2O4gSn9hmUf0OdHh+EKVCKKXI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=if+Z4hLhNWSnEt9d7kLaB+HxZPv9q5u5M+XLl1Y8/NqgN51tyxa9ZYU/4KSbedOBQCUwI2Nwzf5Rg5TJL19H8KAD+F+RyVjQoUjoYxZgKn2htGs0fcHPnIAfX9Ovzur0WgKr2zhTzVqyYlGDN47kZ7s8hksfx5bQni23f5vYLh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PyJuQkgb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Xnehh1oS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PyJuQkgb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Xnehh1oS" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MAn6Ps452379 for ; Mon, 22 Jun 2026 13:03:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= S+/LkGW4Qe6UVR0xMsntXktSlgIAIOfnsCAKWcIu3AE=; b=PyJuQkgbpZxw0ED3 n9c8oId4IxnAv67n5SzKZ5wC+rDiXkvbqjIWuBPW2NWS1rx47/jQeMJApXWHip2o zf4PERzFf6QneBe2Tnc2pAep9kFt2IeVfpcqWnI6ClBpmnZtAYpZ4OxTckdtFbUd USm9qfwcvnvoA4Mr90evhQSdMrrMoOW2MnQ6BA2vQa9q1YgZmdLuq2DbX5feEzbM ZNeFJ/I43buR8bB1AHrJUqmaLamM9ixjxT207VM0PjEW7BmUynkg4cjqqFuSpBLu X7JwQgqZhCuwPcQpRIFs+z4557OtKDtInqpJablp1X/TbptZBlIMwRm/nNhqE+rj CXZF6A== Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey2yj8k7y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Jun 2026 13:03:44 +0000 (GMT) Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-7e6f5350426so2092782a34.1 for ; Mon, 22 Jun 2026 06:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782133423; x=1782738223; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S+/LkGW4Qe6UVR0xMsntXktSlgIAIOfnsCAKWcIu3AE=; b=Xnehh1oSMHPDZjQFftALuI04UPjI4hTyoaBBwDroC/HReK1LQizYg1+br2QwP4Ui3L digdEzxbba9oaPyubK85pdTMbKqSMXuiAH5sXsjJf2mpMHAopqqquKezIql7im9ZHHGH XBmjZBA8JyGJClpw08mM1ihU7xPQQPN+PAR1u1ArQvt3ArrTjJjgOXS8g+F0zs8EAt3Z vbzhspPON68SmPB4JfBeW9BagYfRZ12e9I7sW2dBXN1kaoXp6K9e/MdK1Fwrw7ksqvKv yZ5UvN0BfQrB4DbsXbwrROUa3VtRVIRtns+bTRK2hpqlFT/F18UPr573FGwbz3wZxA1p TCJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782133423; x=1782738223; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S+/LkGW4Qe6UVR0xMsntXktSlgIAIOfnsCAKWcIu3AE=; b=WXMXLKGUFuJ4rXdKIo59ywXZ1SwQthlz0lCei731xKEbKN6LY+NaY78OuyJAv6UNPk hN2lEUqU2VPeZXkRvqa8cZmGdrouSlky7KRa76EBGxR/it3UgbcGafg9oouoY+WtFA85 SSx+MMxpWP5KHWKaCK2AIEiDfopso2eYcMB528vqB8pQmyNYJLq8Qt2GA5PyUIr98gra rTnp938/MDp0ftqCCqS0EQuxfwJW/GebN2IkiZOFuLXmij4lFUydn5F4jC9G/4mxz0DU x1hSPEu8yAdA70Q19QLe1C3UXV2fXCi947L0HLM98qTEsFyA1ClPA2YKDJdBoaglM+w6 SRdw== X-Forwarded-Encrypted: i=1; AFNElJ+NuQtp8ryk2BmwniGqXBjg9ou+WKcA0oMWJFY9CyXjQuebF04AIYyPXwkZXBcGZK8UhVvjFuqvDSYU2BE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+nYPvXFyo57Tkj8/76mta0Zno/3Aa4jR1g6DMh++tKUJKtvgK ol+ushT1+P65Hz8LOHB5lhQwi2X3D/W89zwKkkWdPSyepSYVpi+ZP2ZjZ0ZtpCYXuaYD2QNhJX0 aVDABL6cDKnXoKuY3VwcCuR9FXcIejn7bKPkpYRMzOSBIbL36kOUkrXhDAqUh7zjmYLw= X-Gm-Gg: AfdE7cnYh2LxFq75btrmRYqciqSKzmtVqTldPw/qLvFC6k0hhZY0MMKgWxKbDYn2Gr0 2K296Kxn/Kc2UG72lIUY9xApxFnHYcy73Afs0KeydIvlMNCM15dSDnmGoFL3lKK9scHHVnvrwPT 2rTTvvPlTbNS0vrCqcoUfOdZKFyF0tNsgEUOa3dQUbFTVCof8b8+3cv5sJolVp8MVfTFT/j1Z2u Z1Eh3MU9DOkLKFoQkNeMum2D4qOg0g2PiJGoHt3hyZPQFHCt8dASjINAsISug6VrSRhrB0dqNuK /yn3o6BMW+NQx2O9Jum9RUkXp0zi75dHW0igRY6NzztrEl05syDK0Mz+gI+Vwl2T2R1B6u+w+yK PWmuqTp8/vNFU/7azl+sD/Kmo+g9HYwCmjMY= X-Received: by 2002:a05:6830:2585:b0:7e6:da95:a7b4 with SMTP id 46e09a7af769-7e970b12dbcmr130897a34.4.1782133423596; Mon, 22 Jun 2026 06:03:43 -0700 (PDT) X-Received: by 2002:a05:6830:2585:b0:7e6:da95:a7b4 with SMTP id 46e09a7af769-7e970b12dbcmr130872a34.4.1782133423141; Mon, 22 Jun 2026 06:03:43 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c5e49b77bsm356454866b.2.2026.06.22.06.03.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2026 06:03:42 -0700 (PDT) Message-ID: Date: Mon, 22 Jun 2026 15:03:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/8] clk: qcom: tcsrcc-glymur: Add Mahua QREF regulator support To: Qiang Yu Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krishna.chundru@oss.qualcomm.com References: <20260621-tcsr_qref_0622-v6-0-c939c22ded0c@oss.qualcomm.com> <20260621-tcsr_qref_0622-v6-5-c939c22ded0c@oss.qualcomm.com> <5f32d4c2-f90d-4f66-96b1-c9c7987ac18e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: T3KLniUV-VEDoPKrlG7os9u7fhWqsq1S X-Proofpoint-GUID: T3KLniUV-VEDoPKrlG7os9u7fhWqsq1S X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDEyOSBTYWx0ZWRfX0Sn9K1EhS4E1 5GmH5VQvvhxqlOqtiAtNf1rxLI+M/20rO4xFltnMfr/FMR3VWSmDKeBOXVvhla6/i+MpxQ5Ff9a nJ2rE9qVI3+ILLPykwxxotkZ/28PVOw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDEyOSBTYWx0ZWRfX9a3jF81oSA+e pdD6Pzm2OybIANtWt8f1V+eCAP1eZa8sd8sIBDCSFMqkcZP/ysUC2TMBdTM73NY6u0RbqdiuwZu 8eZHi2UohBhvbeQeX0sQ3n6Qwtkii2kpC25N81OaP9ekHLVtkRb7u+pYF/bs+gRf8JxGrL2Y9Sh UgznYJzL9JCvWnxmg4mjsrp2geqKZd8VO7c+ALyL/Cvdc1mdtIgeHgG5NNssXSljqp9iFNfHCgM 2CcbFTt5q4a9J86Qb4QJ54/o3KeJdpNiaNLoS8zsE2nRAYBTaYgUMtFbW6X/qdW9gohUn+1dmis ecO+nJLItDnExxn9HRo4bXko6bRsGNfuQMtzQJSiOikRb4xk8EilFMlX0J7gWbGwd6qMfaklr6f K1Y9+cn9HvUYm7UNy47y1h2STA6W7ucfmWBVvRclrgtDwnFxp10rkU6HQyTTeADlTMyQeC5snx8 aFlNiuZWU8DOOJil4ew== X-Authority-Analysis: v=2.4 cv=YLSvDxGx c=1 sm=1 tr=0 ts=6a3932b0 cx=c_pps a=OI0sxtj7PyCX9F1bxD/puw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=pFwZyuztDp_4AeEFtcYA:9 a=QEXdDO2ut3YA:10 a=Z1Yy7GAxqfX1iEi80vsk:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_02,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 bulkscore=0 clxscore=1015 phishscore=0 adultscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606220129 On 6/22/26 2:49 PM, Qiang Yu wrote: > On Mon, Jun 22, 2026 at 01:35:45PM +0200, Konrad Dybcio wrote: >> On 6/22/26 7:11 AM, Qiang Yu wrote: >>> Mahua is based on Glymur but uses a different QREF topology, requiring >>> distinct regulator lists and clock descriptors for its PCIe clock >>> references. >>> >>> Add mahua-specific regulator arrays and clk descriptor table, and use >>> match_data to select the correct descriptor table per compatible string at >>> probe time. >>> >>> Signed-off-by: Qiang Yu >>> --- [...] >> You're also missing PCIe_1_CLKREF_EN (+0x48) (for PCIe5) >> which goes through CXO1_>TX->RPT0->RPT1->RPT2->RX2 > > I have removed PCIe_1_CLKREF_EN in dts node because PCIe5 PHY doesn't > require QREF. So I didn't provide its structure here. I don't quite get what you mean. I see that it is there in the graph Konrad