From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DBC318024 for ; Thu, 13 Nov 2025 13:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763040786; cv=none; b=MKJ7kzxFenOcHZuPAaEt5BXkz9INmhWn5smAeALpaAp/4w4lCFKnX1qqxEm6sT1XJnZkZ32G4Jor0g44ZE1zkvt+XsBx4AzJtTeSzM0NLUGxqH/7g3hBaJGQHTgHEbmqIi0p/T/I7omhiXS0GSlhI+7oz9BGQ1SB178L3DMar0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763040786; c=relaxed/simple; bh=WXUFQbgGI72BGKFWLLzMLBxPdA8zEK4LiioFwjl4y0E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NlqfzqcOxBJiFnsmFrTr6N8Mem9tEsNxv1oQ8TY0etQFoB65i8HVbXd4qwgmK+MfJWWX9tDlf1theD2x0Xq6/YSrUseyxttLa+QctGAQEUGxdVtORbsm8nwSu5mq2T/3FTSEiQK5OiMDVR8GyHDr26Mn3JnwcP8jQN67rfoKKQg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dCTchLVV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S4MiiTFC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dCTchLVV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S4MiiTFC" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AD9QGBP3121987 for ; Thu, 13 Nov 2025 13:33:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wNLEUtImMXvAmjKIRtueCGZIQNgFOT3pJRe5fakSwLQ=; b=dCTchLVV2jAjgWiY ICFZIXcCA1dJnIdIViz48q5cmif6mK4Tv0rs91XKwf+WAKqP0coiOozMAqCNtf54 v6WWSIzwslz5D+1JkALoTwwk/ae6y6C0EuTKEYl1O4rTOgn9jwhIMXqcJKyIBLLY GH+s4I/2nY0dwLFEo34gHaWMjv5jNRb9nyCg3ZtM58/JWNfCxxyRH82pTPnFmMUq 7osKcoZo/tExDV4AhVEQD/W6FWf5rXTVCv2+piy1J93B+Y6hkdoZc9qgOc+61TyO XCK3H+LqmC4PnvDoQJ9QUGE62ObKb9yqGEqPJM9kWCxuO1TDgaUYSBWnqQ0cRRAI BI+hQg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ad5put0p6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Nov 2025 13:33:03 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ed74694decso1444401cf.0 for ; Thu, 13 Nov 2025 05:33:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763040782; x=1763645582; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wNLEUtImMXvAmjKIRtueCGZIQNgFOT3pJRe5fakSwLQ=; b=S4MiiTFCul1cQhmfXnht+b6ATdsH0JMjbcbDvDo3MrzaUqUSdD6lyxcb9ktD0oktW0 FOLpdSusJYJd0zsI8CIhbbwufaddB5DlQ7OWsLChIIDL04MKu175s3n+kBYuxxPIw8QK YaK+2gC/o2XB2I9mL+avjJH2VTIYnd4wPnddCSveeZx8CIQosuudLimIqCnDpuMqVYBz Nm7ts6SM5xPBU26xLaiXCra9UVwY46nLFEjhlHLJ1oGp0Xdn+EopkElfp2sXBFpWTX4Y KrPfvZ1lEZ9iJbc8K2GaMuVSWe/1JLgXwm9uJDcHynR7nLyJJl/nJkqVbOC7LIBZvyyt tRjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763040782; x=1763645582; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wNLEUtImMXvAmjKIRtueCGZIQNgFOT3pJRe5fakSwLQ=; b=ZIbvc7m/7Nq2QTYt/4+Dfgn9exkeygrwlqh7qmm+OQPtIJoEiyp5VfTob7wTFptQuD mRgA++Ag13BuGXf9ELW51TGKIlwnbjN7OFcmdZ/22HWClaAZRZoNgvZaRsVO3qKnFnyg A9G6Vd4xnUpw4fHbBsBjH9qHU2AJLT+wntISNX8vFD/hG79475upx/DNey3wRtuI+kIS e8hT8RgdUomsHs5F6w4vHmbX0naKTb30+golUhi6/l3hZb9O9tgOrE9Lud74KbUyNZjt l34NE1/kbO1r3/baEoTTmhqDk63WdUortEMmbtKginecJk3TKUfF6cBjCwHaywc2Y8PC tk4g== X-Forwarded-Encrypted: i=1; AJvYcCXiCIT7jHqgX8lvdK84pG1ug3rVFlxD96/2tph8KF2FrUagCKyL6lGIGLe3Asf/j0whOzSb3oU6dHj6/Ac=@vger.kernel.org X-Gm-Message-State: AOJu0YwUUqXGKPRb5qND816h3/dBvD215e5YcoRTINI1FVFAdG/U8tA6 j+S74K6pr0VPtYtUUaC6fw3IR5q3QXpccF/oOT8e57ZTvFTg8cTNM/SY+H0rp3eZXEa0vw1CQou vRyczyhphPkz/A/STpWVoUqwi5S4zS5bHC/hGPWUxjD/aUgjPR661dXRT45/B6v2ZAVs= X-Gm-Gg: ASbGncuvI/vumRU0NC/qOZk74pyGOL83YjHz0s6/djxrD0dARiEvG3Cwf4tEYtOjPtW 0znEt468upptf8UKfl8hJjmMiWa3+bTinX3iL/1gO32Qk5toxeZ+aE+wamVATdUWfL8dZzMxrYt vv802lvjic8bTX56kX+oTT8pEVcf0BoHgcvhJoa6CtvcjY1L10BwnSwlrhatzNy+kGQyRl4d2AQ Yp+YWp2iiOx6s2pV22dk8RTMDMHkbB+IdLXz2gp63SJihJM7fQsPK6IC2jPKDcbozMtxlQIu0J9 F2zUgfgYvK8ilcMO6qCJ8E3dmGOVmnNnkr9fUCCEw0fIQ4Q1KCVNUf89/1gUnnRREinBE+RLbIk pU98+c2FJSH3Fg0u2qOtWBKl6kdtO525h8DLKDYrfStneWKppW63/W3pC X-Received: by 2002:ac8:5d8e:0:b0:4ed:b9ee:3ce2 with SMTP id d75a77b69052e-4eddbdae8demr64144801cf.11.1763040782409; Thu, 13 Nov 2025 05:33:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IGrzhJHhVjwGaQu/IkcGeYInBcpQOo8PGlB0mVpgZ0Fcc+3wNub2niPYVso88lX2dAHMTacPQ== X-Received: by 2002:ac8:5d8e:0:b0:4ed:b9ee:3ce2 with SMTP id d75a77b69052e-4eddbdae8demr64144061cf.11.1763040781802; Thu, 13 Nov 2025 05:33:01 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fd80a11sm162333266b.39.2025.11.13.05.32.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Nov 2025 05:33:01 -0800 (PST) Message-ID: Date: Thu, 13 Nov 2025 14:32:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/8] net: stmmac: qcom-ethqos: use generic device properties To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Jose Abreu , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Matthew Gerlach , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Keguang Zhang , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Lad Prabhakar , Heiko Stuebner , Chen Wang , Inochi Amaoto , Emil Renner Berthing , Minda Chen , Drew Fustini , Guo Ren , Fu Wei , Nobuhiro Iwamatsu , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Shuang Liang , Zhi Li , Shangjuan Wei , "G. Jaya Kumaran" , Clark Wang , Linux Team , Frank Li , David Wu , Samin Guo , Christophe Roullier , Swathi K S , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski References: <20251107-qcom-sa8255p-emac-v5-0-01d3e3aaf388@linaro.org> <20251107-qcom-sa8255p-emac-v5-2-01d3e3aaf388@linaro.org> <21a3d269-76e6-4da9-aa25-bfd1fb6dfb07@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=E6/AZKdl c=1 sm=1 tr=0 ts=6915de0f cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Pp6BL5jzwldociJZjw0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTEzMDEwMyBTYWx0ZWRfX0PcmG0p2KDQO 6pDz54ju6xEkFrCqCs2SdiwXc/QOZdLK1Q86IcBPrgHNnQ6G3khjDTjsCV67VYu3DRKfOaFJHjy gfRYXcg5Q3V84paV7YEvTTQn6lurdJZ8jBl+Gll4PHAqfcP2BK1pU/6Ltb20PnotFCOUlRqDtxk ul8JWX3AaxbNA94ybnJ6D9I3QOioJ4AAZKV6tOoDDeipkc/IHB8BpeKrkX7s34ONkhzHSmus5Hd 7I0E7pAr2AAwihaNJd/Dhjs2fzOSL+4aSNpUcqhNv5VhTrGvaOPBU9S7S6Ua96l8b0UXmosMAT1 T8gahIHDxs9sa/KmHZ4Offmgi/HoHrxaF1o3a8Bh3kvPTP/Ko1ZAk3T9ji3w5uo0tNe5jsInvsE aT+EL3gA2OZXinJhzz2qKyFvB4HHoA== X-Proofpoint-GUID: sKpJxxHmCUxTiWkt7DVmQ2QUEzGCk0Id X-Proofpoint-ORIG-GUID: sKpJxxHmCUxTiWkt7DVmQ2QUEzGCk0Id X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-13_02,2025-11-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511130103 On 11/13/25 2:18 PM, Bartosz Golaszewski wrote: > On Fri, Nov 7, 2025 at 11:49 AM Konrad Dybcio > wrote: >> >> On 11/7/25 11:29 AM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> In order to drop the dependency on CONFIG_OF, convert all device property >>> getters from OF-specific to generic device properties and stop pulling >>> in any linux/of.h symbols. >>> >>> Signed-off-by: Bartosz Golaszewski >>> --- >> >> [...] >> >>> - if (of_property_read_bool(np, "snps,tso")) >>> + if (device_property_present(dev, "snps,tso")) >> >> This is a change in behavior - "snps,tso = <0>" would have previously >> returned false, it now returns true >> > > This property is a boolean flag, it cannot have a value. Every DT property may have a value, so this is not as obvious as we'd like it to be (IIUC - unless that changed recently) Konrad