From: Chao Yu <chao@kernel.org>
To: "mason.zhang" <masonzhang.linuxer@gmail.com>
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] f2fs: fix CURSEG_HOT_DATA left space check
Date: Wed, 20 Aug 2025 10:58:46 +0800 [thread overview]
Message-ID: <cd82a673-aa43-46bc-be67-6924500376ef@kernel.org> (raw)
In-Reply-To: <20250806123236.4389-1-masonzhang.linuxer@gmail.com>
On 8/6/25 20:32, mason.zhang wrote:
> This fix combines the space check for data_blocks and dent_blocks when
> verifying HOT_DATA segment capacity, preventing potential insufficient
> space issues during checkpoint.
>
> Fixes: bf34c93d2645 ("f2fs: check curseg space before foreground GC")
> Signed-off-by: mason.zhang <masonzhang.linuxer@gmail.com>
It breaks f2fs/005 of xfstests, can you please take a look?
Thanks,
> ---
> fs/f2fs/segment.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
> index db619fd2f51a..d8dae0049b6a 100644
> --- a/fs/f2fs/segment.h
> +++ b/fs/f2fs/segment.h
> @@ -649,7 +649,7 @@ static inline bool has_curseg_enough_space(struct f2fs_sb_info *sbi,
> get_ckpt_valid_blocks(sbi, segno, true);
> }
>
> - if (dent_blocks > left_blocks)
> + if (dent_blocks + data_blocks > left_blocks)
> return false;
> return true;
> }
next prev parent reply other threads:[~2025-08-20 2:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 12:32 mason.zhang
2025-08-07 8:00 ` Chao Yu
2025-08-15 16:40 ` [f2fs-dev] " patchwork-bot+f2fs
2025-08-20 2:58 ` Chao Yu [this message]
2025-08-20 17:44 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd82a673-aa43-46bc-be67-6924500376ef@kernel.org \
--to=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=masonzhang.linuxer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®