From: Andrew Lunn <andrew@lunn.ch>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH net-next 2/2] net: stmmac: platform: add support for phy-supply
Date: Tue, 18 Jul 2023 00:27:02 +0200 [thread overview]
Message-ID: <cd8c177e-7840-4636-a039-dbe8884b3d2b@lunn.ch> (raw)
In-Reply-To: <20230717164307.2868264-2-m.felsch@pengutronix.de>
> +static int stmmac_phy_power(struct platform_device *pdev,
> + struct plat_stmmacenet_data *plat,
> + bool enable)
> +{
> + struct regulator *regulator = plat->phy_regulator;
> + int ret = 0;
> +
> + if (regulator) {
> + if (enable)
> + ret = regulator_enable(regulator);
> + else
> + regulator_disable(regulator);
> + }
> +
> + if (ret)
> + dev_err(&pdev->dev, "Fail to enable regulator\n");
'enable' is only correct 50% of the time.
> @@ -742,6 +786,8 @@ static int __maybe_unused stmmac_pltfr_suspend(struct device *dev)
> if (priv->plat->exit)
> priv->plat->exit(pdev, priv->plat->bsp_priv);
>
> + stmmac_phy_power_off(pdev, priv->plat);
> +
What about WOL? You probably want to leave the PHY with power in that
case.
> @@ -757,6 +803,11 @@ static int __maybe_unused stmmac_pltfr_resume(struct device *dev)
> struct net_device *ndev = dev_get_drvdata(dev);
> struct stmmac_priv *priv = netdev_priv(ndev);
> struct platform_device *pdev = to_platform_device(dev);
> + int ret;
> +
> + ret = stmmac_phy_power_on(pdev, priv->plat);
> + if (ret)
> + return ret;
And this needs to balance with _suspend when WOL is being used.
Andrew
next prev parent reply other threads:[~2023-07-17 22:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 16:43 [PATCH net-next 1/2] dt-bindings: net: snps,dwmac: add phy-supply support Marco Felsch
2023-07-17 16:43 ` [PATCH net-next 2/2] net: stmmac: platform: add support for phy-supply Marco Felsch
2023-07-17 22:27 ` Andrew Lunn [this message]
2023-07-18 8:38 ` Marco Felsch
2023-07-18 13:10 ` Andrew Lunn
2023-07-18 13:15 ` Marco Felsch
2023-07-17 22:30 ` Andrew Lunn
2023-07-18 8:35 ` Marco Felsch
2023-07-18 13:08 ` Andrew Lunn
2023-07-18 13:15 ` Marco Felsch
2023-07-17 16:47 ` [PATCH net-next 1/2] dt-bindings: net: snps,dwmac: add phy-supply support Krzysztof Kozlowski
2023-07-17 16:57 ` Marco Felsch
2023-07-18 7:59 ` Krzysztof Kozlowski
2023-07-18 8:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd8c177e-7840-4636-a039-dbe8884b3d2b@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=m.felsch@pengutronix.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®