From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758064AbcGKHnR (ORCPT ); Mon, 11 Jul 2016 03:43:17 -0400 Received: from regular1.263xmail.com ([211.150.99.131]:42545 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751421AbcGKHnP (ORCPT ); Mon, 11 Jul 2016 03:43:15 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: frank.wang@rock-chips.com X-FST-TO: frank.wang@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: frank.wang@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] arm64: dts: rockchip: support the usb2phy for rk3399 evb To: Heiko Stuebner , Caesar Wang References: <1467866800-24794-1-git-send-email-wxt@rock-chips.com> <2150255.RfISFviJKP@phil> Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dianders@chromium.org, william.wu@rock-chips.com, huangtao@rock-chips.com, eddie.cai@rock-chips.com, william.wu@rock-chips.com, frank.wang@rock-chips.com From: Frank Wang Message-ID: Date: Mon, 11 Jul 2016 15:43:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <2150255.RfISFviJKP@phil> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 2016/7/7 18:11, Heiko Stuebner wrote: > Hi, > > Am Donnerstag, 7. Juli 2016, 12:46:40 schrieb Caesar Wang: >> From: Frank Wang >> >> This patch adds the usb2phy needed dts node information for rk3399. >> >> USB2.0 PHY is comprised of one Host port and one OTG port. >> Host Port is for USB2.0 host controller; OTG port is for USB2.0 part of >> USB3.0 OTG controller, and as a part to construct a fully feature TypeC >> subsystem. >> >> The USB2.0 vbus gpio is board specific, it's no same with all rk3399 >> boards, so move it into evb voard. >> >> Signed-off-by: Frank Wang >> Signed-off-by: Caesar Wang >> --- >> >> arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 4 ++++ >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 19 +++++++++++++++++++ >> 2 files changed, 23 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 4c84229..21d147f 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -242,6 +242,25 @@ >> status = "disabled"; >> }; >> >> + usb2phy: usb2phy { >> + compatible = "rockchip,rk3399-usb-phy"; >> + rockchip,grf = <&grf>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + usb2phy0: usb2-phy0 { >> + #phy-cells = <0>; >> + #clock-cells = <0>; >> + reg = <0xe458>; >> + }; >> + >> + usb2phy1: usb2-phy1 { >> + #phy-cells = <0>; >> + #clock-cells = <0>; >> + reg = <0xe468>; >> + }; >> + }; >> + > The rk3399 uses the innosilicon usb2 phy and the binding we've come up for > it looks a lot different than the above. So I'm not sure where this is > coming from, especially as I haven't seen the driver part for the rk3399 at > all yet. So far Frank was always working on te rk3366 variant, which seemed > to be the most complete. Yeah, rk3399 is ready for using the new driver and the binding which I have handed out earlier, but it seems that they have not applied yet, so shall we send out the new patches for rk3399 until they will be applied? BR. Frank > Heiko >