From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754282AbdGXQVt (ORCPT ); Mon, 24 Jul 2017 12:21:49 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:34948 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbdGXQVn (ORCPT ); Mon, 24 Jul 2017 12:21:43 -0400 Cc: Sudeep Holla , Linux Kernel Mailing List , Rob Herring , Alexey Klimov , Loc Ho , Mark Rutland , "arnd@arndb.de" , Jassi Brar , Roy Franz , Harb Abdulhamid , Matt Sealey , ALKML , DTML , Nishanth Menon Subject: Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI To: Jassi Brar References: <1498492513-29771-4-git-send-email-sudeep.holla@arm.com> <1499446341-5956-1-git-send-email-jaswinder.singh@linaro.org> <5f2e4f3c-297b-c5f8-9244-399c1c4e2c21@arm.com> From: Sudeep Holla Organization: ARM Message-ID: Date: Mon, 24 Jul 2017 17:21:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/07/17 16:41, Jassi Brar wrote: > On Mon, Jul 24, 2017 at 3:20 PM, Sudeep Holla wrote: >> >> >> On 08/07/17 06:32, Jassi Brar wrote: >>> Hi Roy, Matt, Nishant, Harb Abdulhamid, Loc, >>> >>> I have a gut feeling you guys were part of the SCMI spec committee. If >>> so, could you please chime in? >>> >> >> I take complete silence as no objection. >> > I take it as no self respecting developer/architect would stand by > your FUBAR implementation of SCMI. > Wow really ? This is exactly how ACPI PCC works today IIUC. > SCMI calls > mbox_send_message(struct mbox_chan *chan, struct scmi_xfer *xfer); > > whereas the API expects > mbox_send_message(struct mbox_chan *chan, struct controller_specific *xfer); > That's not hard to change but you seem to have combined my ARM MHU changes into this which is totally wrong and now I say also stupid after mentioning the same thing so many times. Consider them independently and try to understand. > As the maintainer I have tried to explain it to you in a dozen ways. > If you still can't see how it's broken, you can't be helped. > Sorry but you wanted driver to explain initially. I posted them. But you haven't answer my specific questions yet. -- Regards, Sudeep